Virtually Nick
90e15cb706
GUACAMOLE-1241: Merge avoid double-free when building against FreeRDP development snapshot.
2020-12-25 07:30:06 -05:00
Michael Jumper
9475c0b6fa
GUACAMOLE-1241: Build against Debian repository that has non-snapshot version of FreeRDP.
...
Debian stable currently provides a FreeRDP package that is a snapshot of
commit 2693389a103394e035edc2a01055ca2c9ccccb21, whereas
stable-backports provides a FreeRDP package from release 2.2.0. Only a
release or release candidate can be relied upon for consistent behavior.
2020-12-24 13:15:58 -08:00
Michael Jumper
218f8d36b1
GUACAMOLE-1241: Disable build against FreeRDP development snapshots unless *explicitly* overridden.
2020-12-22 20:53:06 -08:00
Virtually Nick
b608bb1513
GUACAMOLE-1242: Merge move "connection closed" log message to debug level.
2020-12-22 18:02:35 -05:00
Michael Jumper
3196f9f0d0
GUACAMOLE-1242: Move "connection closed" log message to debug level.
...
It is expected under normal circumstances that the connection may be
abruptly closed, including during the handshake. For example, this will
commonly occur when a TCP load balancer is performing a simple service
health check.
An message noting that the connection has been closed during the
Guacamole protocol handshake is really only of benefit when debugging,
where that information may provide useful context. If not debugging, the
message amounts to log noise.
2020-12-22 13:00:48 -08:00
Mike Jumper
47c7450f0f
GUACAMOLE-1110: Merge changes adding a guacd service group.
2020-12-09 17:28:17 -08:00
benrubson
4a5a350f59
GUACAMOLE-1110: Create a proper dedicated service group
2020-12-07 10:35:06 +01:00
Mike Jumper
7fcddef117
GUACAMOLE-1205: Merge version number bump to 1.3.0.
2020-11-03 14:29:21 -08:00
Nick Couchman
c867d392d0
GUACAMOLE-1205: Update Guacamole Server version numbers for 1.3.0 release
2020-11-03 14:54:55 -05:00
Virtually Nick
c2c67ee34d
GUACAMOLE-221: Merge handle FREERDP_ERROR_* constants only when defined.
2020-11-03 13:54:31 -05:00
Michael Jumper
1e3fc25268
GUACAMOLE-221: Handle FREERDP_ERROR_* constants only when defined.
...
Only FreeRDP 2.0.0-rc3 and later support all the constants used within
src/protocols/rdp/error.c.
2020-11-03 10:14:51 -08:00
Virtually Nick
1e856d4e2d
GUACAMOLE-221: Merge rely on FreeRDP error code if no RDP disconnect reason is available.
2020-11-02 22:16:43 -05:00
Virtually Nick
4d3280e817
GUACAMOLE-221: Merge terminate keep-alive thread immediately upon guac_socket_free().
2020-11-02 20:09:18 -05:00
Michael Jumper
8041585379
GUACAMOLE-221: Increase verbosity of logged FreeRDP-related errors.
2020-11-02 15:40:29 -08:00
Michael Jumper
2a4ecda216
GUACAMOLE-221: Terminate keep-alive thread immediately upon guac_socket_free().
...
The keep-alive interval is identical to the timed client free used by
guacd. This results in a race condition where there is a random chance
that guacd will assume that the client has failed to terminate in a
timely manner simply because guac_socket_free() is waiting for the
keep-alive thread to finish.
2020-11-02 14:57:43 -08:00
Virtually Nick
c48feb30f5
GUACAMOLE-221: Merge ensure guacd always enables broadcast socket keep-alive.
2020-11-02 16:00:59 -05:00
Michael Jumper
1e550b58d9
GUACAMOLE-221: Ensure guacd always enables broadcast socket keep-alive.
2020-11-02 12:51:58 -08:00
Michael Jumper
1e8d9d92a5
GUACAMOLE-221: Rely on FreeRDP error code if no RDP disconnect reason is available.
2020-11-02 12:38:06 -08:00
Virtually Nick
0be71a8c67
GUACAMOLE-1182: Merge ensure converted clipboard data is freed after being sent.
2020-10-30 10:12:25 -04:00
Virtually Nick
c7d3814450
GUACAMOLE-1181: Merge rely on automatic freeing of wStream only for FreeRDP 2.0.0-rc3 through 2.0.0-rc4.
2020-10-29 22:23:35 -04:00
Michael Jumper
c1ad6115a2
GUACAMOLE-1181: Warn users if the internal behavior of their version of FreeRDP cannot be tested and may be unreliable.
2020-10-29 18:29:47 -07:00
Michael Jumper
256487c95a
GUACAMOLE-1181: Only free wStream after send if FreeRDP requires this.
2020-10-29 18:29:47 -07:00
Michael Jumper
2c86e20ab9
GUACAMOLE-1181: Free wStream after send is complete/cancelled.
2020-10-28 20:23:37 -07:00
Michael Jumper
683ef1722e
GUACAMOLE-1182: Ensure converted clipboard data is freed after being sent.
2020-10-28 16:36:50 -07:00
Mike Jumper
558eb149f4
GUACAMOLE-1031: Merge correction to handling of RDP SFTP upload directory.
2020-09-27 16:34:56 -07:00
Mike Jumper
aa870debad
GUACAMOLE-221: Merge server-side support for parameter prompting.
2020-09-20 20:31:34 -07:00
Nick Couchman
3e19583b29
GUACAMOLE-221: Switch VNC credentials to NULL when parameter is not passed
2020-09-20 14:41:29 -04:00
Nick Couchman
9e1dada14b
GUACAMOLE-221: Add CUnit tests for guac_strdup()
2020-09-20 14:41:29 -04:00
Nick Couchman
3b4007c9fa
GUACAMOLE-221: Tweak logic for when RDP domain is requested.
2020-09-20 14:41:29 -04:00
Nick Couchman
bfb54f72a0
GUACAMOLE-221: Clean up libguac, protocol changes, and documentation.
2020-09-20 14:41:29 -04:00
Nick Couchman
6605f217c5
GUACAMOLE-221: Rollback changes to SSH protocol prompting
2020-09-17 21:12:33 -04:00
Nick Couchman
b6d3edb749
GUACAMOLE-221: Move VNC and RDP argv to new callback.
2020-09-17 21:12:33 -04:00
Nick Couchman
f70fdfc612
GUACAMOLE-221: Add back in SSH credential argv support; fix style and comments.
2020-09-15 14:48:15 -04:00
Nick Couchman
ec3cdfd17b
GUACAMOLE-221: We need to flush the socket after sending required.
2020-09-15 14:48:15 -04:00
Nick Couchman
26b9850d87
GUACAMOLE-221: Remove bad rebase code.
2020-09-15 14:48:15 -04:00
Nick Couchman
98dbf15d0b
GUACAMOLE-221: Fix up SSH terminal prompt fallback.
2020-09-15 14:48:15 -04:00
Nick Couchman
e8feeabfef
GUACAMOLE-221: Implement CUnit tests for protocol version comparison and conversion.
2020-09-15 14:48:15 -04:00
Nick Couchman
0db61198e9
GUACAMOLE-221: Fix up lots of comments, streamline code, and fix SSH mutex lock.
2020-09-15 14:48:15 -04:00
Nick Couchman
bc8ed4e104
GUACAMOLE-221: Implement guacd support for verifying that client can accept the required instruction.
2020-09-15 14:48:15 -04:00
Nick Couchman
b00b629b96
GUACAMOLE-221: Clean up VNC mutex; update comments.
2020-09-15 14:48:15 -04:00
Nick Couchman
0761908a77
GUACAMOLE-221: Sockets start keep alive by default.
2020-09-15 14:48:15 -04:00
Nick Couchman
c579e7337f
GUACAMOLE-221: Implement function for sending required to client owner.
2020-09-15 14:48:15 -04:00
Nick Couchman
5ec2551761
GUACAMOLE-221: Use constants for parameters updated via argv or required instructions.
2020-09-15 14:48:15 -04:00
Nick Couchman
5881209f12
GUACAMOLE-221: Move keep-alives to protocol implementation and only send required instruction to owner.
2020-09-15 14:48:15 -04:00
Nick Couchman
5c309f5cb1
GUACAMOLE-221: Move away from reserved function names.
2020-09-15 14:48:15 -04:00
Nick Couchman
7759f9b1c0
GUACAMOLE-221: Add socket keepalive when sending required fields.
2020-09-15 14:48:15 -04:00
Nick Couchman
51b9c9c103
GUACAMOLE-221: Remove manual addition of null terminator
2020-09-15 14:48:15 -04:00
Nick Couchman
4318083511
GUACAMOLE-221: Fix up style, comments, and variable names.
2020-09-15 14:48:15 -04:00
Nick Couchman
939d954810
GUACAMOLE-221: Extract array writing in protocol into common function and document.
2020-09-15 14:48:15 -04:00
Nick Couchman
76ef6332cc
GUACAMOLE-221: Make lock, condition, and flags specific to credentials.
2020-09-15 14:48:15 -04:00