Michael Jumper
e9670df145
GUACAMOLE-249: Correct typo: "updating" should be "update".
2020-01-11 20:19:51 -08:00
Michael Jumper
a3d9a685e8
GUACAMOLE-249: Handle failure to send either response required for monitor ready.
2020-01-11 20:18:27 -08:00
Michael Jumper
f805a80bc1
GUACAMOLE-249: Switch return type of guac_rdp_cache_bitmap() back to void - it doesn't fail, and isn't dictated by the FreeRDP API.
2020-01-11 20:14:35 -08:00
Michael Jumper
62ee36142d
GUACAMOLE-249: Refactor guac_freerdp_channels_load_plugin() to log a warning if plugin limits are reached.
2020-01-09 14:12:08 -08:00
Michael Jumper
b3a713bf7a
GUACAMOLE-249: Clean up basename logic of file downloads. Add unit test.
2020-01-09 13:36:37 -08:00
Michael Jumper
c4f6c5161c
GUACAMOLE-249: Remove accidentally-inserted "0" from end of comment.
2020-01-09 13:11:45 -08:00
Michael Jumper
feb376ea1e
GUACAMOLE-249: Fix misspelled "instruction" and "have" in comments.
2020-01-09 13:10:05 -08:00
Michael Jumper
2139d40e97
GUACAMOLE-249: Remove accidental double spaces from RDP comments.
2020-01-09 13:00:56 -08:00
Michael Jumper
55959b5456
GUACAMOLE-249: Until parameter prompting is available, do not auto-negotiate for NLA if username and password have not been provided.
2020-01-06 13:47:19 -08:00
Michael Jumper
666c4fb299
GUACAMOLE-249: Do not include "extended mode" NLA in security negotiation as negotiation fails (see FreeRDP defaults).
2020-01-06 13:39:59 -08:00
Michael Jumper
67c5bdfdfe
GUACAMOLE-249: Do not attempt to free SVC-specific data if it hasn't actually been allocated.
2020-01-06 13:35:35 -08:00
Michael Jumper
dc8c60f30f
GUACAMOLE-249: freerdp_channels_data() is already the default value of ReceiveChannelData.
2020-01-06 13:22:24 -08:00
Michael Jumper
80988cd6f4
GUACAMOLE-249: Provide SetNull and SetDefault implementations for rdpPointer.
2020-01-06 13:09:51 -08:00
Michael Jumper
1f24c47e29
GUACAMOLE-249: Remove empty struct definitions added by Include What You Use.
2020-01-06 11:40:08 -08:00
Michael Jumper
0677a9ae4d
GUACAMOLE-249: Common surface should still pay attention to dirty flag, regardless of the new special case for unrealized surfaces.
2020-01-06 11:18:10 -08:00
Michael Jumper
a54a12362c
GUACAMOLE-249: Use ReadColor() / WriteColor() around FreeRDPConvertColor().
...
The latter expects color input to be in an intermediate representation
resulting from using ReadColor(), and produces color output which cannot
be used until converted back with WriteColor().
2020-01-06 11:04:44 -08:00
Michael Jumper
e325dbc672
GUACAMOLE-249: Add/remove headers as necessary based on run through Include What You Use (IWYU) tool.
2020-01-04 13:07:28 -08:00
Michael Jumper
9855d875c7
GUACAMOLE-249: Remove handlers for PatBlt and OpaqueRect. FreeRDP will not invoke these if the corresponding OrderSupport element is FALSE, thus they will never be called.
2020-01-04 11:53:11 -08:00
Michael Jumper
2bbc4bfbff
GUACAMOLE-249: Move keyboard-related source back to root of RDP (ease merge). Not truly needed as much as the rest of the restructure.
2020-01-04 11:50:08 -08:00
Michael Jumper
f57382f885
GUACAMOLE-249: Determine FreeRDP pixel format corresponding to local Cairo surfaces based on local platform endianness.
2020-01-04 01:11:12 -08:00
Michael Jumper
555973f6b0
GUACAMOLE-249: Remove unnecessary bitmap conversion - will happen automatically when FreeRDP invokes bitmap->Decompress().
2020-01-04 00:00:21 -08:00
Michael Jumper
902c5e1bd4
GUACAMOLE-249: Alpha component must be in highest-order byte.
2020-01-03 23:42:34 -08:00
Michael Jumper
1bc9384ea8
GUACAMOLE-249: Claim support only for RDP orders that are explicitly supported, independently of any FreeRDP defaults.
2020-01-03 17:29:16 -08:00
Michael Jumper
36f227586e
GUACAMOLE-249: Defer draws to unrealized (server-side) buffers until they are actually needed client-side.
...
Though deferred creation of buffers is already intended, creation was
not actually being deferred in practice as the act of initializing the
buffer with a solid rect of color was causing the buffer to be realized,
even if that initialization process is the only drawing operation that
will ever occur to that buffer.
2020-01-03 16:35:37 -08:00
Michael Jumper
2d4412316f
GUACAMOLE-249: Do not draw background for glyphs when "redundant" (transparent).
2020-01-01 20:33:46 -08:00
Michael Jumper
d7151e0d84
GUACAMOLE-249: Push FreeRDP settings in preconnect hander (OrderSupport is reset otherwise).
...
We set the values within the OrderSupport array to match which RDP
messages we have implemented within guac_rdp_push_settings(). This array
is reset to its default values prior to the preconnect handler being
invoked, thus guac_rdp_push_settings() MUST be invoked within the
preconnect handler for its settings to have the intended effect.
Without proper values within OrderSupport, the initial RDP negotiation
process will claim support for messages that we don't actually support,
resulting in graphical artifacts and unexpected behavior.
2019-12-31 16:23:39 -08:00
Michael Jumper
7ef1dcafba
GUACAMOLE-249: Convert absolutely all rdpBitmaps before attempting to draw.
2019-12-31 16:17:36 -08:00
Michael Jumper
f33416949f
GUACAMOLE-249: RAIL plugin for FreeRDP 2.0.0 requires that the Client Execute PDU be sent manually.
2019-12-30 17:43:39 -08:00
Michael Jumper
8dda26af54
GUACAMOLE-249: Free rdpBitmap and rdpGlyph within custom free handlers (not automatically freed like rdpPointer).
2019-12-30 16:11:13 -08:00
Michael Jumper
0926864ecb
GUACAMOLE-249: Redirect FreeRDP log messages to debug level of guac_client_log().
2019-12-29 18:44:41 -08:00
Michael Jumper
9ad3bc9a49
GUACAMOLE-249: Log RDPDR debug messages at GUAC_LOG_DEBUG level.
2019-12-29 18:12:01 -08:00
Michael Jumper
6940875e6e
GUACAMOLE-249: Refactor away old stream.h and guac_rdp_stream.
2019-12-29 18:04:51 -08:00
Michael Jumper
d2083a1aed
GUACAMOLE-249: Refactor RDPDR to be more documentable. Document RDPDR fully.
2019-12-29 18:04:51 -08:00
Michael Jumper
36545cc92c
GUACAMOLE-249: Document absolutely all parameters and return types for RDP support.
2019-12-29 18:04:51 -08:00
Michael Jumper
a54c61e860
GUACAMOLE-249: Support for OpaqueRect MUST NOT be claimed without supporting PatBlt. OpaqueRect implies PatBlt and vice versa.
2019-12-28 19:36:43 -08:00
Michael Jumper
fbb759ab82
GUACAMOLE-249: Correct mismatched ifndef/define header include check.
2019-12-28 19:36:43 -08:00
Michael Jumper
ab05502494
GUACAMOLE-249: Correct missing/incorrect documentation for RDP callback parameters.
2019-12-28 19:36:43 -08:00
Michael Jumper
12febd5162
GUACAMOLE-249: Remove unused SEC_TO_UNIX_EPOCH constant.
2019-12-27 21:12:39 -08:00
Michael Jumper
6c239a7b98
GUACAMOLE-249: Use filesystem constants defined by FreeRDP and WinPR headers rather than defining our own.
2019-12-27 21:12:18 -08:00
Michael Jumper
598b86a4cf
GUACAMOLE-249: Correct @file annotations within Doxygen comments of renamed headers.
2019-12-27 20:55:06 -08:00
Michael Jumper
69831995cb
GUACAMOLE-249: Remove prototype for guac_rdp_bitmap_decompress(), which is no longer defined nor used.
2019-12-27 15:24:25 -08:00
Michael Jumper
47a1dcc82e
GUACAMOLE-249: Message flags of clipboard data response must be set to CB_RESPONSE_OK for data to be accepted.
2019-12-25 02:04:13 -08:00
Michael Jumper
0c7091198f
GUACAMOLE-249: Use correct start location of clipboard buffer (accidentally used pointer to end).
2019-12-25 02:03:23 -08:00
Michael Jumper
bced87cff9
GUACAMOLE-249: FreeRDP 2.0.0 requires the Clipboard Capabilities PDU to be manually sent.
2019-12-25 01:34:57 -08:00
Michael Jumper
024fc2a1f7
GUACAMOLE-249: Callbacks for "drdynvc" plugin should return CHANNEL_RC_OK, including entry point.
2019-12-23 19:26:49 -08:00
Michael Jumper
4752863b5b
GUACAMOLE-249: Remove now-unnecessary status.h FreeRDP compatibility header.
2019-12-23 13:35:32 -08:00
Michael Jumper
d7bbee35b0
GUACAMOLE-249: Reorganize includes to match code standard.
2019-12-23 13:32:36 -08:00
Michael Jumper
a63dcb46b2
GUACAMOLE-249: Rename and restructure RDP source files more sensibly.
2019-12-23 13:29:37 -08:00
Michael Jumper
827951dcf6
GUACAMOLE-249: Remove RDP constant definitions which are defined within FreeRDP headers.
2019-12-22 21:24:07 -08:00
Michael Jumper
875d51c1ed
GUACAMOLE-249: Dynamically wrap channel entry points (FreeRDP will refuse to associate the same entry point with multiple channels).
2019-12-22 20:34:30 -08:00