GUACAMOLE-249: Correct missing/incorrect documentation for RDP callback parameters.

src/protocols/rdp/channels/cliprdr.h

@@ -87,7 +87,7 @@ guac_rdp_clipboard* guac_rdp_clipboard_alloc(guac_client* client);
  *     The guac_rdp_clipboard instance which has been allocated for the current
  *     RDP connection.
  *
- * @param rdpContext
+ * @param context
  *     The rdpContext associated with the FreeRDP side of the RDP connection.
  */
 void guac_rdp_clipboard_load_plugin(guac_rdp_clipboard* clipboard,

src/protocols/rdp/channels/common-svc.h

@@ -177,7 +177,7 @@ struct guac_rdp_common_svc {
  * This MUST be called within the PreConnect callback of the freerdp instance
  * for static virtual channel support to be loaded.
  *
- * @param rdpContext
+ * @param context
  *     The rdpContext associated with the FreeRDP side of the RDP connection.
  *
  * @param name

src/protocols/rdp/channels/disp.h

@@ -186,9 +186,9 @@ void guac_rdp_disp_reconnect_complete(guac_rdp_disp* disp);
  * Returns whether a full RDP reconnect is required for display update changes
  * to take effect.
  *
- * @param client
- *     The guac_client associated with the Guacamole side of the RDP
- *     connection.
+ * @param disp
+ *     The display update module that should be checked to determine whether a
+ *     reconnect is required.
  *
  * @return
  *     Non-zero if a reconnect is needed, zero otherwise.

src/protocols/rdp/channels/pipe-svc.h

@@ -69,7 +69,7 @@ typedef struct guac_rdp_pipe_svc {
  * This MUST be called within the PreConnect callback of the freerdp instance
  * for static virtual channel support to be loaded.
  *
- * @param rdpContext
+ * @param context
  *     The rdpContext associated with the FreeRDP side of the RDP connection.
  *
  * @param name

src/protocols/rdp/channels/rail.h

@@ -32,7 +32,7 @@
  * This MUST be called within the PreConnect callback of the freerdp instance
  * for RAIL support to be loaded.
  *
- * @param rdpContext
+ * @param context
  *     The rdpContext associated with the FreeRDP side of the RDP connection.
  */
 void guac_rdp_rail_load_plugin(rdpContext* context);

src/protocols/rdp/channels/rdpdr/rdpdr-fs.h

@@ -40,8 +40,8 @@
  * Registers a new filesystem device within the RDPDR plugin. This must be done
  * before RDPDR connection finishes.
  * 
- * @param rdpdr
- *     The RDP device redirection plugin with which to register the device.
+ * @param svc
+ *     The static virtual channel instance being used for RDPDR.
  * 
  * @param drive_name
  *     The name of the redirected drive to display in the RDP connection.

src/protocols/rdp/channels/rdpdr/rdpdr-printer.h

@@ -29,8 +29,8 @@
  * Registers a new printer device within the RDPDR plugin. This must be done
  * before RDPDR connection finishes.
  * 
- * @param rdpdr
- *     The RDP device redirection plugin where the device is registered.
+ * @param svc
+ *     The static virtual channel instance being used for RDPDR.
  * 
  * @param printer_name
  *     The name of the printer that will be registered with the RDP

src/protocols/rdp/channels/rdpdr/rdpdr.h

@@ -146,7 +146,7 @@ void guac_rdpdr_start_download(guac_rdp_common_svc* svc,
  * This MUST be called within the PreConnect callback of the freerdp instance
  * for RDPDR support to be loaded.
  *
- * @param rdpContext
+ * @param context
  *     The rdpContext associated with the FreeRDP side of the RDP connection.
  */
 void guac_rdpdr_load_plugin(rdpContext* context);

src/protocols/rdp/channels/rdpsnd/rdpsnd.h

@@ -113,7 +113,7 @@ typedef struct guac_rdpsnd {
  * This MUST be called within the PreConnect callback of the freerdp instance
  * for RDPSND support to be loaded.
  *
- * @param rdpContext
+ * @param context
  *     The rdpContext associated with the FreeRDP side of the RDP connection.
  */
 void guac_rdpsnd_load_plugin(rdpContext* context);

src/protocols/rdp/glyph.h

@@ -52,6 +52,9 @@ typedef struct guac_rdp_glyph {
  *
  * @param glyph
  *     The glyph to cache.
+ *
+ * @return
+ *     TRUE if successful, FALSE otherwise.
  */
 BOOL guac_rdp_glyph_new(rdpContext* context, const rdpGlyph* glyph);
 
@@ -70,6 +73,26 @@ BOOL guac_rdp_glyph_new(rdpContext* context, const rdpGlyph* glyph);
  *
  * @param y
  *     The destination Y coordinate of the upper-left corner of the glyph.
+ *
+ * @param w
+ *     The width of the glyph being drawn.
+ *
+ * @param h
+ *     The height of the glyph being drawn.
+ *
+ * @param sx
+ *     The X coordinare of the upper-left corner of the glyph within the source
+ *     cache surface containing the glyph.
+ *
+ * @param sy
+ *     The Y coordinare of the upper-left corner of the glyph within the source
+ *     cache surface containing the glyph.
+ *
+ * @param redundant
+ *     Whether the background rectangle specified is redundant (transparent).
+ *
+ * @return
+ *     TRUE if successful, FALSE otherwise.
  */
 BOOL guac_rdp_glyph_draw(rdpContext* context, const rdpGlyph* glyph,
         INT32 x, INT32 y, INT32 w, INT32 h, INT32 sx, INT32 sy,
@@ -121,6 +144,12 @@ void guac_rdp_glyph_free(rdpContext* context, rdpGlyph* glyph);
  *     colorspace of the RDP session, and may even be a palette index, and must
  *     be translated via guac_rdp_convert_color(). If the background is
  *     transparent, this value is undefined.
+ *
+ * @param redundant
+ *     Whether the background rectangle specified is redundant (transparent).
+ *
+ * @return
+ *     TRUE if successful, FALSE otherwise.
  */
 BOOL guac_rdp_glyph_begindraw(rdpContext* context, INT32 x, INT32 y,
         INT32 width, INT32 height, UINT32 fgcolor, UINT32 bgcolor,
@@ -159,6 +188,9 @@ BOOL guac_rdp_glyph_begindraw(rdpContext* context, INT32 x, INT32 y,
  *     colorspace of the RDP session, and may even be a palette index, and must
  *     be translated via guac_rdp_convert_color(). If the background is
  *     transparent, this value is undefined.
+ *
+ * @return
+ *     TRUE if successful, FALSE otherwise.
  */
 BOOL guac_rdp_glyph_enddraw(rdpContext* context, INT32 x, INT32 y,
         INT32 width, INT32 height, UINT32 fgcolor, UINT32 bgcolor);