From c112d1dcf0d942f772d924a6b163194111143760 Mon Sep 17 00:00:00 2001
From: z7zmey <z7zmey@gmail.com>
Date: Thu, 8 Feb 2018 23:31:38 +0200
Subject: [PATCH] If tests

---
 node/stmt/t_if_test.go | 146 +++++++++++++++++++++++++++++++++++++++++
 php5/php5.go           |   2 +-
 php5/php5.y            |   2 +-
 3 files changed, 148 insertions(+), 2 deletions(-)
 create mode 100644 node/stmt/t_if_test.go

diff --git a/node/stmt/t_if_test.go b/node/stmt/t_if_test.go
new file mode 100644
index 0000000..ff7c158
--- /dev/null
+++ b/node/stmt/t_if_test.go
@@ -0,0 +1,146 @@
+package stmt_test
+
+import (
+	"bytes"
+	"testing"
+
+	"github.com/z7zmey/php-parser/node/expr"
+
+	"github.com/z7zmey/php-parser/node"
+	"github.com/z7zmey/php-parser/node/stmt"
+	"github.com/z7zmey/php-parser/php5"
+	"github.com/z7zmey/php-parser/php7"
+)
+
+func TestIf(t *testing.T) {
+	src := `<? if ($a) {}`
+
+	expected := &stmt.StmtList{
+		Stmts: []node.Node{
+			&stmt.If{
+				Cond: &expr.Variable{VarName: &node.Identifier{Value: "$a"}},
+				Stmt: &stmt.StmtList{Stmts: []node.Node{}},
+			},
+		},
+	}
+
+	actual, _, _ := php7.Parse(bytes.NewBufferString(src), "test.php")
+	assertEqual(t, expected, actual)
+
+	actual, _, _ = php5.Parse(bytes.NewBufferString(src), "test.php")
+	assertEqual(t, expected, actual)
+}
+
+func TestElseIf(t *testing.T) {
+	src := `<? if ($a) {} elseif ($b) {}
+	`
+
+	expected := &stmt.StmtList{
+		Stmts: []node.Node{
+			&stmt.If{
+				Cond: &expr.Variable{VarName: &node.Identifier{Value: "$a"}},
+				Stmt: &stmt.StmtList{Stmts: []node.Node{}},
+				ElseIf: []node.Node{
+					&stmt.ElseIf{
+						Cond: &expr.Variable{VarName: &node.Identifier{Value: "$b"}},
+						Stmt: &stmt.StmtList{Stmts: []node.Node{}},
+					},
+				},
+			},
+		},
+	}
+
+	actual, _, _ := php7.Parse(bytes.NewBufferString(src), "test.php")
+	assertEqual(t, expected, actual)
+
+	actual, _, _ = php5.Parse(bytes.NewBufferString(src), "test.php")
+	assertEqual(t, expected, actual)
+}
+
+func TestElse(t *testing.T) {
+	src := `<? if ($a) {} else {}`
+
+	expected := &stmt.StmtList{
+		Stmts: []node.Node{
+			&stmt.If{
+				Cond: &expr.Variable{VarName: &node.Identifier{Value: "$a"}},
+				Stmt: &stmt.StmtList{Stmts: []node.Node{}},
+				Else: &stmt.Else{
+					Stmt: &stmt.StmtList{Stmts: []node.Node{}},
+				},
+			},
+		},
+	}
+
+	actual, _, _ := php7.Parse(bytes.NewBufferString(src), "test.php")
+	assertEqual(t, expected, actual)
+
+	actual, _, _ = php5.Parse(bytes.NewBufferString(src), "test.php")
+	assertEqual(t, expected, actual)
+}
+
+func TestElseElseIf(t *testing.T) {
+	src := `<? if ($a) {} elseif ($b) {} elseif ($c) {} else {}`
+
+	expected := &stmt.StmtList{
+		Stmts: []node.Node{
+			&stmt.If{
+				Cond: &expr.Variable{VarName: &node.Identifier{Value: "$a"}},
+				Stmt: &stmt.StmtList{Stmts: []node.Node{}},
+				ElseIf: []node.Node{
+					&stmt.ElseIf{
+						Cond: &expr.Variable{VarName: &node.Identifier{Value: "$b"}},
+						Stmt: &stmt.StmtList{Stmts: []node.Node{}},
+					},
+					&stmt.ElseIf{
+						Cond: &expr.Variable{VarName: &node.Identifier{Value: "$c"}},
+						Stmt: &stmt.StmtList{Stmts: []node.Node{}},
+					},
+				},
+				Else: &stmt.Else{
+					Stmt: &stmt.StmtList{Stmts: []node.Node{}},
+				},
+			},
+		},
+	}
+
+	actual, _, _ := php7.Parse(bytes.NewBufferString(src), "test.php")
+	assertEqual(t, expected, actual)
+
+	actual, _, _ = php5.Parse(bytes.NewBufferString(src), "test.php")
+	assertEqual(t, expected, actual)
+}
+
+func TestElseIfElseIfElse(t *testing.T) {
+	src := `<? if ($a) {} elseif ($b) {} else if ($c) {} else {}`
+
+	expected := &stmt.StmtList{
+		Stmts: []node.Node{
+			&stmt.If{
+				Cond: &expr.Variable{VarName: &node.Identifier{Value: "$a"}},
+				Stmt: &stmt.StmtList{Stmts: []node.Node{}},
+				ElseIf: []node.Node{
+					&stmt.ElseIf{
+						Cond: &expr.Variable{VarName: &node.Identifier{Value: "$b"}},
+						Stmt: &stmt.StmtList{Stmts: []node.Node{}},
+					},
+				},
+				Else: &stmt.Else{
+					Stmt: &stmt.If{
+						Cond: &expr.Variable{VarName: &node.Identifier{Value: "$c"}},
+						Stmt: &stmt.StmtList{Stmts: []node.Node{}},
+						Else: &stmt.Else{
+							Stmt: &stmt.StmtList{Stmts: []node.Node{}},
+						},
+					},
+				},
+			},
+		},
+	}
+
+	actual, _, _ := php7.Parse(bytes.NewBufferString(src), "test.php")
+	assertEqual(t, expected, actual)
+
+	actual, _, _ = php5.Parse(bytes.NewBufferString(src), "test.php")
+	assertEqual(t, expected, actual)
+}
diff --git a/php5/php5.go b/php5/php5.go
index a07ecb7..3339b50 100644
--- a/php5/php5.go
+++ b/php5/php5.go
@@ -3345,7 +3345,7 @@ yydefault:
 		yyDollar = yyS[yypt-0 : yypt+1]
 		//line php5/php5.y:1121
 		{
-			yyVAL.list = []node.Node{}
+			yyVAL.list = nil
 		}
 	case 132:
 		yyDollar = yyS[yypt-4 : yypt+1]
diff --git a/php5/php5.y b/php5/php5.y
index 07c4e24..405317d 100644
--- a/php5/php5.y
+++ b/php5/php5.y
@@ -1118,7 +1118,7 @@ while_statement:
 
 elseif_list:
         /* empty */
-            { $$ = []node.Node{} }
+            { $$ = nil }
     |   elseif_list T_ELSEIF parenthesis_expr statement
             {
                 _elseIf := stmt.NewElseIf($3, $4)