From 14cfed2e03aff9ba4dc89833ca68d35415eb9657 Mon Sep 17 00:00:00 2001 From: z7zmey Date: Mon, 29 Oct 2018 14:59:57 +0200 Subject: [PATCH] replace meta.OpenCurlyBracesToken from stmt.StmtList --- php5/php5.go | 4 ++-- php5/php5.y | 4 ++-- php7/php7.go | 4 ++-- php7/php7.y | 4 ++-- printer/printer.go | 1 - printer/printer_test.go | 6 +++--- visitor/dumper_test.go | 2 +- visitor/go_dumper_test.go | 4 ++-- visitor/json_dumper_test.go | 2 +- visitor/pretty_json_dumper_test.go | 2 +- 10 files changed, 16 insertions(+), 17 deletions(-) diff --git a/php5/php5.go b/php5/php5.go index 4b63731..ad18833 100644 --- a/php5/php5.go +++ b/php5/php5.go @@ -2976,7 +2976,7 @@ yydefault: yyVAL.node.SetPosition(yylex.(*Parser).positionBuilder.NewTokensPosition(yyDollar[1].token, yyDollar[3].token)) // save comments - yyDollar[1].token.Meta.SetTokenName(meta.OpenCurlyBracesToken).AppendTo(yyVAL.node.GetMeta()) + yyDollar[1].token.Meta.SetTokenName(meta.NodeStart).AppendTo(yyVAL.node.GetMeta()) yyDollar[3].token.Meta.SetTokenName(meta.CloseCurlyBracesToken).AppendTo(yyVAL.node.GetMeta()) yylex.(*Parser).returnTokenToPool(yyDollar, &yyVAL) @@ -5126,7 +5126,7 @@ yydefault: yyVAL.node.SetPosition(yylex.(*Parser).positionBuilder.NewTokensPosition(yyDollar[1].token, yyDollar[3].token)) // save comments - yyDollar[1].token.Meta.SetTokenName(meta.OpenCurlyBracesToken).AppendTo(yyVAL.node.GetMeta()) + yyDollar[1].token.Meta.SetTokenName(meta.NodeStart).AppendTo(yyVAL.node.GetMeta()) yyDollar[3].token.Meta.SetTokenName(meta.CloseCurlyBracesToken).AppendTo(yyVAL.node.GetMeta()) yylex.(*Parser).returnTokenToPool(yyDollar, &yyVAL) diff --git a/php5/php5.y b/php5/php5.y index dfe45ca..e7f7fc4 100644 --- a/php5/php5.y +++ b/php5/php5.y @@ -878,7 +878,7 @@ unticked_statement: $$.SetPosition(yylex.(*Parser).positionBuilder.NewTokensPosition($1, $3)) // save comments - $1.Meta.SetTokenName(meta.OpenCurlyBracesToken).AppendTo($$.GetMeta()) + $1.Meta.SetTokenName(meta.NodeStart).AppendTo($$.GetMeta()) $3.Meta.SetTokenName(meta.CloseCurlyBracesToken).AppendTo($$.GetMeta()) yylex.(*Parser).returnTokenToPool(yyDollar, &yyVAL) @@ -2923,7 +2923,7 @@ method_body: $$.SetPosition(yylex.(*Parser).positionBuilder.NewTokensPosition($1, $3)) // save comments - $1.Meta.SetTokenName(meta.OpenCurlyBracesToken).AppendTo($$.GetMeta()) + $1.Meta.SetTokenName(meta.NodeStart).AppendTo($$.GetMeta()) $3.Meta.SetTokenName(meta.CloseCurlyBracesToken).AppendTo($$.GetMeta()) yylex.(*Parser).returnTokenToPool(yyDollar, &yyVAL) diff --git a/php7/php7.go b/php7/php7.go index f48e8bf..e42385b 100644 --- a/php7/php7.go +++ b/php7/php7.go @@ -3246,7 +3246,7 @@ yydefault: yyVAL.node.SetPosition(yylex.(*Parser).positionBuilder.NewTokensPosition(yyDollar[1].token, yyDollar[3].token)) // save comments - yyDollar[1].token.Meta.SetTokenName(meta.OpenCurlyBracesToken).AppendTo(yyVAL.node.GetMeta()) + yyDollar[1].token.Meta.SetTokenName(meta.NodeStart).AppendTo(yyVAL.node.GetMeta()) yyDollar[3].token.Meta.SetTokenName(meta.CloseCurlyBracesToken).AppendTo(yyVAL.node.GetMeta()) yylex.(*Parser).returnTokenToPool(yyDollar, &yyVAL) @@ -5136,7 +5136,7 @@ yydefault: yyVAL.node.SetPosition(yylex.(*Parser).positionBuilder.NewTokensPosition(yyDollar[1].token, yyDollar[3].token)) // save comments - yyDollar[1].token.Meta.SetTokenName(meta.OpenCurlyBracesToken).AppendTo(yyVAL.node.GetMeta()) + yyDollar[1].token.Meta.SetTokenName(meta.NodeStart).AppendTo(yyVAL.node.GetMeta()) yyDollar[3].token.Meta.SetTokenName(meta.CloseCurlyBracesToken).AppendTo(yyVAL.node.GetMeta()) yylex.(*Parser).returnTokenToPool(yyDollar, &yyVAL) diff --git a/php7/php7.y b/php7/php7.y index 3898fd8..c4227dc 100644 --- a/php7/php7.y +++ b/php7/php7.y @@ -944,7 +944,7 @@ statement: $$.SetPosition(yylex.(*Parser).positionBuilder.NewTokensPosition($1, $3)) // save comments - $1.Meta.SetTokenName(meta.OpenCurlyBracesToken).AppendTo($$.GetMeta()) + $1.Meta.SetTokenName(meta.NodeStart).AppendTo($$.GetMeta()) $3.Meta.SetTokenName(meta.CloseCurlyBracesToken).AppendTo($$.GetMeta()) yylex.(*Parser).returnTokenToPool(yyDollar, &yyVAL) @@ -2727,7 +2727,7 @@ method_body: $$.SetPosition(yylex.(*Parser).positionBuilder.NewTokensPosition($1, $3)) // save comments - $1.Meta.SetTokenName(meta.OpenCurlyBracesToken).AppendTo($$.GetMeta()) + $1.Meta.SetTokenName(meta.NodeStart).AppendTo($$.GetMeta()) $3.Meta.SetTokenName(meta.CloseCurlyBracesToken).AppendTo($$.GetMeta()) yylex.(*Parser).returnTokenToPool(yyDollar, &yyVAL) diff --git a/printer/printer.go b/printer/printer.go index 02b3980..2ea6dfb 100644 --- a/printer/printer.go +++ b/printer/printer.go @@ -2484,7 +2484,6 @@ func (p *Printer) printStmtStmtList(n node.Node) { nn := n.(*stmt.StmtList) p.printMeta(nn, meta.NodeStart) - p.printMeta(nn, meta.OpenCurlyBracesToken) io.WriteString(p.w, "{") p.printNodes(nn.Stmts) p.printMeta(nn, meta.CloseCurlyBracesToken) diff --git a/printer/printer_test.go b/printer/printer_test.go index e20d795..788b665 100644 --- a/printer/printer_test.go +++ b/printer/printer_test.go @@ -5718,7 +5718,7 @@ func TestPrinterPrintStmtClassMethod(t *testing.T) { &meta.Data{ Type: meta.WhiteSpaceType, Value: " ", - TokenName: meta.OpenCurlyBracesToken, + TokenName: meta.NodeStart, }, &meta.Data{ Type: meta.WhiteSpaceType, @@ -7843,7 +7843,7 @@ func TestPrinterPrintStmtList(t *testing.T) { &meta.Data{ Type: meta.WhiteSpaceType, Value: " ", - TokenName: meta.OpenCurlyBracesToken, + TokenName: meta.NodeStart, }, &meta.Data{ Type: meta.WhiteSpaceType, @@ -7892,7 +7892,7 @@ func TestPrinterPrintStmtListNested(t *testing.T) { &meta.Data{ Type: meta.WhiteSpaceType, Value: " ", - TokenName: meta.OpenCurlyBracesToken, + TokenName: meta.NodeStart, }, &meta.Data{ Type: meta.WhiteSpaceType, diff --git a/visitor/dumper_test.go b/visitor/dumper_test.go index 192b6b2..f69b879 100644 --- a/visitor/dumper_test.go +++ b/visitor/dumper_test.go @@ -132,7 +132,7 @@ func ExampleDumper() { // | [*stmt.StmtList] // | "Position": Pos{Line: 6-9 Pos: 96-134} // | "Meta": - // | "\n\t\t\t\t" before "OpenCurlyBracesToken" + // | "\n\t\t\t\t" before "NodeStart" // | "\n\t\t\t\t" before "CloseCurlyBracesToken" // | "Stmts": // | [*stmt.Expression] diff --git a/visitor/go_dumper_test.go b/visitor/go_dumper_test.go index 215dcd8..e06a3a1 100644 --- a/visitor/go_dumper_test.go +++ b/visitor/go_dumper_test.go @@ -215,8 +215,8 @@ func ExampleGoDumper() { // TokenName: meta.FunctionToken, // }, // }, - // ReturnsRef: false, // PhpDocComment: "", + // ReturnsRef: false, // MethodName: &node.Identifier{ // Position: &position.Position{ // StartLine: 5, @@ -400,7 +400,7 @@ func ExampleGoDumper() { // EndPos: 95, // }, // Value: "\n\t\t\t\t", - // TokenName: meta.OpenCurlyBracesToken, + // TokenName: meta.NodeStart, // }, // &meta.Data{ // Type: meta.WhiteSpaceType, diff --git a/visitor/json_dumper_test.go b/visitor/json_dumper_test.go index e9f4037..9d91c7a 100644 --- a/visitor/json_dumper_test.go +++ b/visitor/json_dumper_test.go @@ -37,5 +37,5 @@ func ExampleJsonDumper() { nodes.Walk(dumper) // Output: - // {"type":"*node.Root","position":{"startPos":10,"endPos":166,"startLine":3,"endLine":12},"Stmts":[{"type":"*stmt.Namespace","position":{"startPos":10,"endPos":166,"startLine":3,"endLine":12},"meta":[{"type":"*meta.TokenType","value":"