[WIP]: Add support for links channel.

Dockerfile

@@ -21,32 +21,25 @@
 # Dockerfile for guacamole-server
 #
 
-# The Alpine Linux image that should be used as the basis for the guacd image
-ARG ALPINE_BASE_IMAGE=latest
-FROM alpine:${ALPINE_BASE_IMAGE} AS builder
+# The Ubuntu image that should be used as the basis for the guacd image
+ARG UBUNTU_BASE_IMAGE=21.10
 
-# Install build dependencies
-RUN apk add --no-cache                \
-        autoconf                      \
-        automake                      \
-        build-base                    \
-        cairo-dev                     \
-        cmake                         \
-        git                           \
-        grep                          \
-        libjpeg-turbo-dev             \
-        libpng-dev                    \
-        libtool                       \
-        libwebp-dev                   \
-        make                          \
-        openssl-dev                   \
-        pango-dev                     \
-        pulseaudio-dev                \
-        util-linux-dev
+# Use Debian as base for the build
+FROM ubuntu:${UBUNTU_BASE_IMAGE} AS builder
 
-# Copy source to container for sake of build
-ARG BUILD_DIR=/tmp/guacamole-server
-COPY . ${BUILD_DIR}
+#
+# The Debian repository that should be preferred for dependencies (this will be
+# added to /etc/apt/sources.list if not already present)
+#
+# NOTE: Due to limitations of the Docker image build process, this value is
+# duplicated in an ARG in the second stage of the build.
+#
+ARG UBUNTU_RELEASE=impish-backports
+
+# Add repository for specified Ubuntu release if not already present in
+# sources.list
+RUN grep " ${UBUNTU_RELEASE} " /etc/apt/sources.list || echo >> /etc/apt/sources.list \
+    "deb http://archive.ubuntu.com/ubuntu/ ${UBUNTU_RELEASE} main contrib non-free"
 
 #
 # Base directory for installed build artifacts.
@@ -54,99 +47,70 @@ COPY . ${BUILD_DIR}
 # NOTE: Due to limitations of the Docker image build process, this value is
 # duplicated in an ARG in the second stage of the build.
 #
-ARG PREFIX_DIR=/opt/guacamole
+ARG PREFIX_DIR=/usr/local/guacamole
 
-#
-# Automatically select the latest versions of each core protocol support
-# library (these can be overridden at build time if a specific version is
-# needed)
-#
-ARG WITH_FREERDP='2(\.\d+)+'
-ARG WITH_LIBSSH2='libssh2-\d+(\.\d+)+'
-ARG WITH_LIBTELNET='\d+(\.\d+)+'
-ARG WITH_LIBVNCCLIENT='LibVNCServer-\d+(\.\d+)+'
-ARG WITH_LIBWEBSOCKETS='v\d+(\.\d+)+'
+# Build arguments
+ARG BUILD_DIR=/tmp/guacd-docker-BUILD
+ARG BUILD_DEPENDENCIES="              \
+        autoconf                      \
+        automake                      \
+        freerdp2-dev                  \
+        gcc                           \
+        libcairo2-dev                 \
+        libgcrypt-dev                 \
+        libjpeg-turbo8-dev            \
+        libossp-uuid-dev              \
+        libpango1.0-dev               \
+        libpulse-dev                  \
+        libssh2-1-dev                 \
+        libssl-dev                    \
+        libtelnet-dev                 \
+        libtool                       \
+        libvncserver-dev              \
+        libwebsockets-dev             \
+        libwebp-dev                   \
+        make"
 
-#
-# Default build options for each core protocol support library, as well as
-# guacamole-server itself (these can be overridden at build time if different
-# options are needed)
-#
+# Do not require interaction during build
+ARG DEBIAN_FRONTEND=noninteractive
 
-ARG FREERDP_OPTS="\
-    -DBUILTIN_CHANNELS=OFF \
-    -DCHANNEL_URBDRC=OFF \
-    -DWITH_ALSA=OFF \
-    -DWITH_CAIRO=ON \
-    -DWITH_CHANNELS=ON \
-    -DWITH_CLIENT=ON \
-    -DWITH_CUPS=OFF \
-    -DWITH_DIRECTFB=OFF \
-    -DWITH_FFMPEG=OFF \
-    -DWITH_GSM=OFF \
-    -DWITH_GSSAPI=OFF \
-    -DWITH_IPP=OFF \
-    -DWITH_JPEG=ON \
-    -DWITH_LIBSYSTEMD=OFF \
-    -DWITH_MANPAGES=OFF \
-    -DWITH_OPENH264=OFF \
-    -DWITH_OPENSSL=ON \
-    -DWITH_OSS=OFF \
-    -DWITH_PCSC=OFF \
-    -DWITH_PULSE=OFF \
-    -DWITH_SERVER=OFF \
-    -DWITH_SERVER_INTERFACE=OFF \
-    -DWITH_SHADOW_MAC=OFF \
-    -DWITH_SHADOW_X11=OFF \
-    -DWITH_SSE2=ON \
-    -DWITH_WAYLAND=OFF \
-    -DWITH_X11=OFF \
-    -DWITH_X264=OFF \
-    -DWITH_XCURSOR=ON \
-    -DWITH_XEXT=ON \
-    -DWITH_XI=OFF \
-    -DWITH_XINERAMA=OFF \
-    -DWITH_XKBFILE=ON \
-    -DWITH_XRENDER=OFF \
-    -DWITH_XTEST=OFF \
-    -DWITH_XV=OFF \
-    -DWITH_ZLIB=ON"
+# Bring build environment up to date and install build dependencies
+RUN apt-get update                                              && \
+    apt-get install -t ${UBUNTU_RELEASE} -y $BUILD_DEPENDENCIES && \
+    rm -rf /var/lib/apt/lists/*
 
-ARG GUACAMOLE_SERVER_OPTS="\
-    --disable-guaclog"
+# Add configuration scripts
+COPY src/guacd-docker/bin "${PREFIX_DIR}/bin/"
 
-ARG LIBSSH2_OPTS="\
-    -DBUILD_EXAMPLES=OFF \
-    -DBUILD_SHARED_LIBS=ON"
+# Copy source to container for sake of build
+COPY . "$BUILD_DIR"
 
-ARG LIBTELNET_OPTS="\
-    --disable-static \
-    --disable-util"
-
-ARG LIBVNCCLIENT_OPTS=""
-
-ARG LIBWEBSOCKETS_OPTS="\
-    -DDISABLE_WERROR=ON \
-    -DLWS_WITHOUT_SERVER=ON \
-    -DLWS_WITHOUT_TESTAPPS=ON \
-    -DLWS_WITHOUT_TEST_CLIENT=ON \
-    -DLWS_WITHOUT_TEST_PING=ON \
-    -DLWS_WITHOUT_TEST_SERVER=ON \
-    -DLWS_WITHOUT_TEST_SERVER_EXTPOLL=ON \
-    -DLWS_WITH_STATIC=OFF"
-
-# Build guacamole-server and its core protocol library dependencies
-RUN ${BUILD_DIR}/src/guacd-docker/bin/build-all.sh
+# Build guacamole-server from local source
+RUN ${PREFIX_DIR}/bin/build-guacd.sh "$BUILD_DIR" "$PREFIX_DIR"
 
 # Record the packages of all runtime library dependencies
-RUN ${BUILD_DIR}/src/guacd-docker/bin/list-dependencies.sh \
+RUN ${PREFIX_DIR}/bin/list-dependencies.sh     \
         ${PREFIX_DIR}/sbin/guacd               \
         ${PREFIX_DIR}/lib/libguac-client-*.so  \
         ${PREFIX_DIR}/lib/freerdp2/*guac*.so   \
         > ${PREFIX_DIR}/DEPENDENCIES
 
-# Use same Alpine version as the base for the runtime image
-FROM alpine:${ALPINE_BASE_IMAGE}
+# Use same Debian as the base for the runtime image
+FROM ubuntu:${UBUNTU_BASE_IMAGE}
+
+#
+# The Debian repository that should be preferred for dependencies (this will be
+# added to /etc/apt/sources.list if not already present)
+#
+# NOTE: Due to limitations of the Docker image build process, this value is
+# duplicated in an ARG in the first stage of the build.
+#
+ARG UBUNTU_RELEASE=impish-backports
+
+# Add repository for specified Ubuntu release if not already present in
+# sources.list
+RUN grep " ${UBUNTU_RELEASE} " /etc/apt/sources.list || echo >> /etc/apt/sources.list \
+    "deb http://archive.ubuntu.com/ubuntu/ ${UBUNTU_RELEASE} main contrib non-free"
 
 #
 # Base directory for installed build artifacts. See also the
@@ -155,27 +119,36 @@ FROM alpine:${ALPINE_BASE_IMAGE}
 # NOTE: Due to limitations of the Docker image build process, this value is
 # duplicated in an ARG in the first stage of the build.
 #
-ARG PREFIX_DIR=/opt/guacamole
+ARG PREFIX_DIR=/usr/local/guacamole
 
 # Runtime environment
 ENV LC_ALL=C.UTF-8
 ENV LD_LIBRARY_PATH=${PREFIX_DIR}/lib
 ENV GUACD_LOG_LEVEL=info
 
+ARG RUNTIME_DEPENDENCIES="            \
+        netcat-openbsd                \
+        ca-certificates               \
+        ghostscript                   \
+        fonts-liberation              \
+        fonts-dejavu                  \
+        xfonts-terminus"
+
+# Do not require interaction during build
+ARG DEBIAN_FRONTEND=noninteractive
+
 # Copy build artifacts into this stage
 COPY --from=builder ${PREFIX_DIR} ${PREFIX_DIR}
 
 # Bring runtime environment up to date and install runtime dependencies
-RUN apk add --no-cache                \
-        ca-certificates               \
-        ghostscript                   \
-        netcat-openbsd                \
-        shadow                        \
-        terminus-font                 \
-        ttf-dejavu                    \
-        ttf-liberation                \
-        util-linux-login && \
-    xargs apk add --no-cache < ${PREFIX_DIR}/DEPENDENCIES
+RUN apt-get update                                                                                       && \
+    apt-get install -t ${UBUNTU_RELEASE} -y --no-install-recommends $RUNTIME_DEPENDENCIES                && \
+    apt-get install -t ${UBUNTU_RELEASE} -y --no-install-recommends $(cat "${PREFIX_DIR}"/DEPENDENCIES)  && \
+    rm -rf /var/lib/apt/lists/*
+
+# Link FreeRDP plugins into proper path
+RUN ${PREFIX_DIR}/bin/link-freerdp-plugins.sh \
+        ${PREFIX_DIR}/lib/freerdp2/libguac*.so
 
 # Checks the operating status every 5 minutes with a timeout of 5 seconds
 HEALTHCHECK --interval=5m --timeout=5s CMD nc -z 127.0.0.1 4822 || exit 1
@@ -184,7 +157,7 @@ HEALTHCHECK --interval=5m --timeout=5s CMD nc -z 127.0.0.1 4822 || exit 1
 ARG UID=1000
 ARG GID=1000
 RUN groupadd --gid $GID guacd
-RUN useradd --system --create-home --shell /sbin/nologin --uid $UID --gid $GID guacd
+RUN useradd --system --create-home --shell /usr/sbin/nologin --uid $UID --gid $GID guacd
 
 # Run with user guacd
 USER guacd
@@ -197,5 +170,5 @@ EXPOSE 4822
 # Note the path here MUST correspond to the value specified in the 
 # PREFIX_DIR build argument.
 #
-CMD /opt/guacamole/sbin/guacd -b 0.0.0.0 -L $GUACD_LOG_LEVEL -f
+CMD /usr/local/guacamole/sbin/guacd -b 0.0.0.0 -L $GUACD_LOG_LEVEL -f
 

bin/guacctl

@@ -117,7 +117,7 @@ error() {
 ##
 usage() {
     cat >&2 <<END
-guacctl 1.5.0, Apache Guacamole terminal session control utility.
+guacctl 1.4.0, Apache Guacamole terminal session control utility.
 Usage: guacctl [OPTION] [FILE or NAME]...
 
     -d, --download         download each of the files listed.

configure.ac

@@ -18,7 +18,7 @@
 #
 
 AC_PREREQ([2.61])
-AC_INIT([guacamole-server], [1.5.0])
+AC_INIT([guacamole-server], [1.4.0])
 AC_CONFIG_AUX_DIR([build-aux])
 AM_INIT_AUTOMAKE([-Wall -Werror foreign subdir-objects])
 AM_SILENT_RULES([yes])

src/common-ssh/ssh.c

@@ -22,7 +22,6 @@
 #include "common-ssh/user.h"
 
 #include <guacamole/client.h>
-#include <guacamole/fips.h>
 #include <libssh2.h>
 
 #ifdef LIBSSH2_USES_GCRYPT
@@ -47,20 +46,6 @@
 GCRY_THREAD_OPTION_PTHREAD_IMPL;
 #endif
 
-/**
- * A list of all key exchange algorithms that are both FIPS-compliant, and
- * OpenSSL-supported. Note that "ext-info-c" is also included. While not a key
- * exchange algorithm per se, it must be in the list to ensure that the server
- * will send a SSH_MSG_EXT_INFO response, which is required to perform RSA key
- * upgrades.
- */
-#define FIPS_COMPLIANT_KEX_ALGORITHMS "diffie-hellman-group-exchange-sha256,ext-info-c"
-
-/**
- * A list of ciphers that are both FIPS-compliant, and OpenSSL-supported.
- */
-#define FIPS_COMPLIANT_CIPHERS "aes128-ctr,aes192-ctr,aes256-ctr,aes128-cbc,aes192-cbc,aes256-cbc"
-
 #ifdef OPENSSL_REQUIRES_THREADING_CALLBACKS
 /**
  * Array of mutexes, used by OpenSSL.
@@ -180,11 +165,9 @@ int guac_common_ssh_init(guac_client* client) {
     CRYPTO_set_locking_callback(guac_common_ssh_openssl_locking_callback);
 #endif
 
-#if OPENSSL_VERSION_NUMBER < 0x10100000L
-    /* Init OpenSSL - only required for OpenSSL Versions < 1.1.0 */
+    /* Init OpenSSL */
     SSL_library_init();
     ERR_load_crypto_strings();
-#endif
 
     /* Init libssh2 */
     libssh2_init(0);
@@ -501,17 +484,6 @@ guac_common_ssh_session* guac_common_ssh_create_session(guac_client* client,
         return NULL;
     }
 
-    /*
-     * If FIPS mode is enabled, prefer only FIPS-compatible algorithms and
-     * ciphers that are also supported by libssh2. For more info, see:
-     * https://csrc.nist.gov/CSRC/media/projects/cryptographic-module-validation-program/documents/security-policies/140sp2906.pdf
-     */
-    if (guac_fips_enabled()) {
-        libssh2_session_method_pref(session, LIBSSH2_METHOD_KEX, FIPS_COMPLIANT_KEX_ALGORITHMS);
-        libssh2_session_method_pref(session, LIBSSH2_METHOD_CRYPT_CS, FIPS_COMPLIANT_CIPHERS);
-        libssh2_session_method_pref(session, LIBSSH2_METHOD_CRYPT_SC, FIPS_COMPLIANT_CIPHERS);
-    }
-
     /* Perform handshake */
     if (libssh2_session_handshake(session, fd)) {
         guac_client_abort(client, GUAC_PROTOCOL_STATUS_UPSTREAM_ERROR,

src/common/display.c

@@ -166,8 +166,6 @@ void guac_common_display_free(guac_common_display* display) {
 void guac_common_display_dup(guac_common_display* display, guac_user* user,
         guac_socket* socket) {
 
-    guac_client* client = user->client;
-
     pthread_mutex_lock(&display->_lock);
 
     /* Sunchronize shared cursor */
@@ -180,9 +178,6 @@ void guac_common_display_dup(guac_common_display* display, guac_user* user,
     guac_common_display_dup_layers(display->layers, user, socket);
     guac_common_display_dup_layers(display->buffers, user, socket);
 
-    /* Sends a sync instruction to mark the boundary of the first frame */
-    guac_protocol_send_sync(socket, client->last_sent_timestamp, 1);
-
     pthread_mutex_unlock(&display->_lock);
 
 }
@@ -389,3 +384,4 @@ void guac_common_display_free_buffer(guac_common_display* display,
     pthread_mutex_unlock(&display->_lock);
 
 }
+

src/guacd-docker/bin/build-all.sh

@@ -1,115 +0,0 @@
-#!/bin/sh -e
-#
-# Licensed to the Apache Software Foundation (ASF) under one
-# or more contributor license agreements.  See the NOTICE file
-# distributed with this work for additional information
-# regarding copyright ownership.  The ASF licenses this file
-# to you under the Apache License, Version 2.0 (the
-# "License"); you may not use this file except in compliance
-# with the License.  You may obtain a copy of the License at
-#
-#   http://www.apache.org/licenses/LICENSE-2.0
-#
-# Unless required by applicable law or agreed to in writing,
-# software distributed under the License is distributed on an
-# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
-# KIND, either express or implied.  See the License for the
-# specific language governing permissions and limitations
-# under the License.
-#
-
-##
-## @fn build-all.sh
-##
-## Builds the source of guacamole-server and its various core protocol library
-## dependencies.
-##
-
-# Pre-populate build control variables such that the custom build prefix is
-# used for C headers, locating libraries, etc.
-export CFLAGS="-I${PREFIX_DIR}/include"
-export LDFLAGS="-L${PREFIX_DIR}/lib"
-export PKG_CONFIG_PATH="${PREFIX_DIR}/lib/pkgconfig" 
-
-# Ensure thread stack size will be 8 MB (glibc's default on Linux) rather than
-# 128 KB (musl's default)
-export LDFLAGS="$LDFLAGS -Wl,-z,stack-size=8388608"
-
-##
-## Builds and installs the source at the given git repository, automatically
-## switching to the version of the source at the tag/commit that matches the
-## given pattern.
-##
-## @param URL
-##     The URL of the git repository that the source should be downloaded from.
-##
-## @param PATTERN
-##     The Perl-compatible regular expression that the tag must match. If no
-##     tag matches the regular expression, the pattern is assumed to be an
-##     exact reference to a commit, branch, etc. acceptable by git checkout.
-##
-## @param ...
-##     Any additional command-line options that should be provided to CMake or
-##     the configure script.
-##
-install_from_git() {
-
-    URL="$1"
-    PATTERN="$2"
-    shift 2
-
-    # Calculate top-level directory name of resulting repository from the
-    # provided URL
-    REPO_DIR="$(basename "$URL" .git)"
-
-    # Allow dependencies to be manually omitted with the tag/commit pattern "NO"
-    if [ "$PATTERN" = "NO" ]; then
-        echo "NOT building $REPO_DIR (explicitly skipped)"
-        return
-    fi
-
-    # Clone repository and change to top-level directory of source
-    cd /tmp
-    git clone "$URL"
-    cd $REPO_DIR/
-
-    # Locate tag/commit based on provided pattern
-    VERSION="$(git tag -l --sort=-v:refname | grep -Px -m1 "$PATTERN" \
-        || echo "$PATTERN")"
-
-    # Switch to desired version of source
-    echo "Building $REPO_DIR @ $VERSION ..."
-    git -c advice.detachedHead=false checkout "$VERSION"
-
-    # Configure build using CMake or GNU Autotools, whichever happens to be
-    # used by the library being built
-    if [ -e CMakeLists.txt ]; then
-        cmake -DCMAKE_INSTALL_PREFIX:PATH="$PREFIX_DIR" "$@" .
-    else
-        [ -e configure ] || autoreconf -fi
-        ./configure --prefix="$PREFIX_DIR" "$@"
-    fi
-
-    # Build and install
-    make && make install
-
-}
-
-#
-# Build and install core protocol library dependencies
-#
-
-install_from_git "https://github.com/FreeRDP/FreeRDP" "$WITH_FREERDP" $FREERDP_OPTS
-install_from_git "https://github.com/libssh2/libssh2" "$WITH_LIBSSH2" $LIBSSH2_OPTS
-install_from_git "https://github.com/seanmiddleditch/libtelnet" "$WITH_LIBTELNET" $LIBTELNET_OPTS
-install_from_git "https://github.com/LibVNC/libvncserver" "$WITH_LIBVNCCLIENT" $LIBVNCCLIENT_OPTS
-install_from_git "https://libwebsockets.org/repo/libwebsockets" "$WITH_LIBWEBSOCKETS" $LIBWEBSOCKETS_OPTS
-
-#
-# Build guacamole-server
-#
-
-cd "$BUILD_DIR"
-autoreconf -fi && ./configure --prefix="$PREFIX_DIR" $GUACAMOLE_SERVER_OPTS
-make && make install
-

src/guacd-docker/bin/build-guacd.sh

@@ -0,0 +1,49 @@
+#!/bin/sh -e
+#
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
+#
+#   http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied.  See the License for the
+# specific language governing permissions and limitations
+# under the License.
+#
+
+##
+## @fn build-guacd.sh
+##
+## Builds the source of guacamole-server, automatically creating any required
+## symbolic links for the proper loading of FreeRDP plugins.
+##
+## @param BUILD_DIR
+##     The directory which currently contains the guacamole-server source and
+##     in which the build should be performed.
+##
+## @param PREFIX_DIR
+##     The directory prefix into which the build artifacts should be installed 
+##     in which the build should be performed. This is passed to the --prefix
+##     option of `configure`.
+##
+
+BUILD_DIR="$1"
+PREFIX_DIR="$2"
+
+#
+# Build guacamole-server
+#
+
+cd "$BUILD_DIR"
+autoreconf -fi
+./configure --prefix="$PREFIX_DIR" --disable-guaclog --with-freerdp-plugin-dir="$PREFIX_DIR/lib/freerdp2"
+make
+make install
+ldconfig

src/guacd-docker/bin/link-freerdp-plugins.sh

@@ -0,0 +1,76 @@
+#!/bin/sh -e
+#
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
+#
+#   http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied.  See the License for the
+# specific language governing permissions and limitations
+# under the License.
+#
+
+##
+## @fn link-freerdp-plugins.sh
+##
+## Automatically creates any required symbolic links for the proper loading of
+## the given FreeRDP plugins. If a given plugin is already in the correct
+## directory, no link is created for that plugin.
+##
+## @param ...
+##     The FreeRDP plugins to add links for.
+##
+
+##
+## Locates the base directory of the FreeRDP installation (where the FreeRDP library
+## .so files are located), printing the result to STDOUT. If the directory cannot be
+## determined, an error is printed.
+##
+where_is_freerdp() {
+
+    # Determine the location of any freerdp2 .so files
+    PATHS="$(find / -iname '*libfreerdp2.so.*' \
+             | xargs -r dirname                \
+             | xargs -r realpath               \
+             | sort -u)"
+
+    # Verify that exactly one location was found
+    if [ -z "$PATHS" -o "$(echo "$PATHS" | wc -l)" != 1 ]; then
+        echo "$1: Unable to locate FreeRDP install location." >&2
+        return 1
+    fi
+
+    echo "$PATHS"
+
+}
+
+#
+# Create symbolic links as necessary to include all given plugins within the
+# search path of FreeRDP
+#
+
+# Determine correct install location for FreeRDP plugins
+FREERDP_DIR="$(where_is_freerdp)"
+FREERDP_PLUGIN_DIR="${FREERDP_DIR}/freerdp2"
+
+while [ -n "$1" ]; do
+
+    # Add symbolic link if necessary
+    if [ ! -e "$FREERDP_PLUGIN_DIR/$(basename "$1")" ]; then
+        mkdir -p "$FREERDP_PLUGIN_DIR"
+        ln -s "$1" "$FREERDP_PLUGIN_DIR"
+    else
+        echo "$1: Already in correct directory." >&2
+    fi
+
+    shift
+
+done

src/guacd-docker/bin/list-dependencies.sh

@@ -21,7 +21,7 @@
 ##
 ## @fn list-dependencies.sh
 ##
-## Lists the Alpine Linux package names for all library dependencies of the
+## Lists the Debian/Ubuntu package names for all library dependencies of the
 ## given binaries. Each package is only listed once, even if multiple binaries
 ## provided by the same package are given.
 ##
@@ -35,17 +35,19 @@ while [ -n "$1" ]; do
     ldd "$1" | grep -v 'libguac' | awk '/=>/{print $(NF-1)}' \
         | while read LIBRARY; do
 
-        # List the package providing that library, if any
-        apk info -W "$LIBRARY" 2> /dev/null \
-            | grep 'is owned by' | grep -o '[^ ]*$' || true
+        # In some cases, the library that's linked against is a hard link
+        # to the file that's managed by the package, which dpkg doesn't understand.
+        # Searching by */basename ensures the package will be found in these cases.
+        LIBRARY_BASENAME=$(basename "$LIBRARY")
+
+        # Determine the Debian package which is associated with that
+        # library, if any
+        dpkg-query -S "*/$LIBRARY_BASENAME" || true
 
     done
 
     # Next binary
     shift
 
-# Strip the "-VERSION" suffix from each package name, listing each resulting
-# package uniquely ("apk add" cannot handle package names that include the
-# version number)
-done | sed 's/\(.*\)-[0-9]\+\..*$/\1/' | sort -u
+done | cut -f1 -d: | sort -u
 

src/guacd/daemon.c

@@ -381,15 +381,10 @@ int main(int argc, char* argv[]) {
         CRYPTO_set_locking_callback(guacd_openssl_locking_callback);
 #endif
 
-#if OPENSSL_VERSION_NUMBER < 0x10100000L
-        /* Init OpenSSL for OpenSSL Versions < 1.1.0 */
+        /* Init SSL */
         SSL_library_init();
         SSL_load_error_strings();
         ssl_context = SSL_CTX_new(SSLv23_server_method());
-#else
-        /* Set up OpenSSL for OpenSSL Versions >= 1.1.0 */
-        ssl_context = SSL_CTX_new(TLS_server_method());
-#endif
 
         /* Load key */
         if (config->key_file != NULL) {

src/guacenc/ffmpeg-compat.c

@@ -213,7 +213,7 @@ int guacenc_avcodec_encode_video(guacenc_video* video, AVFrame* frame) {
 #endif
 }
 
-AVCodecContext* guacenc_build_avcodeccontext(AVStream* stream, const AVCodec* codec,
+AVCodecContext* guacenc_build_avcodeccontext(AVStream* stream, AVCodec* codec, 
         int bitrate, int width, int height, int gop_size, int qmax, int qmin,
         int pix_fmt, AVRational time_base) {
 
@@ -249,7 +249,7 @@ AVCodecContext* guacenc_build_avcodeccontext(AVStream* stream, const AVCodec* co
 }
 
 int guacenc_open_avcodec(AVCodecContext *avcodec_context,
-        const AVCodec *codec, AVDictionary **options,
+        AVCodec *codec, AVDictionary **options,
         AVStream* stream) {
 
     int ret = avcodec_open2(avcodec_context, codec, options);

src/guacenc/ffmpeg-compat.h

@@ -128,7 +128,7 @@ int guacenc_avcodec_encode_video(guacenc_video* video, AVFrame* frame);
  *     The pointer to the configured AVCodecContext.
  *
  */
-AVCodecContext* guacenc_build_avcodeccontext(AVStream* stream, const AVCodec* codec,
+AVCodecContext* guacenc_build_avcodeccontext(AVStream* stream, AVCodec* codec,
         int bitrate, int width, int height, int gop_size, int qmax, int qmin,
         int pix_fmt, AVRational time_base);
 
@@ -158,7 +158,7 @@ AVCodecContext* guacenc_build_avcodeccontext(AVStream* stream, const AVCodec* co
  *     Zero on success, a negative value on error.
  */
 int guacenc_open_avcodec(AVCodecContext *avcodec_context,
-        const AVCodec *codec, AVDictionary **options,
+        AVCodec *codec, AVDictionary **options,
         AVStream* stream);
 
 #endif

src/guacenc/video.c

@@ -47,7 +47,7 @@
 guacenc_video* guacenc_video_alloc(const char* path, const char* codec_name,
         int width, int height, int bitrate) {
 
-    const AVOutputFormat *container_format;
+    AVOutputFormat *container_format;
     AVFormatContext *container_format_context;
     AVStream *video_stream;
     int ret;
@@ -63,7 +63,7 @@ guacenc_video* guacenc_video_alloc(const char* path, const char* codec_name,
     container_format = container_format_context->oformat;
 
     /* Pull codec based on name */
-    const AVCodec* codec = avcodec_find_encoder_by_name(codec_name);
+    AVCodec* codec = avcodec_find_encoder_by_name(codec_name);
     if (codec == NULL) {
         guacenc_log(GUAC_LOG_ERROR, "Failed to locate codec \"%s\".",
                 codec_name);

src/libguac/Makefile.am

@@ -44,7 +44,6 @@ libguacinc_HEADERS =                  \
     guacamole/client-types.h          \
     guacamole/error.h                 \
     guacamole/error-types.h           \
-    guacamole/fips.h                  \
     guacamole/hash.h                  \
     guacamole/layer.h                 \
     guacamole/layer-types.h           \
@@ -94,7 +93,6 @@ libguac_la_SOURCES =   \
     encode-jpeg.c      \
     encode-png.c       \
     error.c            \
-    fips.c             \
     hash.c             \
     id.c               \
     palette.c          \
@@ -139,7 +137,7 @@ libguac_la_CFLAGS = \
     -Werror -Wall -pedantic
 
 libguac_la_LDFLAGS =     \
-    -version-info 21:0:0 \
+    -version-info 20:0:0 \
     -no-undefined        \
     @CAIRO_LIBS@         \
     @DL_LIBS@            \

src/libguac/client.c

@@ -307,10 +307,6 @@ int guac_client_add_user(guac_client* client, guac_user* user, int argc, char**
 
     pthread_rwlock_unlock(&(client->__users_lock));
 
-    /* Notify owner of user joining connection. */
-    if (retval == 0 && !user->owner)
-        guac_client_owner_notify_join(client, user);
-
     return retval;
 
 }
@@ -337,10 +333,6 @@ void guac_client_remove_user(guac_client* client, guac_user* user) {
 
     pthread_rwlock_unlock(&(client->__users_lock));
 
-    /* Update owner of user having left the connection. */
-    if (!user->owner)
-        guac_client_owner_notify_leave(client, user);
-
     /* Call handler, if defined */
     if (user->leave_handler)
         user->leave_handler(user);
@@ -421,19 +413,15 @@ void* guac_client_for_user(guac_client* client, guac_user* user,
 }
 
 int guac_client_end_frame(guac_client* client) {
-    return guac_client_end_multiple_frames(client, 0);
-}
-
-int guac_client_end_multiple_frames(guac_client* client, int frames) {
 
     /* Update and send timestamp */
     client->last_sent_timestamp = guac_timestamp_current();
 
     /* Log received timestamp and calculated lag (at TRACE level only) */
     guac_client_log(client, GUAC_LOG_TRACE, "Server completed "
-            "frame %" PRIu64 "ms (%i logical frames)", client->last_sent_timestamp, frames);
+            "frame %" PRIu64 "ms.", client->last_sent_timestamp);
 
-    return guac_protocol_send_sync(client->socket, client->last_sent_timestamp, frames);
+    return guac_protocol_send_sync(client->socket, client->last_sent_timestamp);
 
 }
 
@@ -683,36 +671,6 @@ static void* __webp_support_callback(guac_user* user, void* data) {
 }
 #endif
 
-/**
- * A callback function which is invoked by guac_client_owner_supports_msg()
- * to determine if the owner of a client supports the "msg" instruction,
- * returning zero if the user does not support the instruction or non-zero if
- * the user supports it.
- * 
- * @param user
- *     The guac_user that will be checked for "msg" instruction support.
- * 
- * @param data
- *     Data provided to the callback. This value is never used within this
- *     callback.
- * 
- * @return
- *     A non-zero integer if the provided user who owns the connection supports
- *     the "msg" instruction, or zero if the user does not. The integer is cast
- *     as a void*.
- */
-static void* guac_owner_supports_msg_callback(guac_user* user, void* data) {
-
-    return (void*) ((intptr_t) guac_user_supports_msg(user));
-
-}
-
-int guac_client_owner_supports_msg(guac_client* client) {
-
-    return (int) ((intptr_t) guac_client_for_owner(client, guac_owner_supports_msg_callback, NULL));
-
-}
-
 /**
  * A callback function which is invoked by guac_client_owner_supports_required()
  * to determine if the owner of a client supports the "required" instruction,
@@ -743,124 +701,6 @@ int guac_client_owner_supports_required(guac_client* client) {
     
 }
 
-/**
- * A callback function that is invokved by guac_client_owner_notify_join() to
- * notify the owner of a connection that another user has joined the
- * connection, returning zero if the message is sent successfully, or non-zero
- * if an error occurs.
- *
- * @param user
- *     The user to send the notification to, which will be the owner of the
- *     connection.
- *
- * @param data
- *     The data provided to the callback, which is the user that is joining the
- *     connection.
- *
- * @return
- *     Zero if the message is sent successfully to the owner, otherwise
- *     non-zero, cast as a void*.
- */
-static void* guac_client_owner_notify_join_callback(guac_user* user, void* data) {
-
-    const guac_user* joiner = (const guac_user *) data;
-
-    if (user == NULL)
-        return (void*) ((intptr_t) -1);
-
-    char* log_owner = "owner";
-    if (user->info.name != NULL)
-        log_owner = (char *) user->info.name;
-
-    char* log_joiner = "anonymous";
-    char* send_joiner = "";
-    if (joiner->info.name != NULL) {
-        log_joiner = (char *) joiner->info.name;
-        send_joiner = (char *) joiner->info.name;
-    }
-
-    guac_user_log(user, GUAC_LOG_DEBUG, "Notifying owner \"%s\" of \"%s\" joining.",
-            log_owner, log_joiner);
-    
-    /* Send user joined notification to owner. */
-    const char* args[] = { (const char*)joiner->user_id, (const char*)send_joiner, NULL };
-    return (void*) ((intptr_t) guac_protocol_send_msg(user->socket, GUAC_MESSAGE_USER_JOINED, args));
-
-}
-
-int guac_client_owner_notify_join(guac_client* client, guac_user* joiner) {
-
-    /* Don't send msg instruction if client does not support it. */
-    if (!guac_client_owner_supports_msg(client)) {
-        guac_client_log(client, GUAC_LOG_DEBUG,
-                        "Client does not support the \"msg\" instruction and "
-                        "will not be notified of the user joining the connection.");
-        return -1;
-    }
-
-    return (int) ((intptr_t) guac_client_for_owner(client, guac_client_owner_notify_join_callback, joiner));
-
-}
-
-/**
- * A callback function that is invokved by guac_client_owner_notify_leave() to
- * notify the owner of a connection that another user has left the connection,
- * returning zero if the message is sent successfully, or non-zero
- * if an error occurs.
- *
- * @param user
- *     The user to send the notification to, which will be the owner of the
- *     connection.
- *
- * @param data
- *     The data provided to the callback, which is the user that is leaving the
- *     connection.
- *
- * @return
- *     Zero if the message is sent successfully to the owner, otherwise
- *     non-zero, cast as a void*.
- */
-static void* guac_client_owner_notify_leave_callback(guac_user* user, void* data) {
-
-    const guac_user* quitter = (const guac_user *) data;
-
-    if (user == NULL)
-        return (void*) ((intptr_t) -1);
-
-    char* log_owner = "owner";
-    if (user->info.name != NULL)
-        log_owner = (char *) user->info.name;
-
-    char* log_quitter = "anonymous";
-    char* send_quitter = "";
-    if (quitter->info.name != NULL) {
-        log_quitter = (char *) quitter->info.name;
-        send_quitter = (char *) quitter->info.name;
-    }
-
-    guac_user_log(user, GUAC_LOG_DEBUG, "Notifying owner \"%s\" of \"%s\" leaving.",
-            log_owner, log_quitter);
-    
-    /* Send user left notification to owner. */
-    const char* args[] = { (const char*)quitter->user_id, (const char*)send_quitter, NULL };
-    return (void*) ((intptr_t) guac_protocol_send_msg(user->socket, GUAC_MESSAGE_USER_LEFT, args));
-
-}
-
-int guac_client_owner_notify_leave(guac_client* client, guac_user* quitter) {
-
-    /* Don't send msg instruction if client does not support it. */
-    if (!guac_client_owner_supports_msg(client)) {
-        guac_client_log(client, GUAC_LOG_DEBUG,
-                        "Client does not support the \"msg\" instruction and "
-                        "will not be notified of the user leaving the connection.");
-        return -1;
-    }
-
-    return (int) ((intptr_t) guac_client_for_owner(client, guac_client_owner_notify_leave_callback, quitter));
-
-}
-
 int guac_client_supports_webp(guac_client* client) {
 
 #ifdef ENABLE_WEBP
@@ -877,3 +717,62 @@ int guac_client_supports_webp(guac_client* client) {
 
 }
 
+/**
+ * A callback that it is invokved by the call to guac_client_owner_send_uri
+ * which sends the 'uri" instruction and parameter to the specified user, who
+ * is the owner of the connection.
+ *
+ * @param user
+ *     The user to send the "uri" instruction and parameter to, who owns the
+ *     connection.
+ *
+ * @param data
+ *     The URI to send to the owner, cast as a void*.
+ *
+ * @return
+ *     Zero if the operation succeeds or non-zero on failure.
+ */
+static void* guac_client_owner_send_uri_callback(guac_user* user, void* data) {
+    
+    const char* uri = (const char *) data;
+    
+    /* Send uri parameter to owner. */
+    if (user != NULL)
+        return (void*) ((intptr_t) guac_protocol_send_uri(user->socket, uri));
+    
+    return (void*) ((intptr_t) -1);
+}
+
+int guac_client_owner_send_uri(guac_client* client, const char* uri) {
+
+    /* Don't send the uri instruction if the client does not support it. */
+    if (!guac_client_owner_supports_uri(client))
+        return -1;
+
+    return (int) ((intptr_t) guac_client_for_owner(client, guac_client_owner_send_uri_callback, (void *) uri));
+
+}
+
+/**
+ * Callback function that is invoked by guac_client_owner_supports_uri to
+ * determine if the owner of a connection supports the "uri" instruction,
+ * so that Guacamole can pass URIs to the client browser.
+ *
+ * @param user
+ *     The user that is being checked for URI support, which should be the
+ *     owner of the connection.
+ *
+ * @param data
+ *     Additional data - this will always be null.
+ *
+ * @return
+ *     A non-zero integer if the user supports the "uri" instruction, otherwise
+ *     zero to indicate a lack of URI support.
+ */
+static void* guac_owner_supports_uri_callback(guac_user* user, void* data) {
+    return (void*) ((intptr_t) guac_user_supports_uri(user));
+}
+
+int guac_client_owner_supports_uri(guac_client* client) {
+    return (int) ((intptr_t) guac_client_for_owner(client, guac_owner_supports_uri_callback, NULL));
+}

src/libguac/fips.c

@@ -1,51 +0,0 @@
-/*
- * Licensed to the Apache Software Foundation (ASF) under one
- * or more contributor license agreements.  See the NOTICE file
- * distributed with this work for additional information
- * regarding copyright ownership.  The ASF licenses this file
- * to you under the Apache License, Version 2.0 (the
- * "License"); you may not use this file except in compliance
- * with the License.  You may obtain a copy of the License at
- *
- *   http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing,
- * software distributed under the License is distributed on an
- * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
- * KIND, either express or implied.  See the License for the
- * specific language governing permissions and limitations
- * under the License.
- */
-
-#include "config.h"
-#include "guacamole/fips.h"
-
-/* If OpenSSL is available, include header for version numbers */
-#ifdef ENABLE_SSL
-    #include <openssl/opensslv.h>
-
-    /* OpenSSL versions prior to 0.9.7e did not have FIPS support */
-    #if !defined(OPENSSL_VERSION_NUMBER) || (OPENSSL_VERSION_NUMBER < 0x00090705f)
-    #define GUAC_FIPS_ENABLED 0
-
-    /* OpenSSL 3+ uses EVP_default_properties_is_fips_enabled() */
-    #elif defined(OPENSSL_VERSION_MAJOR) && (OPENSSL_VERSION_MAJOR >= 3)
-    #include <openssl/evp.h>
-    #define GUAC_FIPS_ENABLED EVP_default_properties_is_fips_enabled(NULL)
-
-    /* For OpenSSL versions between 0.9.7e and 3.0, use FIPS_mode() */
-    #else
-    #include <openssl/crypto.h>
-    #define GUAC_FIPS_ENABLED FIPS_mode()
-    #endif
-
-/* FIPS support does not exist if OpenSSL is not available. */
-#else
-#define GUAC_FIPS_ENABLED 0
-#endif
-
-int guac_fips_enabled() {
-
-    return GUAC_FIPS_ENABLED;
-
-}

src/libguac/guacamole/client.h

@@ -509,47 +509,18 @@ void* guac_client_for_user(guac_client* client, guac_user* user,
         guac_user_callback* callback, void* data);
 
 /**
- * Marks the end of the current frame by sending a "sync" instruction to all
- * connected users, where the number of input frames that were considered in
- * creating this frame is either unknown or inapplicable. This instruction will
- * contain the current timestamp. The last_sent_timestamp member of guac_client
- * will be updated accordingly.
+ * Marks the end of the current frame by sending a "sync" instruction to
+ * all connected users. This instruction will contain the current timestamp.
+ * The last_sent_timestamp member of guac_client will be updated accordingly.
  *
  * If an error occurs sending the instruction, a non-zero value is
  * returned, and guac_error is set appropriately.
  *
- * @param client
- *     The guac_client which has finished a frame.
- *
- * @return
- *     Zero on success, non-zero on error.
+ * @param client The guac_client which has finished a frame.
+ * @return Zero on success, non-zero on error.
  */
 int guac_client_end_frame(guac_client* client);
 
-/**
- * Marks the end of the current frame by sending a "sync" instruction to all
- * connected users, where that frame may combine or otherwise represent the
- * changes of an arbitrary number of input frames. This instruction will
- * contain the current timestamp, as well as the number of frames that were
- * considered in creating that frame.  The last_sent_timestamp member of
- * guac_client will be updated accordingly.
- *
- * If an error occurs sending the instruction, a non-zero value is
- * returned, and guac_error is set appropriately.
- *
- * @param client
- *     The guac_client which has finished a frame.
- *
- * @param frames
- *     The number of distinct frames that were considered or combined when
- *     generating the current frame, or zero if the boundaries of relevant
- *     frames are unknown.
- *
- * @return
- *     Zero on success, non-zero on error.
- */
-int guac_client_end_multiple_frames(guac_client* client, int frames);
-
 /**
  * Initializes the given guac_client using the initialization routine provided
  * by the plugin corresponding to the named protocol. This will automatically
@@ -594,6 +565,22 @@ int guac_client_get_processing_lag(guac_client* client);
  */
 int guac_client_owner_send_required(guac_client* client, const char** required);
 
+/**
+ * Sends the "uri" instruction to the given guac_client so that the remote
+ * client can process the URI, if the client supports it and has a handler
+ * configured for the URI.
+ *
+ * @param client
+ *     The client to which to send the URI instruction.
+ * 
+ * @param uri
+ *     The URI to send to the remote client.
+ *
+ * @return
+ *     Zero on success, non-zero on failure.
+ */
+int guac_client_owner_send_uri(guac_client* client, const char* uri);
+
 /**
  * Streams the given connection parameter value over an argument value stream
  * ("argv" instruction), exposing the current value of the named connection
@@ -737,21 +724,6 @@ void guac_client_stream_webp(guac_client* client, guac_socket* socket,
         guac_composite_mode mode, const guac_layer* layer, int x, int y,
         cairo_surface_t* surface, int quality, int lossless);
 
-/**
- * Returns whether the owner of the given client supports the "msg"
- * instruction, returning non-zero if the client owner does support the
- * instruction, or zero if the owner does not.
- * 
- * @param client
- *     The Guacamole client whose owner should be checked for supporting
- *     the "msg" instruction.
- * 
- * @return 
- *     Non-zero if the owner of the given client supports the "msg"
- *     instruction, zero otherwise.
- */
-int guac_client_owner_supports_msg(guac_client* client);
-
 /**
  * Returns whether the owner of the given client supports the "required"
  * instruction, returning non-zero if the client owner does support the
@@ -767,42 +739,6 @@ int guac_client_owner_supports_msg(guac_client* client);
  */
 int guac_client_owner_supports_required(guac_client* client);
 
-/**
- * Notifies the owner of the given client that a user has joined the connection,
- * and returns zero if the message was sent successfully, or non-zero if the
- * notification failed.
- *
- * @param client
- *     The Guacamole Client whose owner should be notified of a user joining
- *     the connection.
- *
- * @param joiner
- *     The Guacamole User who joined the connection.
- * 
- * @return
- *     Zero if the notification to the owner was sent successfully, or non-zero
- *     if an error occurred.
- */
-int guac_client_owner_notify_join(guac_client* client, guac_user* joiner);
-
-/**
- * Notifies the owner of the given client that a user has left the connection,
- * and returns zero if the message was sent successfully, or non-zero if the
- * notification failed.
- *
- * @param client
- *     The Guacamole Client whose owner should be notified of a user leaving
- *     the connection.
- *
- * @param quitter
- *     The Guacamole User who left the connection.
- * 
- * @return
- *     Zero if the notification to the owner was sent successfully, or non-zero
- *     if an error occurred.
- */
-int guac_client_owner_notify_leave(guac_client* client, guac_user* quitter);
-
 /**
  * Returns whether all users of the given client support WebP. If any user does
  * not support WebP, or the server cannot encode WebP images, zero is returned.
@@ -816,6 +752,8 @@ int guac_client_owner_notify_leave(guac_client* client, guac_user* quitter);
  */
 int guac_client_supports_webp(guac_client* client);
 
+int guac_client_owner_supports_uri(guac_client* client);
+
 /**
  * The default Guacamole client layer, layer 0.
  */

src/libguac/guacamole/fips.h

@@ -1,33 +0,0 @@
-/*
- * Licensed to the Apache Software Foundation (ASF) under one
- * or more contributor license agreements.  See the NOTICE file
- * distributed with this work for additional information
- * regarding copyright ownership.  The ASF licenses this file
- * to you under the Apache License, Version 2.0 (the
- * "License"); you may not use this file except in compliance
- * with the License.  You may obtain a copy of the License at
- *
- *   http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing,
- * software distributed under the License is distributed on an
- * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
- * KIND, either express or implied.  See the License for the
- * specific language governing permissions and limitations
- * under the License.
- */
-
-#ifndef GUAC_FIPS_H
-#define GUAC_FIPS_H
-
-/**
- * Returns a non-zero value if FIPS mode is enabled, or zero if FIPS mode
- * is not enabled.
- *
- * @return
- *      A non-zero value if FIPS mode is enabled, or zero if FIPS mode is
- *      not enabled.
- */
-int guac_fips_enabled();
-
-#endif

src/libguac/guacamole/protocol-constants.h

@@ -38,7 +38,7 @@
  * This version is passed by the __guac_protocol_send_args() function from the
  * server to the client during the client/server handshake.
  */
-#define GUACAMOLE_PROTOCOL_VERSION "VERSION_1_5_0"
+#define GUACAMOLE_PROTOCOL_VERSION "VERSION_1_6_0"
 
 /**
  * The maximum number of bytes that should be sent in any one blob instruction

src/libguac/guacamole/protocol-types.h

@@ -309,37 +309,12 @@ typedef enum guac_protocol_version {
     GUAC_PROTOCOL_VERSION_1_3_0 = 0x010300,
 
     /**
-     * Protocol version 1.5.0, which supports the "msg" instruction, allowing
-     * messages to be sent to the client, and adds support for the "name"
-     * handshake instruction.
+     * Protocol version 1.6.0, which supports the "uri" instruction, allowing
+     * remote systems to send 
      */
-    GUAC_PROTOCOL_VERSION_1_5_0 = 0x010500
+    GUAC_PROTOCOL_VERSION_1_6_0 = 0x010600
 
 } guac_protocol_version;
 
-/**
- * A type that represents codes for human-readable messages sent by the "msg"
- * instruction to the Client, that will be displayed in the client's browser.
- * The codes will be interpreted by the client into translatable messages, and
- * make take arguments, as noted below.
- */
-typedef enum guac_message_type {
-
-    /**
-     * A message that notifies the owner of a connection that another user has
-     * joined their connection. There should be a single argument provided, the
-     * name of the user who has joined.
-     */
-    GUAC_MESSAGE_USER_JOINED = 0x0001,
-
-    /**
-     * A message that notifies the owner of a connection that another user has
-     * left their connection. There should be a single argument provided, the
-     * name of the user who has left.
-     */
-    GUAC_MESSAGE_USER_LEFT = 0x0002
-
-} guac_message_type;
-
 #endif
 

src/libguac/guacamole/protocol.h

@@ -171,27 +171,6 @@ int guac_protocol_send_log(guac_socket* socket, const char* format, ...);
 int vguac_protocol_send_log(guac_socket* socket, const char* format,
         va_list args);
 
-/**
- * Sends the given string over the socket to be displayed on the client. Returns
- * zero if the message was sent successfully or non-zero if an error occurs.
- *
- * @param socket
- *     The guac_socket connection to send the message to.
- *
- * @param msg
- *     The message code to send to the client.
- *
- * @param args
- *     A null-terminated array of strings that will be provided to the client
- *     as part of the message, that the client may then place in the message,
- *     or null if the message requires no arguments.
- *
- * @return
- *     Zero if the message is sent successfully; otherwise non-zero.
- */
-int guac_protocol_send_msg(guac_socket* socket, guac_message_type msg,
-        const char** args);
-
 /**
  * Sends a mouse instruction over the given guac_socket connection.
  *
@@ -384,22 +363,11 @@ int guac_protocol_send_select(guac_socket* socket, const char* protocol);
  * If an error occurs sending the instruction, a non-zero value is
  * returned, and guac_error is set appropriately.
  *
- * @param socket
- *     The guac_socket connection to use.
- *
- * @param timestamp
- *     The current timestamp (in milliseconds).
- *
- * @param frames
- *     The number of distinct frames that were considered or combined when
- *     generating the frame terminated by this instruction, or zero if the
- *     boundaries of relevant frames are unknown.
- *
- * @return
- *     Zero on success, non-zero on error.
+ * @param socket The guac_socket connection to use.
+ * @param timestamp The current timestamp (in milliseconds).
+ * @return Zero on success, non-zero on error.
  */
-int guac_protocol_send_sync(guac_socket* socket, guac_timestamp timestamp,
-        int frames);
+int guac_protocol_send_sync(guac_socket* socket, guac_timestamp timestamp);
 
 /* OBJECT INSTRUCTIONS */
 
@@ -1069,6 +1037,21 @@ int guac_protocol_send_shade(guac_socket* socket, const guac_layer* layer,
 int guac_protocol_send_size(guac_socket* socket, const guac_layer* layer,
         int w, int h);
 
+/**
+ * Send the uri instruction over the given guac_socket connection,
+ * providing a URI that the client should then process locally.
+ * 
+ * @param socket
+ *     The guac_socket connection to which to send the uri instruction.
+ *
+ * @param uri
+ *     The URI that should be sent to the client.
+ *
+ * @return
+ *     Zero on success, non-zero on error.
+ */
+int guac_protocol_send_uri(guac_socket* socket, const char* uri);
+
 /* TEXT INSTRUCTIONS */
 
 /**

src/libguac/guacamole/user.h

@@ -102,14 +102,6 @@ struct guac_user_info {
      */
     guac_protocol_version protocol_version;
 
-    /**
-     * The human-readable name of the Guacamole user, supplied by the client
-     * during the handshake. This is an arbitrary value, with no requirements or
-     * constraints, including that it need not uniquely identify the user.
-     * If the client does not provide a name then this will be NULL.
-     */
-    const char* name;
-
 };
 
 struct guac_user {
@@ -858,17 +850,6 @@ void guac_user_stream_webp(guac_user* user, guac_socket* socket,
         guac_composite_mode mode, const guac_layer* layer, int x, int y,
         cairo_surface_t* surface, int quality, int lossless);
 
-/**
- * Returns whether the given user supports the "msg" instruction.
- * 
- * @param user
- *     The Guacamole user to check for support of the "msg" instruction.
- * 
- * @return 
- *     Non-zero if the user supports the "msg" instruction, otherwise zero.
- */
-int guac_user_supports_msg(guac_user* user);
-
 /**
  * Returns whether the given user supports the "required" instruction.
  * 
@@ -880,6 +861,17 @@ int guac_user_supports_msg(guac_user* user);
  */
 int guac_user_supports_required(guac_user* user);
 
+/**
+ * Returns non-zero if the user supports the "uri" instruction.
+ *
+ * @param user
+ *     The Guacamole user to check for support of the "uri" instruction.
+ *
+ * @return
+ *     Non-zero if the user supports the "uri" instruction, otherwise zero.
+ */
+int guac_user_supports_uri(guac_user* user);
+
 /**
  * Returns whether the given user supports WebP. If the user does not
  * support WebP, or the server cannot encode WebP images, zero is returned.

src/libguac/protocol.c

@@ -65,7 +65,7 @@ guac_protocol_version_mapping guac_protocol_version_table[] = {
     { GUAC_PROTOCOL_VERSION_1_0_0,   "VERSION_1_0_0" },
     { GUAC_PROTOCOL_VERSION_1_1_0,   "VERSION_1_1_0" },
     { GUAC_PROTOCOL_VERSION_1_3_0,   "VERSION_1_3_0" },
-    { GUAC_PROTOCOL_VERSION_1_5_0,   "VERSION_1_5_0" },
+    { GUAC_PROTOCOL_VERSION_1_6_0,   "VERSION_1_6_0" },
     { GUAC_PROTOCOL_VERSION_UNKNOWN, NULL }
 };
 
@@ -659,23 +659,6 @@ int guac_protocol_send_log(guac_socket* socket, const char* format, ...) {
 
 }
 
-int guac_protocol_send_msg(guac_socket* socket, guac_message_type msg,
-        const char** args) {
-
-    int ret_val;
-
-    guac_socket_instruction_begin(socket);
-    ret_val =
-           guac_socket_write_string(socket, "3.msg,")
-        || __guac_socket_write_length_int(socket, msg)
-        || guac_socket_write_array(socket, args)
-        || guac_socket_write_string(socket, ";");
-
-    guac_socket_instruction_end(socket);
-    return ret_val;
-
-}
-
 int guac_protocol_send_file(guac_socket* socket, const guac_stream* stream,
         const char* mimetype, const char* name) {
 
@@ -1199,8 +1182,7 @@ int guac_protocol_send_start(guac_socket* socket, const guac_layer* layer,
 
 }
 
-int guac_protocol_send_sync(guac_socket* socket, guac_timestamp timestamp,
-        int frames) {
+int guac_protocol_send_sync(guac_socket* socket, guac_timestamp timestamp) {
 
     int ret_val;
 
@@ -1208,8 +1190,6 @@ int guac_protocol_send_sync(guac_socket* socket, guac_timestamp timestamp,
     ret_val = 
            guac_socket_write_string(socket, "4.sync,")
         || __guac_socket_write_length_int(socket, timestamp)
-        || guac_socket_write_string(socket, ",")
-        || __guac_socket_write_length_int(socket, frames)
         || guac_socket_write_string(socket, ";");
 
     guac_socket_instruction_end(socket);
@@ -1295,6 +1275,21 @@ int guac_protocol_send_undefine(guac_socket* socket,
 
 }
 
+int guac_protocol_send_uri(guac_socket* socket, const char* uri) {
+
+    int ret_val;
+    
+    guac_socket_instruction_begin(socket);
+    ret_val =
+           guac_socket_write_string(socket, "3.uri,")
+        || __guac_socket_write_length_string(socket, uri)
+        || guac_socket_write_string(socket, ";");
+
+    guac_socket_instruction_end(socket);
+    return ret_val;
+
+}
+
 int guac_protocol_send_video(guac_socket* socket, const guac_stream* stream,
         const guac_layer* layer, const char* mimetype) {
 

src/libguac/tests/protocol/guac_protocol_version.c

@@ -27,11 +27,11 @@
  */
 void test_guac_protocol__version_to_string() {
     
-    guac_protocol_version version_a = GUAC_PROTOCOL_VERSION_1_5_0;
+    guac_protocol_version version_a = GUAC_PROTOCOL_VERSION_1_3_0;
     guac_protocol_version version_b = GUAC_PROTOCOL_VERSION_1_0_0;
     guac_protocol_version version_c = GUAC_PROTOCOL_VERSION_UNKNOWN;
     
-    CU_ASSERT_STRING_EQUAL(guac_protocol_version_to_string(version_a), "VERSION_1_5_0");
+    CU_ASSERT_STRING_EQUAL(guac_protocol_version_to_string(version_a), "VERSION_1_3_0");
     CU_ASSERT_STRING_EQUAL(guac_protocol_version_to_string(version_b), "VERSION_1_0_0");
     CU_ASSERT_PTR_NULL(guac_protocol_version_to_string(version_c));
     

src/libguac/tests/socket/fd_send_instruction.c

@@ -54,7 +54,7 @@ static void write_instructions(int fd) {
 
     /* Write instructions */
     guac_protocol_send_name(socket, "a" UTF8_4 "b" UTF8_4 "c");
-    guac_protocol_send_sync(socket, 12345, 1);
+    guac_protocol_send_sync(socket, 12345);
     guac_socket_flush(socket);
 
     /* Close and free socket */
@@ -76,7 +76,7 @@ static void read_expected_instructions(int fd) {
 
     char expected[] =
         "4.name,11.a" UTF8_4 "b" UTF8_4 "c;"
-        "4.sync,5.12345,1.1;";
+        "4.sync,5.12345;";
 
     int numread;
     char buffer[1024];

src/libguac/tests/socket/nested_send_instruction.c

@@ -65,7 +65,7 @@ static void write_instructions(int fd) {
 
     /* Write instructions */
     guac_protocol_send_name(nested_socket, "a" UTF8_4 "b" UTF8_4 "c");
-    guac_protocol_send_sync(nested_socket, 12345, 1);
+    guac_protocol_send_sync(nested_socket, 12345);
 
     /* Close and free sockets */
     guac_socket_free(nested_socket);
@@ -86,9 +86,9 @@ static void write_instructions(int fd) {
 static void read_expected_instructions(int fd) {
 
     char expected[] =
-        "4.nest,3.123,41."
+        "4.nest,3.123,37."
             "4.name,11.a" UTF8_4 "b" UTF8_4 "c;"
-            "4.sync,5.12345,1.1;"
+            "4.sync,5.12345;"
         ";";
 
     int numread;

src/libguac/user-handlers.c

@@ -64,7 +64,6 @@ __guac_instruction_handler_mapping __guac_handshake_handler_map[] = {
     {"video",    __guac_handshake_video_handler},
     {"image",    __guac_handshake_image_handler},
     {"timezone", __guac_handshake_timezone_handler},
-    {"name",     __guac_handshake_name_handler},
     {NULL,       NULL}
 };
 
@@ -121,27 +120,14 @@ int __guac_handle_sync(guac_user* user, int argc, char** argv) {
         /* Calculate length of frame, including network and processing lag */
         frame_duration = current - timestamp;
 
-        /* Calculate processing lag portion of length of frame */
-        int frame_processing_lag = 0;
+        /* Update lag statistics if at least one frame has been rendered */
         if (user->last_frame_duration != 0) {
 
             /* Calculate lag using the previous frame as a baseline */
-            frame_processing_lag = frame_duration - user->last_frame_duration;
+            int processing_lag = frame_duration - user->last_frame_duration;
 
             /* Adjust back to zero if cumulative error leads to a negative
              * value */
-            if (frame_processing_lag < 0)
-                frame_processing_lag = 0;
-
-        }
-
-        /* Record baseline duration of frame by excluding lag (this is the
-         * network round-trip time) */
-        int estimated_rtt = frame_duration - frame_processing_lag;
-        user->last_frame_duration = estimated_rtt;
-
-        /* Calculate cumulative accumulated processing lag relative to server timeline */
-        int processing_lag = current - user->last_received_timestamp - estimated_rtt;
             if (processing_lag < 0)
                 processing_lag = 0;
 
@@ -149,11 +135,16 @@ int __guac_handle_sync(guac_user* user, int argc, char** argv) {
 
         }
 
+        /* Record baseline duration of frame by excluding lag */
+        user->last_frame_duration = frame_duration - user->processing_lag;
+
+    }
+
     /* Log received timestamp and calculated lag (at TRACE level only) */
     guac_user_log(user, GUAC_LOG_TRACE,
             "User confirmation of frame %" PRIu64 "ms received "
-            "at %" PRIu64 "ms (processing_lag=%ims, estimated_rtt=%ims)",
-            timestamp, current, user->processing_lag, user->last_frame_duration);
+            "at %" PRIu64 "ms (processing_lag=%ims)",
+            timestamp, current, user->processing_lag);
 
     if (user->sync_handler)
         return user->sync_handler(user, timestamp);
@@ -685,23 +676,6 @@ int __guac_handshake_image_handler(guac_user* user, int argc, char** argv) {
     
 }
 
-int __guac_handshake_name_handler(guac_user* user, int argc, char** argv) {
-
-    /* Free any past value for the user's name */
-    free((char *) user->info.name);
-
-    /* If a value is provided for the name, copy it into guac_user. */
-    if (argc > 0 && strcmp(argv[0], ""))
-        user->info.name = (const char*) strdup(argv[0]);
-
-    /* No or empty value was provided, so make sure this is NULLed out. */
-    else
-        user->info.name = NULL;
-
-    return 0;
-
-}
-
 int __guac_handshake_timezone_handler(guac_user* user, int argc, char** argv) {
     
     /* Free any past value */

src/libguac/user-handlers.h

@@ -218,13 +218,6 @@ __guac_instruction_handler __guac_handshake_video_handler;
  */
 __guac_instruction_handler __guac_handshake_image_handler;
 
-/**
- * Internal handler function that is called when the name instruction is
- * received during the handshake process, specifying the name of the Guacamole
- * user establishing the connection.
- */
-__guac_instruction_handler __guac_handshake_name_handler;
-
 /**
  * Internal handler function that is called when the timezone instruction is
  * received during the handshake process, specifying the timezone of the

src/libguac/user-handshake.c

@@ -296,7 +296,6 @@ int guac_user_handle_connection(guac_user* user, int usec_timeout) {
     user->info.audio_mimetypes = NULL;
     user->info.image_mimetypes = NULL;
     user->info.video_mimetypes = NULL;
-    user->info.name = NULL;
     user->info.timezone = NULL;
     
     /* Count number of arguments. */
@@ -371,8 +370,7 @@ int guac_user_handle_connection(guac_user* user, int usec_timeout) {
     guac_free_mimetypes((char **) user->info.image_mimetypes);
     guac_free_mimetypes((char **) user->info.video_mimetypes);
     
-    /* Free name and timezone info. */
-    free((char *) user->info.name);
+    /* Free timezone info. */
     free((char *) user->info.timezone);
     
     guac_parser_free(parser);

src/libguac/user.c

@@ -316,15 +316,6 @@ void guac_user_stream_webp(guac_user* user, guac_socket* socket,
 
 }
 
-int guac_user_supports_msg(guac_user* user) {
-
-    if (user == NULL)
-        return 0;
-
-    return (user->info.protocol_version >= GUAC_PROTOCOL_VERSION_1_5_0);
-
-}
-
 int guac_user_supports_required(guac_user* user) {
     
     if (user == NULL)
@@ -334,6 +325,14 @@ int guac_user_supports_required(guac_user* user) {
     
 }
 
+int guac_user_supports_uri(guac_user* user) {
+    
+    if (user == NULL)
+        return 0;
+
+    return (user->info.protocol_version >= GUAC_PROTOCOL_VERSION_1_6_0);
+}
+
 int guac_user_supports_webp(guac_user* user) {
 
 #ifdef ENABLE_WEBP

src/protocols/rdp/Makefile.am

@@ -57,9 +57,9 @@ libguac_client_rdp_la_SOURCES =                  \
     channels/rdpdr/rdpdr-printer.c               \
     channels/rdpdr/rdpdr.c                       \
     channels/rdpei.c                             \
-    channels/rdpgfx.c                            \
     channels/rdpsnd/rdpsnd-messages.c            \
     channels/rdpsnd/rdpsnd.c                     \
+    channels/rdpuri.c                            \
     client.c                                     \
     color.c                                      \
     decompose.c                                  \
@@ -104,9 +104,9 @@ noinst_HEADERS =                                 \
     channels/rdpdr/rdpdr-printer.h               \
     channels/rdpdr/rdpdr.h                       \
     channels/rdpei.h                             \
-    channels/rdpgfx.h                            \
     channels/rdpsnd/rdpsnd-messages.h            \
     channels/rdpsnd/rdpsnd.h                     \
+    channels/rdpuri.h                            \
     client.h                                     \
     color.h                                      \
     decompose.h                                  \
@@ -230,7 +230,6 @@ BUILT_SOURCES =                         \
 rdp_keymaps =                                \
     $(srcdir)/keymaps/base.keymap            \
     $(srcdir)/keymaps/failsafe.keymap        \
-    $(srcdir)/keymaps/cs-cz-qwertz.keymap    \
     $(srcdir)/keymaps/de_de_qwertz.keymap    \
     $(srcdir)/keymaps/de_ch_qwertz.keymap    \
     $(srcdir)/keymaps/en_gb_qwerty.keymap    \

src/protocols/rdp/bitmap.c

@@ -149,7 +149,7 @@ BOOL guac_rdp_bitmap_setsurface(rdpContext* context, rdpBitmap* bitmap, BOOL pri
 
     else {
 
-        /* Make sure that the received bitmap is not NULL before processing */
+        /* Make sure that the recieved bitmap is not NULL before processing */
         if (bitmap == NULL) {
             guac_client_log(client, GUAC_LOG_INFO, "NULL bitmap found in bitmap_setsurface instruction.");
             return TRUE;

src/protocols/rdp/channels/cliprdr.c

@@ -509,12 +509,12 @@ static UINT guac_rdp_cliprdr_format_data_response(CliprdrClientContext* cliprdr,
  * @param context
  *     The rdpContext associated with the active RDP session.
  *
- * @param args
+ * @param e
  *     Event-specific arguments, mainly the name of the channel, and a
  *     reference to the associated plugin loaded for that channel by FreeRDP.
  */
 static void guac_rdp_cliprdr_channel_connected(rdpContext* context,
-        ChannelConnectedEventArgs* args) {
+        ChannelConnectedEventArgs* e) {
 
     guac_client* client = ((rdp_freerdp_context*) context)->client;
     guac_rdp_client* rdp_client = (guac_rdp_client*) client->data;
@@ -526,12 +526,12 @@ static void guac_rdp_cliprdr_channel_connected(rdpContext* context,
     assert(clipboard != NULL);
 
     /* Ignore connection event if it's not for the CLIPRDR channel */
-    if (strcmp(args->name, CLIPRDR_SVC_CHANNEL_NAME) != 0)
+    if (strcmp(e->name, CLIPRDR_SVC_CHANNEL_NAME) != 0)
         return;
 
     /* The structure pointed to by pInterface is guaranteed to be a
      * CliprdrClientContext if the channel is CLIPRDR */
-    CliprdrClientContext* cliprdr = (CliprdrClientContext*) args->pInterface;
+    CliprdrClientContext* cliprdr = (CliprdrClientContext*) e->pInterface;
 
     /* Associate FreeRDP CLIPRDR context and its Guacamole counterpart with
      * eachother */
@@ -562,12 +562,12 @@ static void guac_rdp_cliprdr_channel_connected(rdpContext* context,
  * @param context
  *     The rdpContext associated with the active RDP session.
  *
- * @param args
+ * @param e
  *     Event-specific arguments, mainly the name of the channel, and a
  *     reference to the associated plugin loaded for that channel by FreeRDP.
  */
 static void guac_rdp_cliprdr_channel_disconnected(rdpContext* context,
-        ChannelDisconnectedEventArgs* args) {
+        ChannelDisconnectedEventArgs* e) {
 
     guac_client* client = ((rdp_freerdp_context*) context)->client;
     guac_rdp_client* rdp_client = (guac_rdp_client*) client->data;
@@ -579,7 +579,7 @@ static void guac_rdp_cliprdr_channel_disconnected(rdpContext* context,
     assert(clipboard != NULL);
 
     /* Ignore disconnection event if it's not for the CLIPRDR channel */
-    if (strcmp(args->name, CLIPRDR_SVC_CHANNEL_NAME) != 0)
+    if (strcmp(e->name, CLIPRDR_SVC_CHANNEL_NAME) != 0)
         return;
 
     /* Channel is no longer connected */

src/protocols/rdp/channels/common-svc.h

@@ -115,7 +115,7 @@ struct guac_rdp_common_svc {
     guac_rdp_common_svc_receive_handler* _receive_handler;
 
     /**
-     * Handler which is involved when the SVC has been disconnected and is
+     * Handler which is invokved when the SVC has been disconnected and is
      * about to be freed.
      */
     guac_rdp_common_svc_terminate_handler* _terminate_handler;

src/protocols/rdp/channels/disp.c

@@ -68,19 +68,19 @@ void guac_rdp_disp_free(guac_rdp_disp* disp) {
  * @param context
  *     The rdpContext associated with the active RDP session.
  *
- * @param args
+ * @param e
  *     Event-specific arguments, mainly the name of the channel, and a
  *     reference to the associated plugin loaded for that channel by FreeRDP.
  */
 static void guac_rdp_disp_channel_connected(rdpContext* context,
-        ChannelConnectedEventArgs* args) {
+        ChannelConnectedEventArgs* e) {
 
     guac_client* client = ((rdp_freerdp_context*) context)->client;
     guac_rdp_client* rdp_client = (guac_rdp_client*) client->data;
     guac_rdp_disp* guac_disp = rdp_client->disp;
 
     /* Ignore connection event if it's not for the Display Update channel */
-    if (strcmp(args->name, DISP_DVC_CHANNEL_NAME) != 0)
+    if (strcmp(e->name, DISP_DVC_CHANNEL_NAME) != 0)
         return;
 
     /* Init module with current display size */
@@ -89,7 +89,7 @@ static void guac_rdp_disp_channel_connected(rdpContext* context,
             guac_rdp_get_height(context->instance));
 
     /* Store reference to the display update plugin once it's connected */
-    DispClientContext* disp = (DispClientContext*) args->pInterface;
+    DispClientContext* disp = (DispClientContext*) e->pInterface;
     guac_disp->disp = disp;
 
     guac_client_log(client, GUAC_LOG_DEBUG, "Display update channel "
@@ -110,19 +110,19 @@ static void guac_rdp_disp_channel_connected(rdpContext* context,
  * @param context
  *     The rdpContext associated with the active RDP session.
  *
- * @param args
+ * @param e
  *     Event-specific arguments, mainly the name of the channel, and a
  *     reference to the associated plugin loaded for that channel by FreeRDP.
  */
 static void guac_rdp_disp_channel_disconnected(rdpContext* context,
-        ChannelDisconnectedEventArgs* args) {
+        ChannelDisconnectedEventArgs* e) {
 
     guac_client* client = ((rdp_freerdp_context*) context)->client;
     guac_rdp_client* rdp_client = (guac_rdp_client*) client->data;
     guac_rdp_disp* guac_disp = rdp_client->disp;
 
     /* Ignore disconnection event if it's not for the Display Update channel */
-    if (strcmp(args->name, DISP_DVC_CHANNEL_NAME) != 0)
+    if (strcmp(e->name, DISP_DVC_CHANNEL_NAME) != 0)
         return;
 
     /* Channel is no longer connected */

src/protocols/rdp/channels/disp.h

@@ -109,7 +109,7 @@ void guac_rdp_disp_free(guac_rdp_disp* disp);
 /**
  * Adds FreeRDP's "disp" plugin to the list of dynamic virtual channel plugins
  * to be loaded by FreeRDP's "drdynvc" plugin. The context of the plugin will
- * automatically be associated with the guac_rdp_disp instance pointed to by the
+ * automatically be assicated with the guac_rdp_disp instance pointed to by the
  * current guac_rdp_client. The plugin will only be loaded once the "drdynvc"
  * plugin is loaded. The "disp" plugin ultimately adds support for the Display
  * Update channel.

src/protocols/rdp/channels/rail.c

@@ -230,22 +230,22 @@ static UINT guac_rdp_rail_handshake_ex(RailClientContext* rail,
  * @param context
  *     The rdpContext associated with the active RDP session.
  *
- * @param args
+ * @param e
  *     Event-specific arguments, mainly the name of the channel, and a
  *     reference to the associated plugin loaded for that channel by FreeRDP.
  */
 static void guac_rdp_rail_channel_connected(rdpContext* context,
-        ChannelConnectedEventArgs* args) {
+        ChannelConnectedEventArgs* e) {
 
     guac_client* client = ((rdp_freerdp_context*) context)->client;
 
     /* Ignore connection event if it's not for the RAIL channel */
-    if (strcmp(args->name, RAIL_SVC_CHANNEL_NAME) != 0)
+    if (strcmp(e->name, RAIL_SVC_CHANNEL_NAME) != 0)
         return;
 
     /* The structure pointed to by pInterface is guaranteed to be a
      * RailClientContext if the channel is RAIL */
-    RailClientContext* rail = (RailClientContext*) args->pInterface;
+    RailClientContext* rail = (RailClientContext*) e->pInterface;
 
     /* Init FreeRDP RAIL context, ensuring the guac_client can be accessed from
      * within any RAIL-specific callbacks */

src/protocols/rdp/channels/rdpei.c

@@ -66,23 +66,23 @@ void guac_rdp_rdpei_free(guac_rdp_rdpei* rdpei) {
  * @param context
  *     The rdpContext associated with the active RDP session.
  *
- * @param args
+ * @param e
  *     Event-specific arguments, mainly the name of the channel, and a
  *     reference to the associated plugin loaded for that channel by FreeRDP.
  */
 static void guac_rdp_rdpei_channel_connected(rdpContext* context,
-        ChannelConnectedEventArgs* args) {
+        ChannelConnectedEventArgs* e) {
 
     guac_client* client = ((rdp_freerdp_context*) context)->client;
     guac_rdp_client* rdp_client = (guac_rdp_client*) client->data;
     guac_rdp_rdpei* guac_rdpei = rdp_client->rdpei;
 
     /* Ignore connection event if it's not for the RDPEI channel */
-    if (strcmp(args->name, RDPEI_DVC_CHANNEL_NAME) != 0)
+    if (strcmp(e->name, RDPEI_DVC_CHANNEL_NAME) != 0)
         return;
 
     /* Store reference to the RDPEI plugin once it's connected */
-    RdpeiClientContext* rdpei = (RdpeiClientContext*) args->pInterface;
+    RdpeiClientContext* rdpei = (RdpeiClientContext*) e->pInterface;
     guac_rdpei->rdpei = rdpei;
 
     /* Declare level of multi-touch support */
@@ -107,19 +107,19 @@ static void guac_rdp_rdpei_channel_connected(rdpContext* context,
  * @param context
  *     The rdpContext associated with the active RDP session.
  *
- * @param args
+ * @param e
  *     Event-specific arguments, mainly the name of the channel, and a
  *     reference to the associated plugin loaded for that channel by FreeRDP.
  */
 static void guac_rdp_rdpei_channel_disconnected(rdpContext* context,
-        ChannelDisconnectedEventArgs* args) {
+        ChannelDisconnectedEventArgs* e) {
 
     guac_client* client = ((rdp_freerdp_context*) context)->client;
     guac_rdp_client* rdp_client = (guac_rdp_client*) client->data;
     guac_rdp_rdpei* guac_rdpei = rdp_client->rdpei;
 
     /* Ignore disconnection event if it's not for the RDPEI channel */
-    if (strcmp(args->name, RDPEI_DVC_CHANNEL_NAME) != 0)
+    if (strcmp(e->name, RDPEI_DVC_CHANNEL_NAME) != 0)
         return;
 
     /* Channel is no longer connected */

src/protocols/rdp/channels/rdpei.h

@@ -110,7 +110,7 @@ void guac_rdp_rdpei_free(guac_rdp_rdpei* rdpei);
 /**
  * Adds FreeRDP's "rdpei" plugin to the list of dynamic virtual channel plugins
  * to be loaded by FreeRDP's "drdynvc" plugin. The context of the plugin will
- * automatically be associated with the guac_rdp_rdpei instance pointed to by the
+ * automatically be assicated with the guac_rdp_rdpei instance pointed to by the
  * current guac_rdp_client. The plugin will only be loaded once the "drdynvc"
  * plugin is loaded. The "rdpei" plugin ultimately adds support for multi-touch
  * input via the RDPEI channel.

src/protocols/rdp/channels/rdpgfx.c

@@ -1,122 +0,0 @@
-/*
- * Licensed to the Apache Software Foundation (ASF) under one
- * or more contributor license agreements.  See the NOTICE file
- * distributed with this work for additional information
- * regarding copyright ownership.  The ASF licenses this file
- * to you under the Apache License, Version 2.0 (the
- * "License"); you may not use this file except in compliance
- * with the License.  You may obtain a copy of the License at
- *
- *   http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing,
- * software distributed under the License is distributed on an
- * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
- * KIND, either express or implied.  See the License for the
- * specific language governing permissions and limitations
- * under the License.
- */
-
-#include "channels/rdpgfx.h"
-#include "plugins/channels.h"
-#include "rdp.h"
-#include "settings.h"
-
-#include <freerdp/client/rdpgfx.h>
-#include <freerdp/freerdp.h>
-#include <freerdp/gdi/gfx.h>
-#include <freerdp/event.h>
-#include <guacamole/client.h>
-
-#include <stdlib.h>
-#include <string.h>
-
-/**
- * Callback which associates handlers specific to Guacamole with the
- * RdpgfxClientContext instance allocated by FreeRDP to deal with received
- * RDPGFX (Graphics Pipeline) messages.
- *
- * This function is called whenever a channel connects via the PubSub event
- * system within FreeRDP, but only has any effect if the connected channel is
- * the RDPGFX channel. This specific callback is registered with the
- * PubSub system of the relevant rdpContext when guac_rdp_rdpgfx_load_plugin() is
- * called.
- *
- * @param context
- *     The rdpContext associated with the active RDP session.
- *
- * @param args
- *     Event-specific arguments, mainly the name of the channel, and a
- *     reference to the associated plugin loaded for that channel by FreeRDP.
- */
-static void guac_rdp_rdpgfx_channel_connected(rdpContext* context,
-        ChannelConnectedEventArgs* args) {
-
-    guac_client* client = ((rdp_freerdp_context*) context)->client;
-
-    /* Ignore connection event if it's not for the RDPGFX channel */
-    if (strcmp(args->name, RDPGFX_DVC_CHANNEL_NAME) != 0)
-        return;
-
-    /* Init GDI-backed support for the Graphics Pipeline */
-    RdpgfxClientContext* rdpgfx = (RdpgfxClientContext*) args->pInterface;
-    rdpGdi* gdi = context->gdi;
-
-    if (!gdi_graphics_pipeline_init(gdi, rdpgfx))
-        guac_client_log(client, GUAC_LOG_WARNING, "Rendering backend for RDPGFX "
-                "channel could not be loaded. Graphics may not render at all!");
-    else
-        guac_client_log(client, GUAC_LOG_DEBUG, "RDPGFX channel will be used for "
-                "the RDP Graphics Pipeline Extension.");
-
-}
-
-/**
- * Callback which handles any RDPGFX cleanup specific to Guacamole.
- *
- * This function is called whenever a channel disconnects via the PubSub event
- * system within FreeRDP, but only has any effect if the disconnected channel
- * is the RDPGFX channel. This specific callback is registered with the PubSub
- * system of the relevant rdpContext when guac_rdp_rdpgfx_load_plugin() is
- * called.
- *
- * @param context
- *     The rdpContext associated with the active RDP session.
- *
- * @param args
- *     Event-specific arguments, mainly the name of the channel, and a
- *     reference to the associated plugin loaded for that channel by FreeRDP.
- */
-static void guac_rdp_rdpgfx_channel_disconnected(rdpContext* context,
-        ChannelDisconnectedEventArgs* args) {
-
-    guac_client* client = ((rdp_freerdp_context*) context)->client;
-
-    /* Ignore disconnection event if it's not for the RDPGFX channel */
-    if (strcmp(args->name, RDPGFX_DVC_CHANNEL_NAME) != 0)
-        return;
-
-    /* Un-init GDI-backed support for the Graphics Pipeline */
-    RdpgfxClientContext* rdpgfx = (RdpgfxClientContext*) args->pInterface;
-    rdpGdi* gdi = context->gdi;
-    gdi_graphics_pipeline_uninit(gdi, rdpgfx);
-
-    guac_client_log(client, GUAC_LOG_DEBUG, "RDPGFX channel support unloaded.");
-
-}
-
-void guac_rdp_rdpgfx_load_plugin(rdpContext* context) {
-
-    /* Subscribe to and handle channel connected events */
-    PubSub_SubscribeChannelConnected(context->pubSub,
-        (pChannelConnectedEventHandler) guac_rdp_rdpgfx_channel_connected);
-
-    /* Subscribe to and handle channel disconnected events */
-    PubSub_SubscribeChannelDisconnected(context->pubSub,
-        (pChannelDisconnectedEventHandler) guac_rdp_rdpgfx_channel_disconnected);
-
-    /* Add "rdpgfx" channel */
-    guac_freerdp_dynamic_channel_collection_add(context->settings, "rdpgfx", NULL);
-
-}
-

src/protocols/rdp/channels/rdpuri.c

@@ -0,0 +1,133 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+#include "channels/rdpuri.h"
+#include "client.h"
+#include "config.h"
+#include "plugins/channels.h"
+#include "rdp.h"
+#include "unicode.h"
+
+#include <freerdp/client/cliprdr.h>
+#include <freerdp/event.h>
+#include <freerdp/freerdp.h>
+#include <guacamole/client.h>
+#include <guacamole/stream.h>
+#include <guacamole/user.h>
+#include <winpr/wtsapi.h>
+#include <winpr/wtypes.h>
+
+#include <assert.h>
+#include <stdlib.h>
+#include <string.h>
+
+/**
+ * Callback which associates handlers specific to Guacamole with the
+ * CliprdrClientContext instance allocated by FreeRDP to deal with received
+ * CLIPRDR (clipboard redirection) messages.
+ *
+ * This function is called whenever a channel connects via the PubSub event
+ * system within FreeRDP, but only has any effect if the connected channel is
+ * the CLIPRDR channel. This specific callback is registered with the PubSub
+ * system of the relevant rdpContext when guac_rdp_clipboard_load_plugin() is
+ * called.
+ *
+ * @param context
+ *     The rdpContext associated with the active RDP session.
+ *
+ * @param e
+ *     Event-specific arguments, mainly the name of the channel, and a
+ *     reference to the associated plugin loaded for that channel by FreeRDP.
+ */
+static void guac_rdpuri_channel_connected(guac_rdp_common_svc* svc) {
+
+    guac_client_log(svc->client, GUAC_LOG_DEBUG, "RDPURI (URI redirection) "
+            "channel connected.");
+
+}
+
+/**
+ * Callback which disassociates Guacamole from the CliprdrClientContext
+ * instance that was originally allocated by FreeRDP and is about to be
+ * deallocated.
+ *
+ * This function is called whenever a channel disconnects via the PubSub event
+ * system within FreeRDP, but only has any effect if the disconnected channel
+ * is the CLIPRDR channel. This specific callback is registered with the PubSub
+ * system of the relevant rdpContext when guac_rdp_clipboard_load_plugin() is
+ * called.
+ *
+ * @param context
+ *     The rdpContext associated with the active RDP session.
+ *
+ * @param e
+ *     Event-specific arguments, mainly the name of the channel, and a
+ *     reference to the associated plugin loaded for that channel by FreeRDP.
+ */
+static void guac_rdpuri_channel_disconnected(guac_rdp_common_svc* svc) {
+
+    guac_client_log(svc->client, GUAC_LOG_DEBUG, "RDPURI (URI redirection) "
+            "channel disconnected.");
+
+}
+
+static void guac_rdpuri_channel_receive(guac_rdp_common_svc* svc, wStream* input_stream) {
+    guac_client_log(svc->client, GUAC_LOG_DEBUG, "RDPURI (URI redirection) "
+            "channel received data.");
+
+    // int len = Stream_Length(input_stream);
+    int len = Stream_Length(input_stream);
+
+    guac_client_log(svc->client, GUAC_LOG_DEBUG, "Received URI %d in length.", len);
+
+    if (len < 1) {
+        guac_client_log(svc->client, GUAC_LOG_WARNING, "Received URI data is too "
+            "small.");
+        return;
+    }
+
+    /* Convert input stream to UTF8 and send it to the client. */
+    char uri[len/2];
+    guac_rdp_utf16_to_utf8(Stream_Pointer(input_stream), len/2 - 1, uri, sizeof(uri));
+    guac_client_log(svc->client, GUAC_LOG_DEBUG, "Received URI from server: %s", uri);
+    guac_client_owner_send_uri(svc->client, uri);
+
+}
+
+void guac_rdpuri_load_plugin(rdpContext* context) {
+
+    guac_client* client = ((rdp_freerdp_context*) context)->client;
+
+    /* Attempt to load FreeRDP support for the CLIPRDR channel */
+    if (guac_rdp_common_svc_load_plugin(context, "rdpuri", 0, 
+                guac_rdpuri_channel_connected, guac_rdpuri_channel_receive,
+                guac_rdpuri_channel_disconnected)) {
+        guac_client_log(client, GUAC_LOG_WARNING,
+                "Support for the RDPURI channel (URI redirection) "
+                "could not be loaded. This support normally takes the form of "
+                "a plugin which is built into FreeRDP. Lacking this support, "
+                "URI redirection will not work.");
+        return;
+    }
+
+    guac_client_log(client, GUAC_LOG_DEBUG, "Support for RDPURI "
+            "(URI redirection) registered. Awaiting channel "
+            "connection.");
+
+}

src/protocols/rdp/channels/rdpuri.h

@@ -17,33 +17,29 @@
  * under the License.
  */
 
-#ifndef GUAC_RDP_CHANNELS_RDPGFX_H
-#define GUAC_RDP_CHANNELS_RDPGFX_H
+#ifndef GUAC_RDP_CHANNELS_RDPURI_H
+#define GUAC_RDP_CHANNELS_RDPURI_H
 
-#include "settings.h"
+#include "channels/common-svc.h"
 
-#include <freerdp/client/rdpgfx.h>
 #include <freerdp/freerdp.h>
 #include <guacamole/client.h>
+#include <guacamole/user.h>
+#include <winpr/stream.h>
+#include <winpr/wtypes.h>
 
 /**
- * Adds FreeRDP's "rdpgfx" plugin to the list of dynamic virtual channel plugins
- * to be loaded by FreeRDP's "drdynvc" plugin. The context of the plugin will
- * automatically be associated with the guac_rdp_rdpgfx instance pointed to by the
- * current guac_rdp_client. The plugin will only be loaded once the "drdynvc"
- * plugin is loaded. The "rdpgfx" plugin ultimately adds support for the RDP
- * Graphics Pipeline Extension.
- *
+ * Initializes clipboard support for RDP and handling of the RDPURI channel.
  * If failures occur, messages noting the specifics of those failures will be
- * logged.
+ * logged, and the RDP side of URI redirection will not be functional.
  *
  * This MUST be called within the PreConnect callback of the freerdp instance
- * for Graphics Pipeline support to be loaded.
+ * for RDPURI support to be loaded.
  *
  * @param context
- *     The rdpContext associated with the active RDP session.
+ *     The rdpContext associated with the FreeRDP side of the RDP connection.
  */
-void guac_rdp_rdpgfx_load_plugin(rdpContext* context);
+void guac_rdpuri_load_plugin(rdpContext* context);
 
 #endif
 

src/protocols/rdp/download.c

@@ -30,7 +30,6 @@
 #include <guacamole/stream.h>
 #include <guacamole/string.h>
 #include <guacamole/user.h>
-#include <winpr/file.h>
 #include <winpr/nt.h>
 #include <winpr/shell.h>
 

src/protocols/rdp/gdi.c

@@ -26,7 +26,6 @@
 
 #include <cairo/cairo.h>
 #include <freerdp/freerdp.h>
-#include <freerdp/gdi/gdi.h>
 #include <freerdp/graphics.h>
 #include <freerdp/primary.h>
 #include <guacamole/client.h>
@@ -248,7 +247,7 @@ BOOL guac_rdp_gdi_memblt(rdpContext* context, MEMBLT_ORDER* memblt) {
     int x_src = memblt->nXSrc;
     int y_src = memblt->nYSrc;
 
-    /* Make sure that the received bitmap is not NULL before processing */
+    /* Make sure that the recieved bitmap is not NULL before processing */
     if (bitmap == NULL) {
         guac_client_log(client, GUAC_LOG_INFO, "NULL bitmap found in memblt instruction.");
         return TRUE;
@@ -372,110 +371,9 @@ BOOL guac_rdp_gdi_set_bounds(rdpContext* context, const rdpBounds* bounds) {
 
 }
 
-void guac_rdp_gdi_mark_frame(rdpContext* context, int starting) {
-
-    guac_client* client = ((rdp_freerdp_context*) context)->client;
-    guac_rdp_client* rdp_client = (guac_rdp_client*) client->data;
-
-    /* The server supports defining explicit frames */
-    rdp_client->frames_supported = 1;
-
-    /* A new frame is beginning */
-    if (starting) {
-        rdp_client->in_frame = 1;
-        return;
-    }
-
-    /* The current frame has ended */
-    guac_timestamp frame_end = guac_timestamp_current();
-    int time_elapsed = frame_end - client->last_sent_timestamp;
-    rdp_client->in_frame = 0;
-
-    /* A new frame has been received from the RDP server and processed */
-    rdp_client->frames_received++;
-
-    /* Flush a new frame if the client is ready for it */
-    if (time_elapsed >= guac_client_get_processing_lag(client)) {
-        guac_common_display_flush(rdp_client->display);
-        guac_client_end_multiple_frames(client, rdp_client->frames_received);
-        guac_socket_flush(client->socket);
-        rdp_client->frames_received = 0;
-    }
-
-}
-
-BOOL guac_rdp_gdi_frame_marker(rdpContext* context, const FRAME_MARKER_ORDER* frame_marker) {
-    guac_rdp_gdi_mark_frame(context, frame_marker->action == FRAME_START);
-    return TRUE;
-}
-
-BOOL guac_rdp_gdi_surface_frame_marker(rdpContext* context, const SURFACE_FRAME_MARKER* surface_frame_marker) {
-
-    guac_rdp_gdi_mark_frame(context, surface_frame_marker->frameAction == SURFACECMD_FRAMEACTION_END);
-
-    if (context->settings->FrameAcknowledge > 0)
-        IFCALL(context->update->SurfaceFrameAcknowledge, context,
-                surface_frame_marker->frameId);
-
-    return TRUE;
-
-}
-
-BOOL guac_rdp_gdi_begin_paint(rdpContext* context) {
-
-    guac_client* client = ((rdp_freerdp_context*) context)->client;
-    guac_rdp_client* rdp_client = (guac_rdp_client*) client->data;
-
-    /* Leverage BeginPaint handler to detect start of frame for RDPGFX channel */
-    if (rdp_client->settings->enable_gfx && rdp_client->frames_supported)
-        guac_rdp_gdi_mark_frame(context, 1);
-
-    return TRUE;
-
-}
-
 BOOL guac_rdp_gdi_end_paint(rdpContext* context) {
-
-    guac_client* client = ((rdp_freerdp_context*) context)->client;
-    guac_rdp_client* rdp_client = (guac_rdp_client*) client->data;
-    rdpGdi* gdi = context->gdi;
-
-    /* Ignore EndPaint handler unless needed to detect end of frame for RDPGFX
-     * channel */
-    if (!rdp_client->settings->enable_gfx)
+    /* IGNORE */
     return TRUE;
-
-    /* Ignore paint if GDI output is suppressed */
-    if (gdi->suppressOutput)
-        return TRUE;
-
-    /* Ignore paint if nothing has been done (empty rect) */
-    if (gdi->primary->hdc->hwnd->invalid->null)
-        return TRUE;
-
-    INT32 x = gdi->primary->hdc->hwnd->invalid->x;
-    INT32 y = gdi->primary->hdc->hwnd->invalid->y;
-    UINT32 w = gdi->primary->hdc->hwnd->invalid->w;
-    UINT32 h = gdi->primary->hdc->hwnd->invalid->h;
-
-    /* Create surface from image data */
-    cairo_surface_t* surface = cairo_image_surface_create_for_data(
-        gdi->primary_buffer + 4*x + y*gdi->stride,
-        CAIRO_FORMAT_RGB24, w, h, gdi->stride);
-
-    /* Send surface to buffer */
-    guac_common_surface_draw(rdp_client->display->default_surface, x, y, surface);
-
-    /* Free surface */
-    cairo_surface_destroy(surface);
-
-    /* Next frame */
-    if (gdi->inGfxFrame) {
-        guac_rdp_gdi_mark_frame(context, 0);
-    }
-
-    return TRUE;
-
 }
 
 BOOL guac_rdp_gdi_desktop_resize(rdpContext* context) {
@@ -493,8 +391,7 @@ BOOL guac_rdp_gdi_desktop_resize(rdpContext* context) {
             guac_rdp_get_width(context->instance),
             guac_rdp_get_height(context->instance));
 
-    return gdi_resize(context->gdi, guac_rdp_get_width(context->instance),
-            guac_rdp_get_height(context->instance));
+    return TRUE;
 
 }
 

src/protocols/rdp/gdi.h

@@ -156,68 +156,8 @@ BOOL guac_rdp_gdi_opaquerect(rdpContext* context,
 BOOL guac_rdp_gdi_set_bounds(rdpContext* context, const rdpBounds* bounds);
 
 /**
- * Notifies the internal GDI implementation that a frame is either starting or
- * ending. If the frame is ending and the connected client is ready to receive
- * a new frame, a new frame will be flushed to the client.
- *
- * @param context
- *     The rdpContext associated with the current RDP session.
- *
- * @param starting
- *     Non-zero if the frame in question is starting, zero if the frame is
- *     ending.
- */
-void guac_rdp_gdi_mark_frame(rdpContext* context, int starting);
-
-/**
- * Handler called when a frame boundary is received from the RDP server in the
- * form of a frame marker command. Each frame boundary may be the beginning or
- * the end of a frame.
- *
- * @param context
- *     The rdpContext associated with the current RDP session.
- *
- * @param frame_marker
- *     The received frame marker.
- *
- * @return
- *     TRUE if successful, FALSE otherwise.
- */
-BOOL guac_rdp_gdi_frame_marker(rdpContext* context, const FRAME_MARKER_ORDER* frame_marker);
-
-/**
- * Handler called when a frame boundary is received from the RDP server in the
- * form of a surface frame marker. Each frame boundary may be the beginning or
- * the end of a frame.
- *
- * @param context
- *     The rdpContext associated with the current RDP session.
- *
- * @param surface_frame_marker
- *     The received frame marker.
- *
- * @return
- *     TRUE if successful, FALSE otherwise.
- */
-BOOL guac_rdp_gdi_surface_frame_marker(rdpContext* context, const SURFACE_FRAME_MARKER* surface_frame_marker);
-
-/**
- * Handler called when a paint operation is beginning. This function is
- * expected to be called by the FreeRDP GDI implementation of RemoteFX when a
- * new frame has started.
- *
- * @param context
- *     The rdpContext associated with the current RDP session.
- *
- * @return
- *     TRUE if successful, FALSE otherwise.
- */
-BOOL guac_rdp_gdi_begin_paint(rdpContext* context);
-
-/**
- * Handler called when a paint operation is complete. This function is
- * expected to be called by the FreeRDP GDI implementation of RemoteFX when a
- * new frame has been completed.
+ * Handler called when a paint operation is complete. We don't actually
+ * use this, but FreeRDP requires it. Calling this function has no effect.
  *
  * @param context
  *     The rdpContext associated with the current RDP session.

src/protocols/rdp/glyph.h

@@ -96,11 +96,11 @@ BOOL guac_rdp_glyph_new(rdpContext* context, const rdpGlyph* glyph);
  *     The height of the glyph being drawn.
  *
  * @param sx
- *     The X coordinate of the upper-left corner of the glyph within the source
+ *     The X coordinare of the upper-left corner of the glyph within the source
  *     cache surface containing the glyph.
  *
  * @param sy
- *     The Y coordinate of the upper-left corner of the glyph within the source
+ *     The Y coordinare of the upper-left corner of the glyph within the source
  *     cache surface containing the glyph.
  *
  * @param redundant

src/protocols/rdp/keyboard.c

@@ -140,7 +140,7 @@ static void guac_rdp_send_unicode_event(guac_rdp_client* rdp_client,
 }
 
 /**
- * Immediately sends an RDP synchronize event having the given flags. An RDP
+ * Immediately sends an RDP synchonize event having the given flags. An RDP
  * synchronize event sets the state of remote lock keys absolutely, where a
  * lock key will be active only if its corresponding flag is set in the event.
  *

src/protocols/rdp/keymaps/cs-cz-qwertz.keymap

@@ -1,79 +0,0 @@
-#
-# Licensed to the Apache Software Foundation (ASF) under one
-# or more contributor license agreements.  See the NOTICE file
-# distributed with this work for additional information
-# regarding copyright ownership.  The ASF licenses this file
-# to you under the Apache License, Version 2.0 (the
-# "License"); you may not use this file except in compliance
-# with the License.  You may obtain a copy of the License at
-#
-#   http://www.apache.org/licenses/LICENSE-2.0
-#
-# Unless required by applicable law or agreed to in writing,
-# software distributed under the License is distributed on an
-# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
-# KIND, either express or implied.  See the License for the
-# specific language governing permissions and limitations
-# under the License.
-#
-
-parent  "base"
-name    "cs-cz-qwertz"
-freerdp "KBD_CZECH"
-
-#
-# Basic keys
-#
-
-map -caps -altgr -shift 0x29 0x02..0x0D      ~ ";+ěščřžýáíé=´"
-map -caps -altgr -shift      0x10..0x1B      ~ "qwertzuıopú)"
-map -caps -altgr -shift      0x1E..0x28 0x2B ~ "asdfghjklů§¨"
-map -caps -altgr -shift      0x2C..0x35      ~ "yxcvbnm,.-"
-
-map -caps -altgr +shift 0x29 0x02..0x0D      ~ "°1234567890%ˇ"
-map -caps -altgr +shift      0x10..0x1B      ~ "QWERTZUIOP/("
-map -caps -altgr +shift      0x1E..0x28 0x2B ~ "ASDFGHJKL"!'"
-map -caps -altgr +shift      0x2C..0x35      ~ "YXCVBNM?:_"
-
-map +caps -altgr -shift 0x29 0x02..0x0D      ~ ";+ĚŠČŘŽÝÁÍÉ=´"
-map +caps -altgr -shift      0x10..0x1B      ~ "QWERTZUIOPÚ)"
-map +caps -altgr -shift      0x1E..0x28 0x2B ~ "ASDFGHJKL٧¨"
-map +caps -altgr -shift      0x2C..0x35      ~ "YXCVBNM,.-"
-
-map +caps -altgr +shift 0x29 0x02..0x0D      ~ "°1234567890%ˇ"
-map +caps -altgr +shift      0x10..0x1B      ~ "qwertzuiop/("
-map +caps -altgr +shift      0x1E..0x28 0x2B ~ "asdfghjkl"!'"
-map +caps -altgr +shift      0x2C..0x35      ~ "yxcvbnm?:_"
-
-#
-# Keys requiring AltGr
-#
-
-map +altgr -shift 0x02 ~ "~"
-
-map +altgr -shift 0x10 ~ "\"
-map +altgr -shift 0x11 ~ "|"
-map +altgr -shift 0x12 ~ "€"
-map +altgr -shift 0x1A ~ "÷"
-map +altgr -shift 0x1B ~ "×"
-
-map +altgr -shift 0x1F ~ "đ"
-map +altgr -shift 0x20 ~ "Đ"
-map +altgr -shift 0x21 ~ "["
-map +altgr -shift 0x22 ~ "]"
-map +altgr -shift 0x25 ~ "ł"
-map +altgr -shift 0x26 ~ "Ł"
-map +altgr -shift 0x27 ~ "$"
-map +altgr -shift 0x28 ~ "ß"
-map +altgr -shift 0x2B ~ "¤"
-
-map +altgr -shift 0x2D ~ "#"
-map +altgr -shift 0x2E ~ "&"
-map +altgr -shift 0x2F ~ "@"
-map +altgr -shift 0x30 ~ "{"
-map +altgr -shift 0x31 ~ "}"
-map +altgr -shift 0x33 ~ "<"
-map +altgr -shift 0x34 ~ ">"
-map +altgr -shift 0x35 ~ "*"
-
-# END

src/protocols/rdp/ls.c

@@ -25,7 +25,6 @@
 #include <guacamole/socket.h>
 #include <guacamole/stream.h>
 #include <guacamole/user.h>
-#include <winpr/file.h>
 #include <winpr/nt.h>
 #include <winpr/shell.h>
 

src/protocols/rdp/plugins/guacai/guacai-messages.c

@@ -251,7 +251,7 @@ void guac_rdp_ai_process_version(guac_client* client,
 
     /* Verify we have at least 4 bytes available (UINT32) */
     if (Stream_GetRemainingLength(stream) < 4) {
-        guac_client_log(client, GUAC_LOG_WARNING, "Audio input Version PDU "
+        guac_client_log(client, GUAC_LOG_WARNING, "Audio input Versoin PDU "
                 "does not contain the expected number of bytes. Audio input "
                 "redirection may not work as expected.");
         return;

src/protocols/rdp/pointer.c

@@ -21,7 +21,6 @@
 #include "common/cursor.h"
 #include "common/display.h"
 #include "common/surface.h"
-#include "gdi.h"
 #include "pointer.h"
 #include "rdp.h"
 
@@ -79,22 +78,11 @@ BOOL guac_rdp_pointer_set(rdpContext* context, const rdpPointer* pointer) {
     guac_client* client = ((rdp_freerdp_context*) context)->client;
     guac_rdp_client* rdp_client = (guac_rdp_client*) client->data;
 
-    /* Add explicit frame boundaries around cursor set operation if not already
-     * in a frame (the RDP protocol does not send nor expect frame boundaries
-     * for cursor changes, but Guacamole does expect this) */
-    int in_frame = rdp_client->in_frame;
-
-    if (rdp_client->frames_supported && !in_frame)
-        guac_rdp_gdi_mark_frame(context, 1);
-
     /* Set cursor */
     guac_common_cursor_set_surface(rdp_client->display->cursor,
             pointer->xPos, pointer->yPos,
             ((guac_rdp_pointer*) pointer)->layer->surface);
 
-    if (rdp_client->frames_supported && !in_frame)
-        guac_rdp_gdi_mark_frame(context, 0);
-
     return TRUE;
 
 }
@@ -118,20 +106,9 @@ BOOL guac_rdp_pointer_set_null(rdpContext* context) {
     guac_client* client = ((rdp_freerdp_context*) context)->client;
     guac_rdp_client* rdp_client = (guac_rdp_client*) client->data;
 
-    /* Add explicit frame boundaries around cursor set operation if not already
-     * in a frame (the RDP protocol does not send nor expect frame boundaries
-     * for cursor changes, but Guacamole does expect this) */
-    int in_frame = rdp_client->in_frame;
-
-    if (rdp_client->frames_supported && !in_frame)
-        guac_rdp_gdi_mark_frame(context, 1);
-
     /* Set cursor to empty/blank graphic */
     guac_common_cursor_set_blank(rdp_client->display->cursor);
 
-    if (rdp_client->frames_supported && !in_frame)
-        guac_rdp_gdi_mark_frame(context, 0);
-
     return TRUE;
 
 }
@@ -141,20 +118,9 @@ BOOL guac_rdp_pointer_set_default(rdpContext* context) {
     guac_client* client = ((rdp_freerdp_context*) context)->client;
     guac_rdp_client* rdp_client = (guac_rdp_client*) client->data;
 
-    /* Add explicit frame boundaries around cursor set operation if not already
-     * in a frame (the RDP protocol does not send nor expect frame boundaries
-     * for cursor changes, but Guacamole does expect this) */
-    int in_frame = rdp_client->in_frame;
-
-    if (rdp_client->frames_supported && !in_frame)
-        guac_rdp_gdi_mark_frame(context, 1);
-
     /* Set cursor to embedded pointer */
     guac_common_cursor_set_pointer(rdp_client->display->cursor);
 
-    if (rdp_client->frames_supported && !in_frame)
-        guac_rdp_gdi_mark_frame(context, 0);
-
     return TRUE;
 }
 

src/protocols/rdp/rdp.c

@@ -28,8 +28,8 @@
 #include "channels/rail.h"
 #include "channels/rdpdr/rdpdr.h"
 #include "channels/rdpei.h"
-#include "channels/rdpgfx.h"
 #include "channels/rdpsnd/rdpsnd.h"
+#include "channels/rdpuri.h"
 #include "client.h"
 #include "color.h"
 #include "common/cursor.h"
@@ -124,6 +124,9 @@ BOOL rdp_freerdp_pre_connect(freerdp* instance) {
         guac_rdpsnd_load_plugin(context);
     }
 
+    /* Load rdpuri service */
+    guac_rdpuri_load_plugin(context);
+
     /* Load RAIL plugin if RemoteApp in use */
     if (settings->remote_app != NULL)
         guac_rdp_rail_load_plugin(context);
@@ -138,6 +141,15 @@ BOOL rdp_freerdp_pre_connect(freerdp* instance) {
 
     }
 
+    /* Load plugin providing Dynamic Virtual Channel support, if required */
+    if (instance->settings->SupportDynamicChannels &&
+            guac_freerdp_channels_load_plugin(context, "drdynvc",
+                instance->settings)) {
+        guac_client_log(client, GUAC_LOG_WARNING,
+                "Failed to load drdynvc plugin. Display update and audio "
+                "input support will be disabled.");
+    }
+
     /* Init FreeRDP internal GDI implementation */
     if (!gdi_init(instance, guac_rdp_get_native_pixel_format(FALSE)))
         return FALSE;
@@ -179,13 +191,9 @@ BOOL rdp_freerdp_pre_connect(freerdp* instance) {
 
     /* Set up GDI */
     instance->update->DesktopResize = guac_rdp_gdi_desktop_resize;
-    instance->update->BeginPaint = guac_rdp_gdi_begin_paint;
     instance->update->EndPaint = guac_rdp_gdi_end_paint;
     instance->update->SetBounds = guac_rdp_gdi_set_bounds;
 
-    instance->update->SurfaceFrameMarker = guac_rdp_gdi_surface_frame_marker;
-    instance->update->altsec->FrameMarker = guac_rdp_gdi_frame_marker;
-
     rdpPrimaryUpdate* primary = instance->update->primary;
     primary->DstBlt = guac_rdp_gdi_dstblt;
     primary->PatBlt = guac_rdp_gdi_patblt;
@@ -200,19 +208,6 @@ BOOL rdp_freerdp_pre_connect(freerdp* instance) {
     offscreen_cache_register_callbacks(instance->update);
     palette_cache_register_callbacks(instance->update);
 
-    /* Load "rdpgfx" plugin for Graphics Pipeline Extension */
-    if (settings->enable_gfx)
-        guac_rdp_rdpgfx_load_plugin(context);
-
-    /* Load plugin providing Dynamic Virtual Channel support, if required */
-    if (instance->settings->SupportDynamicChannels &&
-            guac_freerdp_channels_load_plugin(context, "drdynvc",
-                instance->settings)) {
-        guac_client_log(client, GUAC_LOG_WARNING,
-                "Failed to load drdynvc plugin. Display update and audio "
-                "input support will be disabled.");
-    }
-
     return TRUE;
 
 }
@@ -553,6 +548,7 @@ static int guac_rdp_handle_connection(guac_client* client) {
         if (wait_result > 0) {
 
             int processing_lag = guac_client_get_processing_lag(client);
+            guac_timestamp frame_start = guac_timestamp_current();
 
             /* Read server messages until frame is built */
             do {
@@ -572,15 +568,7 @@ static int guac_rdp_handle_connection(guac_client* client) {
                     break;
                 }
 
-                /* Continue handling inbound data if we are in the middle of an RDP frame */
-                if (rdp_client->in_frame) {
-                    wait_result = rdp_guac_client_wait_for_messages(client, GUAC_RDP_FRAME_START_TIMEOUT);
-                    if (wait_result >= 0)
-                        continue;
-                }
-
                 /* Calculate time remaining in frame */
-                guac_timestamp frame_start = client->last_sent_timestamp;
                 frame_end = guac_timestamp_current();
                 frame_remaining = frame_start + GUAC_RDP_FRAME_DURATION
                                 - frame_end;
@@ -603,6 +591,12 @@ static int guac_rdp_handle_connection(guac_client* client) {
 
             } while (wait_result > 0);
 
+            /* Record end of frame, excluding server-side rendering time (we
+             * assume server-side rendering time will be consistent between any
+             * two subsequent frames, and that this time should thus be
+             * excluded from the required wait period of the next frame). */
+            last_frame_end = frame_start;
+
         }
 
         /* Test whether the RDP server is closing the connection */
@@ -617,13 +611,11 @@ static int guac_rdp_handle_connection(guac_client* client) {
             guac_client_abort(client, GUAC_PROTOCOL_STATUS_UPSTREAM_UNAVAILABLE,
                     "Connection closed.");
 
-        /* Flush frame only if successful and an RDP frame is not known to be
-         * in progress */
-        else if (!rdp_client->frames_supported || rdp_client->frames_received) {
+        /* Flush frame only if successful */
+        else {
             guac_common_display_flush(rdp_client->display);
-            guac_client_end_multiple_frames(client, rdp_client->frames_received);
+            guac_client_end_frame(client);
             guac_socket_flush(client->socket);
-            rdp_client->frames_received = 0;
         }
 
     }

src/protocols/rdp/rdp.h

@@ -91,24 +91,6 @@ typedef struct guac_rdp_client {
      */
     guac_common_surface* current_surface;
 
-    /**
-     * Whether the RDP server supports defining explicit frame boundaries.
-     */
-    int frames_supported;
-
-    /**
-     * Whether the RDP server has reported that a new frame is in progress, and
-     * we are now receiving updates relevant to that frame.
-     */
-    int in_frame;
-
-    /**
-     * The number of distinct frames received from the RDP server since last
-     * flush, if the RDP server supports reporting frame boundaries. If the RDP
-     * server does not support tracking frames, this will be zero.
-     */
-    int frames_received;
-
     /**
      * The current state of the keyboard with respect to the RDP session.
      */

src/protocols/rdp/settings.c

@@ -28,7 +28,6 @@
 #include <freerdp/settings.h>
 #include <freerdp/freerdp.h>
 #include <guacamole/client.h>
-#include <guacamole/fips.h>
 #include <guacamole/string.h>
 #include <guacamole/user.h>
 #include <guacamole/wol-constants.h>
@@ -40,16 +39,6 @@
 #include <stdlib.h>
 #include <string.h>
 
-/**
- * A warning to log when NLA mode is selected while FIPS mode is active on the
- * guacd server.
- */
-const char fips_nla_mode_warning[] = (
-        "NLA security mode was selected, but is known to be currently incompatible "
-        "with FIPS mode (see FreeRDP/FreeRDP#3412). Security negotiation with the "
-        "RDP server may fail unless TLS security mode is selected instead."
-);
-
 /* Client plugin arguments */
 const char* GUAC_RDP_CLIENT_ARGS[] = {
     "hostname",
@@ -91,7 +80,6 @@ const char* GUAC_RDP_CLIENT_ARGS[] = {
     "disable-bitmap-caching",
     "disable-offscreen-caching",
     "disable-glyph-caching",
-    "disable-gfx",
     "preconnection-id",
     "preconnection-blob",
     "timezone",
@@ -372,7 +360,7 @@ enum RDP_ARGS_IDX {
     IDX_DISABLE_BITMAP_CACHING,
 
     /**
-     * "true" if the offscreen caching should be disabled, false if offscreen
+     * "true" if the offscreen caching should be disabled, false if offscren
      * caching should remain enabled.
      */
     IDX_DISABLE_OFFSCREEN_CACHING,
@@ -383,13 +371,6 @@ enum RDP_ARGS_IDX {
      */
     IDX_DISABLE_GLYPH_CACHING,
 
-    /**
-     * "true" if the RDP Graphics Pipeline Extension should not be used, and
-     * traditional RDP graphics should be used instead, "false" or blank if the
-     * Graphics Pipeline Extension should be used if available.
-     */
-    IDX_DISABLE_GFX,
-
     /**
      * The preconnection ID to send within the preconnection PDU when
      * initiating an RDP connection, if any.
@@ -717,27 +698,12 @@ guac_rdp_settings* guac_rdp_parse_args(guac_user* user,
     if (strcmp(argv[IDX_SECURITY], "nla") == 0) {
         guac_user_log(user, GUAC_LOG_INFO, "Security mode: NLA");
         settings->security_mode = GUAC_SECURITY_NLA;
-
-        /*
-         * NLA is known not to work with FIPS; allow the mode selection but
-         * warn that it will not work.
-         */
-        if (guac_fips_enabled())
-            guac_user_log(user, GUAC_LOG_WARNING, fips_nla_mode_warning);
-
     }
 
     /* Extended NLA security */
     else if (strcmp(argv[IDX_SECURITY], "nla-ext") == 0) {
         guac_user_log(user, GUAC_LOG_INFO, "Security mode: Extended NLA");
         settings->security_mode = GUAC_SECURITY_EXTENDED_NLA;
-
-        /*
-         * NLA is known not to work with FIPS; allow the mode selection but
-         * warn that it will not work.
-         */
-        if (guac_fips_enabled())
-            guac_user_log(user, GUAC_LOG_WARNING, fips_nla_mode_warning);
     }
 
     /* TLS security */
@@ -942,6 +908,11 @@ guac_rdp_settings* guac_rdp_parse_args(guac_user* user,
                 GUAC_RDP_CLIENT_ARGS[IDX_DISABLE_GLYPH_CACHING]);
     }
 
+    /* Session color depth */
+    settings->color_depth = 
+        guac_user_parse_args_int(user, GUAC_RDP_CLIENT_ARGS, argv,
+                IDX_COLOR_DEPTH, RDP_DEFAULT_DEPTH);
+
     /* Preconnection ID */
     settings->preconnection_id = -1;
     if (argv[IDX_PRECONNECTION_ID][0] != '\0') {
@@ -1158,16 +1129,6 @@ guac_rdp_settings* guac_rdp_parse_args(guac_user* user,
         settings->resize_method = GUAC_RESIZE_NONE;
     }
 
-    /* RDP Graphics Pipeline enable/disable */
-    settings->enable_gfx =
-        !guac_user_parse_args_boolean(user, GUAC_RDP_CLIENT_ARGS, argv,
-                IDX_DISABLE_GFX, 0);
-
-    /* Session color depth */
-    settings->color_depth =
-        guac_user_parse_args_int(user, GUAC_RDP_CLIENT_ARGS, argv,
-                IDX_COLOR_DEPTH, settings->enable_gfx ? RDP_GFX_REQUIRED_DEPTH : RDP_DEFAULT_DEPTH);
-
     /* Multi-touch input enable/disable */
     settings->enable_touch =
         guac_user_parse_args_boolean(user, GUAC_RDP_CLIENT_ARGS, argv,
@@ -1436,29 +1397,6 @@ void guac_rdp_push_settings(guac_client* client,
     /* Explicitly set flag value */
     rdp_settings->PerformanceFlags = guac_rdp_get_performance_flags(guac_settings);
 
-    /* Always request frame markers */
-    rdp_settings->FrameMarkerCommandEnabled = TRUE;
-    rdp_settings->SurfaceFrameMarkerEnabled = TRUE;
-
-    /* Enable RemoteFX / Graphics Pipeline */
-    if (guac_settings->enable_gfx) {
-
-        rdp_settings->SupportGraphicsPipeline = TRUE;
-        rdp_settings->RemoteFxCodec = TRUE;
-
-        if (rdp_settings->ColorDepth != RDP_GFX_REQUIRED_DEPTH) {
-            guac_client_log(client, GUAC_LOG_WARNING, "Ignoring requested "
-                    "color depth of %i bpp, as the RDP Graphics Pipeline "
-                    "requires %i bpp.", rdp_settings->ColorDepth, RDP_GFX_REQUIRED_DEPTH);
-        }
-
-        /* Required for RemoteFX / Graphics Pipeline */
-        rdp_settings->FastPathOutput = TRUE;
-        rdp_settings->ColorDepth = RDP_GFX_REQUIRED_DEPTH;
-        rdp_settings->SoftwareGdi = TRUE;
-
-    }
-
     /* Set individual flags - some FreeRDP versions overwrite the above */
     rdp_settings->AllowFontSmoothing = guac_settings->font_smoothing_enabled;
     rdp_settings->DisableWallpaper = !guac_settings->wallpaper_enabled;
@@ -1555,21 +1493,7 @@ void guac_rdp_push_settings(guac_client* client,
         case GUAC_SECURITY_ANY:
             rdp_settings->RdpSecurity = TRUE;
             rdp_settings->TlsSecurity = TRUE;
-
-            /* Explicitly disable NLA if FIPS mode is enabled - it won't work */
-            if (guac_fips_enabled()) {
-
-                guac_client_log(client, GUAC_LOG_INFO,
-                        "FIPS mode is enabled. Excluding NLA security mode from security negotiation "
-                        "(see: https://github.com/FreeRDP/FreeRDP/issues/3412).");
-                rdp_settings->NlaSecurity = FALSE;
-
-            }
-
-            /* NLA mode is allowed if FIPS is not enabled */
-            else
-                rdp_settings->NlaSecurity = TRUE;
-
+            rdp_settings->NlaSecurity = guac_settings->username && guac_settings->password;
             rdp_settings->ExtSecurity = FALSE;
             break;
 

src/protocols/rdp/settings.h

@@ -58,11 +58,6 @@
  */
 #define RDP_DEFAULT_DEPTH  16 
 
-/**
- * The color depth required by the RDPGFX channel, in bits.
- */
-#define RDP_GFX_REQUIRED_DEPTH 32
-
 /**
  * The filename to use for the screen recording, if not specified.
  */
@@ -557,11 +552,6 @@ typedef struct guac_rdp_settings {
      */
     int enable_audio_input;
 
-    /**
-     * Whether the RDP Graphics Pipeline Extension is enabled.
-     */
-    int enable_gfx;
-
     /**
      * Whether multi-touch support is enabled.
      */

src/terminal/Makefile.am

@@ -77,8 +77,6 @@ libguac_terminal_la_LIBADD = \
     @LIBGUAC_LTLIB@
 
 libguac_terminal_la_LDFLAGS = \
-    -version-info 0:0:0       \
-    -no-undefined             \
     @CAIRO_LIBS@              \
     @MATH_LIBS@               \
     @PANGO_LIBS@              \

src/terminal/display.c

@@ -202,19 +202,6 @@ int __guac_terminal_set(guac_terminal_display* display, int row, int col, int co
 
 }
 
-/**
- * Calculate the size of margins around the terminal based on DPI.
- *
- * @param dpi
- *     The resolution of the display in DPI.
- *
- * @return
- *     Calculated size of margin in pixels.
- */
-static int get_margin_by_dpi(int dpi) {
-    return dpi * GUAC_TERMINAL_MARGINS / GUAC_TERMINAL_MM_PER_INCH;
-}
-
 guac_terminal_display* guac_terminal_display_alloc(guac_client* client,
         const char* font_name, int font_size, int dpi,
         guac_terminal_color* foreground, guac_terminal_color* background,
@@ -242,13 +229,6 @@ guac_terminal_display* guac_terminal_display_alloc(guac_client* client,
     guac_protocol_send_move(client->socket, display->select_layer,
             display->display_layer, 0, 0, 0);
 
-    /* Calculate margin size by DPI */
-    display->margin = get_margin_by_dpi(dpi);
-
-    /* Offset the Default Layer to make margins even on all sides */
-    guac_protocol_send_move(client->socket, display->display_layer,
-        GUAC_DEFAULT_LAYER, display->margin, display->margin, 0);
-
     display->default_foreground = display->glyph_foreground = *foreground;
     display->default_background = display->glyph_background = *background;
     display->default_palette = palette;
@@ -467,10 +447,6 @@ void guac_terminal_display_set_columns(guac_terminal_display* display, int row,
 
 void guac_terminal_display_resize(guac_terminal_display* display, int width, int height) {
 
-    /* Resize display only if dimensions have changed */
-    if (width == display->width && height == display->height)
-        return;
-
     guac_terminal_operation* current;
     int x, y;
 
@@ -852,10 +828,6 @@ void guac_terminal_display_dup(guac_terminal_display* display, guac_user* user,
     guac_protocol_send_move(socket, display->select_layer,
             display->display_layer, 0, 0, 0);
 
-    /* Offset the Default Layer to make margins even on all sides */
-    guac_protocol_send_move(socket, display->display_layer,
-        GUAC_DEFAULT_LAYER, display->margin, display->margin, 0);
-
     /* Send select layer size */
     guac_protocol_send_size(socket, display->select_layer,
             display->char_width  * display->width,
@@ -1048,7 +1020,7 @@ int guac_terminal_display_set_font(guac_terminal_display* display,
     if (new_width != display->width || new_height != display->height)
         guac_terminal_display_resize(display, new_width, new_height);
 
-
     return 0;
 
 }
+

src/terminal/terminal.c

@@ -20,7 +20,6 @@
 
 #include "common/clipboard.h"
 #include "common/cursor.h"
-#include "common/iconv.h"
 #include "terminal/buffer.h"
 #include "terminal/color-scheme.h"
 #include "terminal/common.h"
@@ -336,97 +335,6 @@ guac_terminal_options* guac_terminal_options_create(
     return options;
 }
 
-/**
- * Calculate the available height and width in characters for text display in 
- * the terminal and store the results in the pointer arguments.
- *
- * @param terminal
- *     The terminal provides character width and height for calculations.
- * 
- * @param height
- *     The outer height of the terminal, in pixels.
- * 
- * @param width
- *     The outer width of the terminal, in pixels.
- * 
- * @param rows
- *     Pointer to the calculated height of the terminal for text display,
- *     in characters.
- * 
- * @param columns
- *     Pointer to the calculated width of the terminal for text display,
- *     in characters.
- */
-static void calculate_rows_and_columns(guac_terminal* term,
-    int height, int width, int *rows, int *columns) {
-
-    int margin = term->display->margin;
-    int char_width = term->display->char_width;
-    int char_height = term->display->char_height;
-    
-    /* Calculate available display area */
-    int available_width = width - GUAC_TERMINAL_SCROLLBAR_WIDTH - 2 * margin;
-    if (available_width < 0)
-        available_width = 0;
-
-    int available_height = height - 2 * margin;
-    if (available_height < 0)
-        available_height = 0;
-
-    /* Calculate dimensions */
-    *rows    = available_height / char_height;
-    *columns = available_width / char_width;
-
-    /* Keep height within predefined maximum */
-    if (*rows > GUAC_TERMINAL_MAX_ROWS)
-        *rows = GUAC_TERMINAL_MAX_ROWS;
-
-    /* Keep width within predefined maximum */
-    if (*columns > GUAC_TERMINAL_MAX_COLUMNS)
-        *columns = GUAC_TERMINAL_MAX_COLUMNS;
-}
-
-/**
- * Calculate the available height and width in pixels of the terminal for text 
- * display in the terminal and store the results in the pointer arguments.
- *
- * @param terminal
- *     The terminal provides character width and height for calculations.
- * 
- * @param rows
- *     The available height of the terminal for text display, in characters.
- * 
- * @param columns
- *     The available width of the terminal for text display, in characters.
- *
- * @param height
- *     Pointer to the calculated available height of the terminal for text 
- *     display, in pixels.
- * 
- * @param width
- *     Pointer to the calculated available width of the terminal for text 
- *     display, in pixels.
- */
-static void calculate_height_and_width(guac_terminal* term,
-    int rows, int columns, int *height, int *width) {
-
-    int margin = term->display->margin;
-    int char_width = term->display->char_width;
-    int char_height = term->display->char_height;
-
-    /* Recalculate height if max rows reached */
-    if (rows == GUAC_TERMINAL_MAX_ROWS) {
-        int available_height = GUAC_TERMINAL_MAX_ROWS * char_height;
-        *height = available_height + 2 * margin;
-    }
-
-    /* Recalculate width if max columns reached */
-    if (columns == GUAC_TERMINAL_MAX_COLUMNS) {
-        int available_width = GUAC_TERMINAL_MAX_COLUMNS * char_width;
-        *width = available_width + GUAC_TERMINAL_SCROLLBAR_WIDTH + 2 * margin;
-    }
-}
-
 guac_terminal* guac_terminal_create(guac_client* client,
         guac_terminal_options* options) {
 
@@ -455,6 +363,11 @@ guac_terminal* guac_terminal_create(guac_client* client,
                                      &default_char.attributes.background,
                                      default_palette);
 
+    /* Calculate available display area */
+    int available_width = width - GUAC_TERMINAL_SCROLLBAR_WIDTH;
+    if (available_width < 0)
+        available_width = 0;
+
     guac_terminal* term = malloc(sizeof(guac_terminal));
     term->started = false;
     term->client = client;
@@ -466,6 +379,10 @@ guac_terminal* guac_terminal_create(guac_client* client,
     term->font_name = strdup(options->font_name);
     term->font_size = options->font_size;
 
+    /* Set size of available screen area */
+    term->outer_width = width;
+    term->outer_height = height;
+
     /* Init modified flag and conditional */
     term->modified = 0;
     pthread_cond_init(&(term->modified_cond), NULL);
@@ -508,27 +425,29 @@ guac_terminal* guac_terminal_create(guac_client* client,
     term->clipboard = guac_common_clipboard_alloc();
     term->disable_copy = options->disable_copy;
 
-    /* Calculate available text display area by character size */
-    int rows, columns;
-    calculate_rows_and_columns(term, height, width, &rows, &columns);
+    /* Calculate character size */
+    int rows    = height / term->display->char_height;
+    int columns = available_width / term->display->char_width;
 
-    /* Calculate available display area in pixels */
-    int adjusted_height = height; 
-    int adjusted_width = width;
-    calculate_height_and_width(term, rows, columns,
-        &adjusted_height, &adjusted_width);
+    /* Keep height within predefined maximum */
+    if (rows > GUAC_TERMINAL_MAX_ROWS) {
+        rows = GUAC_TERMINAL_MAX_ROWS;
+        height = rows * term->display->char_height;
+    }
 
-    /* Set size of available screen area */
-    term->outer_height = height;
-    term->outer_width = width;
-
-    /* Set rows and columns size */
-    term->term_height = rows;
-    term->term_width  = columns;
+    /* Keep width within predefined maximum */
+    if (columns > GUAC_TERMINAL_MAX_COLUMNS) {
+        columns = GUAC_TERMINAL_MAX_COLUMNS;
+        available_width = columns * term->display->char_width;
+        width = available_width + GUAC_TERMINAL_SCROLLBAR_WIDTH;
+    }
 
     /* Set pixel size */
-    term->height = adjusted_height;
-    term->width = adjusted_width;
+    term->width = width;
+    term->height = height;
+
+    term->term_width  = columns;
+    term->term_height = rows;
 
     /* Open STDIN pipe */
     if (pipe(term->stdin_pipe_fd)) {
@@ -557,7 +476,7 @@ guac_terminal* guac_terminal_create(guac_client* client,
 
     /* Allocate scrollbar */
     term->scrollbar = guac_terminal_scrollbar_alloc(term->client, GUAC_DEFAULT_LAYER,
-            term->outer_width, term->outer_height, term->term_height);
+            width, height, term->term_height);
 
     /* Associate scrollbar with this terminal */
     term->scrollbar->data = term;
@@ -566,10 +485,6 @@ guac_terminal* guac_terminal_create(guac_client* client,
     /* Init terminal */
     guac_terminal_reset(term);
 
-    /* All mouse buttons are released */
-    term->mouse_mask = 0;
-
-    /* All keyboard modifiers are released */
     term->mod_alt   =
     term->mod_ctrl  =
     term->mod_shift = 0;
@@ -937,13 +852,14 @@ void guac_terminal_commit_cursor(guac_terminal* term) {
 
 }
 
-int guac_terminal_write(guac_terminal* term, const char* buffer, int length) {
+int guac_terminal_write(guac_terminal* term, const char* c, int size) {
 
     guac_terminal_lock(term);
-    for (int written = 0; written < length; written++) {
+    while (size > 0) {
 
         /* Read and advance to next character */
-        char current = *(buffer++);
+        char current = *(c++);
+        size--;
 
         /* Write character to typescript, if any */
         if (term->typescript != NULL)
@@ -956,7 +872,7 @@ int guac_terminal_write(guac_terminal* term, const char* buffer, int length) {
     guac_terminal_unlock(term);
 
     guac_terminal_notify(term);
-    return length;
+    return 0;
 
 }
 
@@ -1383,7 +1299,7 @@ static void __guac_terminal_resize(guac_terminal* term, int width, int height) {
     guac_terminal_display_flush(term->display);
     guac_terminal_display_resize(term->display, width, height);
 
-    /* Redraw any characters on right if widening */
+    /* Reraw any characters on right if widening */
     if (width > term->term_width)
         __guac_terminal_redraw_rect(term, 0, term->term_width-1, height-1, width-1);
 
@@ -1466,39 +1382,55 @@ int guac_terminal_resize(guac_terminal* terminal, int width, int height) {
     /* Acquire exclusive access to terminal */
     guac_terminal_lock(terminal);
 
-    /* Calculate available text display area by character size */
-    int rows, columns;
-    calculate_rows_and_columns(terminal, height, width, &rows, &columns);
-
-    /* Calculate available display area in pixels */
-    int adjusted_height = height; 
-    int adjusted_width = width;
-    calculate_height_and_width(terminal, rows, columns,
-        &adjusted_height, &adjusted_width);
-
     /* Set size of available screen area */
-    terminal->outer_height = height;
     terminal->outer_width = width;
+    terminal->outer_height = height;
 
-    /* Set pixel size */
-    terminal->height = adjusted_height;
-    terminal->width = adjusted_width;
+    /* Calculate available display area */
+    int available_width = width - GUAC_TERMINAL_SCROLLBAR_WIDTH;
+    if (available_width < 0)
+        available_width = 0;
+
+    /* Calculate dimensions */
+    int rows    = height / display->char_height;
+    int columns = available_width / display->char_width;
+
+    /* Keep height within predefined maximum */
+    if (rows > GUAC_TERMINAL_MAX_ROWS) {
+        rows = GUAC_TERMINAL_MAX_ROWS;
+        height = rows * display->char_height;
+    }
+
+    /* Keep width within predefined maximum */
+    if (columns > GUAC_TERMINAL_MAX_COLUMNS) {
+        columns = GUAC_TERMINAL_MAX_COLUMNS;
+        available_width = columns * display->char_width;
+        width = available_width + GUAC_TERMINAL_SCROLLBAR_WIDTH;
+    }
+
+    /* Set pixel sizes */
+    terminal->width = width;
+    terminal->height = height;
 
     /* Resize default layer to given pixel dimensions */
     guac_terminal_repaint_default_layer(terminal, client->socket);
 
     /* Resize terminal if row/column dimensions have changed */
     if (columns != terminal->term_width || rows != terminal->term_height) {
-        /* Resize terminal and set the columns and rows on the terminal struct */
+
+        guac_client_log(client, GUAC_LOG_DEBUG,
+                "Resizing terminal to %ix%i", rows, columns);
+
+        /* Resize terminal */
         __guac_terminal_resize(terminal, columns, rows);
 
         /* Reset scroll region */
         terminal->scroll_end = rows - 1;
+
     }
 
     /* Notify scrollbar of resize */
-    guac_terminal_scrollbar_parent_resized(terminal->scrollbar, 
-        terminal->outer_width, terminal->outer_height, terminal->term_height);
+    guac_terminal_scrollbar_parent_resized(terminal->scrollbar, width, height, rows);
     guac_terminal_scrollbar_set_bounds(terminal->scrollbar,
             -guac_terminal_get_available_scroll(terminal), 0);
 
@@ -2165,16 +2097,7 @@ void guac_terminal_clipboard_reset(guac_terminal* terminal,
 
 void guac_terminal_clipboard_append(guac_terminal* terminal,
         const char* data, int length) {
-
-    /* Allocate and clear space for the converted data */
-    char output_data[GUAC_COMMON_CLIPBOARD_MAX_LENGTH];
-    char* output = output_data;
-
-    /* Convert clipboard contents */
-    guac_iconv(GUAC_READ_UTF8_NORMALIZED, &data, length,
-            GUAC_WRITE_UTF8, &output, GUAC_COMMON_CLIPBOARD_MAX_LENGTH);
-
-    guac_common_clipboard_append(terminal->clipboard, output_data, output - output_data);
+    guac_common_clipboard_append(terminal->clipboard, data, length);
 }
 
 void guac_terminal_remove_user(guac_terminal* terminal, guac_user* user) {

src/terminal/terminal/display.h

@@ -44,17 +44,6 @@
  */
 #define GUAC_TERMINAL_MAX_CHAR_WIDTH 2
 
-/**
- * The size of margins between the console text and the border in mm.
- */
-#define GUAC_TERMINAL_MARGINS 2
-
-/**
- * 1 inch is 25.4 millimeters, and we can therefore use the following
- * to create a mm to px formula: (mm × dpi) ÷ 25.4 = px.
- */
-#define GUAC_TERMINAL_MM_PER_INCH 25.4
-
 /**
  * All available terminal operations which affect character cells.
  */
@@ -134,11 +123,6 @@ typedef struct guac_terminal_display {
      */
     int height;
 
-    /**
-     * The size of margins between the console text and the border in pixels.
-     */
-    int margin;
-
     /**
      * The description of the font to use for rendering.
      */

src/terminal/terminal/terminal-priv.h

@@ -29,22 +29,6 @@
 #include "terminal.h"
 #include "typescript.h"
 
-/**
- * Handler for characters printed to the terminal. When a character is printed,
- * the current char handler for the terminal is called and given that
- * character.
- *
- * @param term
- *     The terminal receiving the character.
- *
- * @param c
- *     The received character.
- *
- * @return
- *     Zero if the character was handled successfully, non-zero otherwise.
- */
-typedef int guac_terminal_char_handler(guac_terminal* term, unsigned char c);
-
 struct guac_terminal {
 
     /**

src/terminal/terminal/terminal.h

@@ -141,35 +141,19 @@ typedef enum guac_terminal_cursor_type {
 } guac_terminal_cursor_type;
 
 /**
- * Handler that is invoked whenever the necessary terminal codes are sent to
- * to the given terminal to change the path for future file uploads.
- *
- * @param client
- *     The guac_client associated with the terminal receiving the upload path
- *     change terminal code.
- *
- * @param path
- *     The requested path.
+ * Handler for characters printed to the terminal. When a character is printed,
+ * the current char handler for the terminal is called and given that
+ * character.
+ */
+typedef int guac_terminal_char_handler(guac_terminal* term, unsigned char c);
+
+/**
+ * Handler for setting the destination path for file uploads.
  */
 typedef void guac_terminal_upload_path_handler(guac_client* client, char* path);
 
 /**
- * Handler that is invoked whenever the necessary terminal codes are sent to
- * initiate a download of a given remote file.
- *
- * @param client
- *     The guac_client associated with the terminal receiving the file download
- *     terminal code.
- *
- * @param filename
- *     The name of the requested file. This may be a relative or absolute path,
- *     and it is up to the implementation to define how this value is
- *     interpreted.
- *
- * @return
- *     The file stream created for the file download, already configured to
- *     properly handle "ack" responses, etc. from the client, or NULL if the
- *     stream could not be created.
+ * Handler for creating an outbound file download stream for a specified file.
  */
 typedef guac_stream* guac_terminal_file_download_handler(guac_client* client, char* filename);
 
@@ -292,16 +276,11 @@ guac_terminal_options* guac_terminal_options_create(
 
 /**
  * Frees all resources associated with the given terminal.
- *
- * @param term
- *     The terminal to free.
  */
 void guac_terminal_free(guac_terminal* term);
 
 /**
- * Sets the upload path handler for the given terminal. The upload path handler
- * is invoked whenever the terminal codes requesting an upload path change are
- * sent.
+ * Set the upload path handler for the given terminal.
  *
  * @param terminal
  *     The terminal to set the upload path handler for.
@@ -314,14 +293,12 @@ void guac_terminal_set_upload_path_handler(guac_terminal* terminal,
         guac_terminal_upload_path_handler* upload_path_handler);
 
 /**
- * Sets the file download handler for the given terminal. The file download
- * handler is invoked whenever the terminal codes requesting download of a
- * given remote file are sent.
+ * Set the file download handler for the given terminal.
  *
  * @param terminal
  *     The terminal to set the file download handler for.
  *
- * @param file_download_handler
+ * @param upload_path_handler
  *      The handler to be called whenever the necessary terminal codes are sent to
  *      the given terminal to initiate a download of a given remote file.
  */
@@ -331,13 +308,6 @@ void guac_terminal_set_file_download_handler(guac_terminal* terminal,
 /**
  * Renders a single frame of terminal data. If data is not yet available,
  * this function will block until data is written.
- *
- * @param terminal
- *     The terminal that should be rendered.
- *
- * @return
- *     Zero if the frame was rendered successfully, non-zero if an error
- *     occurred.
  */
 int guac_terminal_render_frame(guac_terminal* terminal);
 
@@ -346,19 +316,6 @@ int guac_terminal_render_frame(guac_terminal* terminal);
  * supplied by calls to guac_terminal_send_key(),
  * guac_terminal_send_mouse(), and guac_terminal_send_stream(). If input is not
  * yet available, this function will block.
- *
- * @param terminal
- *     The terminal to read from.
- *
- * @param c
- *     The buffer that should receive the bytes read.
- *
- * @param size
- *     The number of bytes available within the buffer.
- *
- * @return
- *     The number of bytes read into the buffer, zero if end-of-file is reached
- *     (STDIN has been closed), or a negative value if an error occurs.
  */
 int guac_terminal_read_stdin(guac_terminal* terminal, char* c, int size);
 
@@ -420,23 +377,8 @@ char* guac_terminal_prompt(guac_terminal* terminal, const char* title,
 
 /**
  * Writes the given format string and arguments to this terminal's STDOUT in
- * the same manner as printf(). The entire populated format string will always
- * be written unless an error occurs. This function may block until space is
+ * the same manner as printf(). This function may block until space is
  * freed in the output buffer by guac_terminal_render_frame().
- *
- * @param terminal
- *     The terminal to write to.
- *
- * @param format
- *     A printf-style format string describing the data to be written to
- *     STDOUT.
- *
- * @param ...
- *     Any arguments to use when filling the format string.
- *
- * @return
- *     The number of bytes written to STDOUT, or a negative value if an error
- *     occurs preventing the data from being written in its entirety.
  */
 int guac_terminal_printf(guac_terminal* terminal, const char* format, ...);
 
@@ -544,24 +486,9 @@ int guac_terminal_send_data(guac_terminal* term, const char* data, int length);
 int guac_terminal_send_string(guac_terminal* term, const char* data);
 
 /**
- * Writes the given buffer to the given terminal's STDOUT. All requested bytes
- * will be written unless an error occurs. This function may block until space
- * is freed in the output buffer by guac_terminal_render_frame().
- *
- * @param term
- *     The terminal to write to.
- *
- * @param buffer
- *     A buffer containing the characters to be written to the terminal.
- *
- * @param length
- *     The number of bytes within the given string to write to the terminal.
- *
- * @return
- *     The number of bytes written to STDOUT, or a negative value if an error
- *     occurs preventing the data from being written in its entirety.
+ * Writes the given string of characters to the terminal.
  */
-int guac_terminal_write(guac_terminal* term, const char* buffer, int length);
+int guac_terminal_write(guac_terminal* term, const char* c, int size);
 
 /**
  * Initializes the handlers of the given guac_stream such that it serves as the
@@ -605,7 +532,7 @@ int guac_terminal_send_stream(guac_terminal* term, guac_user* user,
  *     STDIN.
  *
  * @param ...
- *     Any arguments to use when filling the format string.
+ *     Any srguments to use when filling the format string.
  *
  * @return
  *     The number of bytes written to STDIN, or a negative value if an error
@@ -633,20 +560,7 @@ void guac_terminal_dup(guac_terminal* term, guac_user* user,
         guac_socket* socket);
 
 /**
- * Resize the client display and terminal to the given pixel dimensions.
- *
- * @param term
- *     The terminal to resize.
- *
- * @param width
- *     The new terminal width, in pixels.
- *
- * @param height
- *     The new terminal height, in pixels.
- *
- * @return
- *     Zero if the terminal was successfully resized to the given dimensions,
- *     non-zero otherwise.
+ * Resize the terminal to the given dimensions.
  */
 int guac_terminal_resize(guac_terminal* term, int width, int height);