Maxime Coste
199c2a0961
GUACAMOLE-871: Add support for hidden cursor (DECTECM)
2019-10-15 20:24:51 +11:00
Michael Jumper
77a32398e5
GUACAMOLE-249: Migrate to plugin naming style used by FreeRDP 2.0.0.
2019-10-14 14:13:19 -07:00
Michael Jumper
6dc8b57ca4
GUACAMOLE-249: Update RAIL (RemoteApp) support to FreeRDP 2.0.0 API.
2019-10-14 11:15:43 -07:00
Michael Jumper
07f6e6afc2
GUACAMOLE-249: Remove guac_rdp_dvc_list, relying instead on the DVC channel collection within rdpSettings.
2019-10-13 15:30:21 -07:00
Michael Jumper
eab07b4a61
GUACAMOLE-249: Add trace-level logging of received and sent CLIPRDR PDUs.
2019-10-13 14:28:06 -07:00
Michael Jumper
de493ba959
GUACAMOLE-249: Send Format List Response PDU after successfully processing a Format List PDU.
2019-10-13 14:28:06 -07:00
Michael Jumper
9dd1555c81
GUACAMOLE-249: Do not include CB_RESPONSE_OK flag in Format List PDU.
...
The CLIPRDR specification requires that the msgFlags field for the
Format List PDU be set to 0x0000. The function within FreeRDP overrides
this value to 0x0000, but it is still incorrect to attempt to set it.
2019-10-13 14:28:06 -07:00
Michael Jumper
8c7984d201
GUACAMOLE-249: Free GDI implementation. Do not allocate cache (unnecessary).
2019-10-13 14:28:06 -07:00
Michael Jumper
b64b8f375a
GUACAMOLE-249: Restore support for CLIPRDR channel.
2019-10-13 14:28:06 -07:00
Michael Jumper
831606a4e9
GUACAMOLE-249: Use pkg-config to determine location of FreeRDP headers.
2019-10-11 17:56:21 -07:00
Michael Jumper
cc7cd78e5b
GUACAMOLE-249: Centralize handling of connected channels.
2019-10-08 11:44:26 -07:00
Michael Jumper
16be3af03c
GUACAMOLE-249: Load FreeRDP plugins regardless of entry point interface.
...
Most plugins built into FreeRDP implement the PVIRTUALCHANNELENTRYEX
entry point, but the FreeRDP standard function for loading plugins only
supports PVIRTUALCHANNELENTRY. It appears that only the commandline
argument parser included with FreeRDP was updated to leverage the new
entry points.
2019-10-06 14:44:26 -07:00
Michael Jumper
b89ed7ff15
GUACAMOLE-249: Migrate wait mechanism to event handle interface.
2019-10-06 14:32:12 -07:00
Michael Jumper
17045d5d3a
GUACAMOLE-249: Use reversed byte order for colors locally (verification needed).
2019-09-29 16:08:27 -07:00
Michael Jumper
7904d9c002
GUACAMOLE-249: Initialize FreeRDP's GDI implementation (default GDI handlers will otherwise fail).
2019-09-29 15:44:34 -07:00
Michael Jumper
7a7ffc2c19
GUACAMOLE-249: Add missing pixel format parameter to pointer image copy.
2019-09-29 15:44:34 -07:00
Michael Jumper
65fe6c9735
GUACAMOLE-249: Correct incorrect syntax introduced by initial partial migration (commit a5b62aa82
).
2019-09-29 15:44:34 -07:00
Michael Jumper
c311d8bde9
GUACAMOLE-249: Rely on default bitmap/GDI/pointer handlers for all but those that must be overridden.
2019-09-29 15:44:34 -07:00
Michael Jumper
1e692094be
GUACAMOLE-249: Correct remaining void returns from BOOL handlers.
2019-09-29 15:44:34 -07:00
Michael Jumper
7332e633dc
GUACAMOLE-249: Add "nla-ext" option for extended NLA mode.
2019-09-29 15:44:34 -07:00
Michael Jumper
2ed0d042a3
GUACAMOLE-249: Default to negotiated security mode, not old "RDP" encryption.
2019-09-29 14:34:05 -07:00
Michael Jumper
a76e307176
GUACAMOLE-249: RDP "DisableEncryption" settings flag has been inverted and renamed to "UseRdpSecurityLayer".
2019-09-29 14:25:47 -07:00
Michael Jumper
6886665f65
GUACAMOLE-249: Comment out usage of old event interface.
2019-09-29 14:15:41 -07:00
Michael Jumper
703ce5c223
GUACAMOLE-249: Remove usage of old FreeRDP channels interface.
2019-09-29 14:15:13 -07:00
Michael Jumper
ad7ab67571
GUACAMOLE-249: The freerdp/gdi/gdi.h header is required to access contents of rdpGdi struct.
2019-09-22 14:58:23 -07:00
Michael Jumper
9fa9adbd58
GUACAMOLE-249: Migrate to libwinpr "CF_*" constants for clipboard formats.
...
The "CB_FORMAT_*" constants which used to be defined by FreeRDP no
longer exist.
2019-09-22 14:58:23 -07:00
Michael Jumper
3b560044bc
GUACAMOLE-249: Correct prototype of certificate verification callback. If accepting the certificate, request that FreeRDP not store it.
2019-09-22 14:49:30 -07:00
Michael Jumper
82664b4e6b
GUACAMOLE-249: Correct prototypes of GDI handlers.
2019-09-22 14:49:30 -07:00
Michael Jumper
fbfbaff540
GUACAMOLE-249: Correct prototypes of pointer handlers.
2019-09-22 14:49:30 -07:00
Michael Jumper
e4a68d776f
GUACAMOLE-249: Correct prototypes of glyph handlers.
2019-09-22 14:49:30 -07:00
Michael Jumper
9b08a716d6
GUACAMOLE-249: Comment out remaining usage of SVC.
2019-09-22 14:49:03 -07:00
Michael Jumper
554251cc72
GUACAMOLE-249: Remove usage of CLRCONV.
2019-09-22 14:49:00 -07:00
Michael Jumper
17d31d94b7
GUACAMOLE-249: Remove all legacy FreeRDP compatibility.
2019-09-22 14:48:56 -07:00
Michael Jumper
a5b62aa82e
GUACAMOLE-249: Migrate to newer API (partial).
2019-09-22 14:48:26 -07:00
Mike Jumper
b181026e58
GUACAMOLE-861: Merge correction to RDPDR filesystem timestamp conversion.
2019-08-22 10:25:55 -07:00
unknown
4cc9c2d3e1
GUACAMOLE-861: Fixes WINDOWS_TIME calculation
...
This fixes the UNIX time to FILETIME conversion in WINDOWS_TIME macro,
according to MSDN (addition instead of subtraction).
2019-08-21 23:05:45 +03:00
Virtually Nick
f34be230aa
GUACAMOLE-859: Merge correct Caps Lock keysym sent via RDP
2019-08-13 21:11:46 -04:00
Weston Thayer
a189c9ab8a
GUACAMOLE-859: Remove +ext from Caps Lock keymapping.
...
When connected with a Guacamole RDP session, the keysym for Caps Lock (0xffe5) is sent over RDP as scancode 0xe03a. Windows does not understand this scancode, thus does not generate the correct VK (Virtual Key) events. Removing +ext from the keymap sends the scancode 0x003a, which is correctly recognized by Windows as Caps Lock. This enables Windows applications to listen for key down and key up events on the Caps Lock key while connected via a Guacamole RDP session.
Note: this issue likely went un-noticed for a long time because it only impacts the key up and down events for the Caps Lock key, not Caps Lock's effect on sending uppercase [A-Z] characters.
2019-08-13 21:00:26 -04:00
Nick Couchman
7ac840090e
GUACAMOLE-514: Slight correction to debug message.
2019-08-12 19:45:45 -04:00
Nick Couchman
61d12f1668
GUACAMOLE-514: VNC client should abort on credential error.
2019-08-09 13:08:36 -04:00
Nick Couchman
f21621e677
GUACAMOLE-514: Remove x509 support.
2019-08-09 13:05:40 -04:00
Nick Couchman
88425160ae
GUACAMOLE-514: Write x509 authentication factors to temp files.
2019-08-09 13:05:40 -04:00
Nick Couchman
b9001f4ec7
GUACAMOLE-514: Add missing parameter tag.
2019-08-09 13:05:40 -04:00
Nick Couchman
4329739d3e
GUACAMOLE-514: Remove CRL check flag.
2019-08-09 13:05:40 -04:00
Nick Couchman
90d55956d0
GUACAMOLE-514: use correct client in log call.
2019-08-09 13:05:40 -04:00
Nick Couchman
51ae8a41a1
GUACAMOLE-514: Add guacd support for extended VNC credentials.
2019-08-09 13:05:40 -04:00
Nick Couchman
f962eab27a
Merge 1.1.0 changes back to master.
2019-08-09 13:01:54 -04:00
Michael Jumper
43269920db
GUACAMOLE-630: Clarify usage of argv-related guac_user_callback implementations.
2019-08-07 20:16:01 -07:00
Michael Jumper
f56df8b8be
GUACAMOLE-630: Automatically send current color scheme and font to users joining SSH, telnet, and Kubernetes connections.
2019-08-04 12:52:00 -07:00
Michael Jumper
ccfcfb116d
GUACAMOLE-630: Persist details of color scheme and font changes.
2019-08-04 12:44:43 -07:00
Michael Jumper
4dabea37af
GUACAMOLE-630: Allow guac_terminal_parse_color_scheme() to dictate color scheme format.
2019-08-04 11:55:45 -07:00
Michael Jumper
0516d599cf
GUACAMOLE-630: Disallow NULL color schemes.
...
A color scheme string should always be provided, even if blank.
Disallowing NULL allows assumptions to be made which simplifies the
logic surrounding persisting provided configuration values.
2019-08-04 11:45:41 -07:00
Michael Jumper
b5191caddc
GUACAMOLE-630: Accept pre-defined color schemes in all cases, not just during terminal creation.
2019-08-04 11:37:42 -07:00
Michael Jumper
0c7898c55a
GUACAMOLE-630: Expose terminal font/color configuration changes to connected clients.
2019-08-03 19:53:07 -07:00
Nick Couchman
289ceac222
Merge 1.1.0 changes back to master.
2019-08-03 17:16:45 -04:00
Virtually Nick
e25f83d629
GUACAMOLE-623: Merge add support for adjusting terminal for Kubernetes via "argv".
2019-08-03 17:14:30 -04:00
Michael Jumper
e6835795f0
GUACAMOLE-623: Add support for setting terminal font for Kubernetes via "argv".
2019-08-03 14:04:30 -07:00
Nick Couchman
b6005cc8a0
Merge 1.1.0 changes back to master.
2019-07-31 12:39:32 -04:00
Michael Jumper
ca073db5b6
GUACAMOLE-629: Add convenience functions for immediately sending the current value of a connection parameter.
2019-07-30 14:05:50 -07:00
Michael Jumper
c3a295e9b7
GUACAMOLE-629: Add convenience function for automatically splitting data across a series of blob instructions.
2019-07-30 14:05:50 -07:00
Michael Jumper
c47aa0cea1
GUACAMOLE-629: Define constant for maximum blob size.
2019-07-30 13:34:24 -07:00
Michael Jumper
c1b8250300
GUACAMOLE-629: Move constants for Guacamole protocol to dedicated "*-constants.h" header.
2019-07-30 13:33:18 -07:00
Michael Jumper
a763d47bc7
GUACAMOLE-629: Add support for sending "argv" instructions from server to client.
2019-07-30 13:06:46 -07:00
Michael Jumper
a3101e9744
Merge 1.1.0 changes back to master.
2019-07-26 14:38:25 -07:00
Nick Couchman
26bb10a486
GUACAMOLE-422: Add empty handler and trace logging for nop instruction.
2019-07-23 14:29:50 -04:00
Frank Riley
87a5479ff8
GUACAMOLE-847: Fix severe memory leak when using audio with RDP
2019-07-20 06:14:36 -07:00
Mike Jumper
b4ef38c064
GUACAMOLE-837: Merge RDP support for Hungarian keyboards.
2019-07-11 21:20:08 -07:00
Nick Couchman
ce7bea66cf
Merge 1.1.0 changes back to master.
2019-07-11 09:10:26 -04:00
fgiuba
55add063c5
GUACAMOLE-547: Add missing space between brackets.
2019-07-11 13:37:03 +02:00
fgiuba
9228d2637a
GUACAMOLE-547: Do not ignore password from settings.
2019-07-11 13:37:03 +02:00
P-Zs
8f1826d3e4
GUACAMOLE-837: Update Makefile.am to reference the new Hungarian keymap file
2019-07-10 00:55:31 +02:00
P-Zs
badee3274b
GUACAMOLE-837: Add Hungarian RDP keymap file to code base
2019-07-10 00:55:31 +02:00
Michael Jumper
e149fd4f70
Merge 1.1.0 changes back to master.
2019-06-20 00:47:46 -07:00
Nick Couchman
1baa91f852
GUACAMOLE-547: Minor changes to function documentation.
2019-06-19 12:38:05 -04:00
Nick Couchman
22874e2388
GUACAMOLE-547: Document return value of credential handler.
2019-06-18 17:59:33 -04:00
Nick Couchman
3511991e2f
GUACAMOLE-547: Fixes for style and documentation.
2019-06-18 07:52:05 -04:00
Nick Couchman
9a51d513f2
GUACAMOLE-547: Provide documentation for the new callback function.
2019-06-18 07:37:02 -04:00
Nick Couchman
3d15454097
GUACAMOLE-547: Use a call-back function for getting the password.
2019-06-18 07:37:02 -04:00
Nick Couchman
4641da06ac
GUACAMOLE-547: Relocate NULL check and log when NONE succeeds.
2019-06-18 07:37:02 -04:00
Nick Couchman
b7dca0ed16
GUACAMOLE-547: Add support for SSH NONE authentication method.
2019-06-18 07:37:02 -04:00
Michael Jumper
a1c382c8ce
Merge 1.1.0 changes back to master.
2019-04-30 17:26:21 -07:00
Nick Couchman
bf741a46d6
GUACAMOLE-422: Minor style and debug changes.
2019-04-27 21:37:26 -04:00
Nick Couchman
93a240b8ad
GUACAMOLE-422: Add debugging and check argument count.
2019-04-24 22:21:18 -04:00
Mike Jumper
5e8f5eaa50
GUACAMOLE-296: Merge changes linking libwinpr / libwinpr-utils as needed.
2019-04-24 15:35:16 -07:00
Mike Jumper
fc68113d75
GUACAMOLE-414: Merge support for libvncclient's TLS threadsafety callbacks.
2019-04-24 15:29:32 -07:00
Nick Couchman
4b43de963e
GUACAMOLE-422: Break handshake out into separate function; NULL out timezone when not received.
2019-04-22 11:49:46 -04:00
Nick Couchman
588e0f194a
GUACAMOLE-422: Fix return documentation on opcode handler function.
2019-04-19 15:50:29 -04:00
Nick Couchman
ab12b2aa8e
GUACAMOLE-422: More substantial comment for protocol version; NULL out timezone at beginning of handshake.
2019-04-19 15:48:14 -04:00
Nick Couchman
98cb7ccf67
GUACAMOLE-422: Fix comment and style.
2019-04-17 15:12:46 -04:00
Nick Couchman
75c0deac1f
GUACAMOLE-422: Update comment style for consistency.
2019-04-17 15:03:27 -04:00
Nick Couchman
54f88531d4
GUACAMOLE-422: Try to avoid memory leaks with mimetypes.
2019-04-17 15:00:46 -04:00
Nick Couchman
340aef5362
GUACAMOLE-422: Update to remove first argument
2019-04-17 14:41:35 -04:00
Nick Couchman
379fce2d77
GUACAMOLE-422: Rename new opcode handler function.
2019-04-11 17:21:36 -04:00
Nick Couchman
c750b18f60
GUACAMOLE-422: Handle sending version internally.
2019-04-11 17:18:27 -04:00
Nick Couchman
2f57564f5d
GUACAMOLE-422: Remove duplicate code and migrate handshake to user handlers.
2019-04-11 17:18:27 -04:00
Nick Couchman
2b68925ec9
GUACAMOLE-422: Add protocol version as initial item passed back in args.
2019-04-11 17:18:27 -04:00
Nick Couchman
0ee47e0186
GUACAMOLE-422: Change handshake to ignore order of opcodes.
2019-04-11 17:18:27 -04:00
Nick Couchman
5480b288e8
GUACAMOLE-422: Remove NULL check for parser argv.
2019-04-11 17:18:27 -04:00
Nick Couchman
5caa8a25f7
GUACAMOLE-422: SSH parameter should use handshake for default.
2019-04-11 17:18:27 -04:00
Nick Couchman
6fae0b4b23
GUACAMOLE-422: Use timezone from handshake when parameter does not exist.
2019-04-11 17:18:27 -04:00
Nick Couchman
f70aa4939f
GUACAMOLE-422: Add client timezone to handshake.
2019-04-11 17:16:43 -04:00
Nick Couchman
cd3432e594
Merge 1.1.0 changes back to master.
2019-04-10 06:18:53 -04:00
Michael Jumper
0c25782036
GUACAMOLE-637: Add missing libguac include path to RDP and common-ssh tests.
2019-04-09 23:36:03 -07:00
James Muehlner
6dad6cd919
Merge 1.1.0 changes back to master.
2019-04-09 21:52:28 -07:00
James Muehlner
dd4c3968d1
GUACAMOLE-637: Merge migration to new libguac string functions.
2019-04-09 21:49:16 -07:00
m-khan-glyptodon
871f31353b
GUACAMOLE-764: Updated variable type for offsets to uint64_t to increase rdp write to a 64-bit addressable space
2019-04-08 15:27:58 -07:00
m-khan-glyptodon
2db7ffbaab
GUACAMOLE-764: Updated variable type for offsets to uint64_t to increase rdp read to a 64-bit addressable space
2019-04-08 15:00:59 -07:00
Michael Jumper
f8ec709e33
GUACAMOLE-637: Correct naming of SFTP unit tests.
2019-04-07 16:51:53 -07:00
Michael Jumper
cda7bca126
GUACAMOLE-637: Add RDP filesystem and SFTP unit tests for path depth.
2019-04-07 16:51:33 -07:00
Michael Jumper
6e2be38ae2
GUACAMOLE-637: Add path depth limits to generated paths in unit tests.
2019-04-07 16:36:16 -07:00
Michael Jumper
986f7f5d64
GUACAMOLE-637: Use same logic for RDP filesystem path normalization as SFTP.
2019-04-07 16:30:27 -07:00
Michael Jumper
1591980579
GUACAMOLE-637: Simplify SFTP path normalization logic. Correct behavior to match documentation.
2019-04-07 16:14:00 -07:00
Michael Jumper
591e494dfd
GUACAMOLE-637: Add unit tests for RDP filesystem path normalization.
2019-04-07 13:56:52 -07:00
Michael Jumper
f19754cfa6
GUACAMOLE-637: Add unit tests for SFTP path normalization.
2019-04-07 13:50:53 -07:00
Michael Jumper
24ab5ca85b
GUACAMOLE-637: Remove unnecessary .gitignore files. Universally exclude test output. Remove duplicated exclusions.
2019-04-07 11:50:43 -07:00
Nick Couchman
1b8e31b70c
GUACAMOLE-296: Add checks for Stream functions in winpr libraries.
2019-03-24 16:12:20 -04:00
Nick Couchman
a4521208ba
GUACAMOLE-414: Remove unnecessary rfbconfig include.
2019-03-24 15:09:58 -04:00
Nick Couchman
a6f2ab9d93
GUACAMOLE-414: Use correct formatting for string from strerror.
2019-03-10 17:41:45 -04:00
Nick Couchman
bfc6c1e6e0
GUACAMOLE-414: Convert errors to strings from ptread_mutex_lock and unlock.
2019-03-10 17:40:34 -04:00
Nick Couchman
36817f3774
GUACAMOLE-414: Clean up style and move mutex init to client allocation.
2019-03-10 17:33:14 -04:00
Nick Couchman
df4c93b3e8
GUACAMOLE-414: Use configure checks for finding TLS locking support.
2019-03-10 15:22:49 -04:00
Nick Couchman
c90c057e12
GUACAMOLE-414: Add version checks for TLS locking.
2019-03-09 21:46:02 -05:00
Nick Couchman
e9a10d66b7
GUACAMOLE-414: Add pthread lock and callbacks for TLS write locking.
2019-03-09 21:27:30 -05:00
Michael Jumper
228cea4af1
GUACAMOLE-381: Disable outbound transfers from terminal protocols if "disable-copy" is set.
2019-02-19 12:11:24 -08:00
Michael Jumper
254615509a
GUACAMOLE-381: Disable or ignore outbound clipboard transfers for VNC/RDP if "disable-copy" is set.
2019-02-19 11:45:30 -08:00
Michael Jumper
993d5c5707
GUACAMOLE-381: Disable inbound clipboard transfer if "disable-paste" is set.
2019-02-19 11:40:32 -08:00
Michael Jumper
7d2b7126db
GUACAMOLE-381: Add copy/paste disable flags for all supported protocols.
2019-02-19 11:34:18 -08:00
Michael Jumper
a0d030a7ae
GUACAMOLE-729: Update libtool version info for libguac (interfaces added and changed).
2019-02-09 11:20:06 -08:00
Virtually Nick
7065ff5586
GUACAMOLE-712: Merge add Danish to RDP
2019-02-06 09:01:33 -05:00
netromnetrom
aeb9b99a6c
Merge pull request #2 from netromnetrom/patch-1
...
Patch 1
2019-02-06 12:01:19 +01:00
Michael Jumper
c6feef6c86
GUACAMOLE-637: Clarify purpose of initial empty path component. Fix normalization logic to ensure that empty component is always present.
2019-01-23 20:28:09 -08:00
Michael Jumper
350d8e5995
GUACAMOLE-637: Document failsafe behavior of guac_strlcat() in the event the destination buffer is not terminated as required.
2019-01-23 19:02:19 -08:00
Michael Jumper
ba8fd17394
GUACAMOLE-637: "concatentation" ... not "contatenation".
2019-01-23 18:53:06 -08:00
Michael Jumper
9fb713d804
GUACAMOLE-637: Correct grammar of documentation for guac_strl*() unit tests.
2019-01-23 18:51:53 -08:00
Michael Jumper
b7761e9a2e
GUACAMOLE-637: The $^
variable is non-portable and specific to GNU Make. As otherwise POSIX-compliant platforms may not provide this variable, we shouldn't use it here.
2019-01-23 18:44:45 -08:00
Michael Jumper
789e3883d6
GUACAMOLE-637: Not all systems place Perl in /usr/bin. The line #!/usr/bin/env perl
should be used for portability.
2019-01-23 18:44:45 -08:00
Michael Jumper
e6c5da315e
GUACAMOLE-637: Add unit tests for guac_strljoin().
2019-01-23 18:44:45 -08:00
Michael Jumper
258946cd88
GUACAMOLE-637: Correctly handle string lengths as size_t (unsigned).
2019-01-23 18:44:45 -08:00
Michael Jumper
068f33aaef
GUACAMOLE-637: Add unit tests for guac_strlcat().
2019-01-23 18:44:45 -08:00
Michael Jumper
dec3642905
GUACAMOLE-637: Add unit tests for guac_strlcpy().
2019-01-23 18:44:45 -08:00
Michael Jumper
fdd3292f09
GUACAMOLE-637: Simplify path translation logic. Update to use guac_strl*(). Fix return values.
2019-01-23 18:44:45 -08:00
Michael Jumper
3549da0dd1
GUACAMOLE-637: Replace usages of strncat() with guac_strlcat().
2019-01-23 18:44:45 -08:00
Michael Jumper
e5c1147cf6
GUACAMOLE-637: Replace usages of strncpy() with guac_strlcpy().
2019-01-23 18:44:45 -08:00
Michael Jumper
5bf6a1479c
GUACAMOLE-637: Add convenience function for joining an array of strings using a given delimiter.
2019-01-23 18:44:45 -08:00
Michael Jumper
a78f254611
GUACAMOLE-637: Add strlcat() implementation. Use libc strlcat() if available.
2019-01-23 18:44:45 -08:00
Michael Jumper
d7909a77aa
GUACAMOLE-637: Add strlcpy() implementation. Use libc strlcpy() if available.
2019-01-23 18:44:45 -08:00
Michael Jumper
f6953e1317
GUACAMOLE-637: Use proper namespaced path for Guacamole headers within libguac source.
2019-01-23 18:44:45 -08:00
netromnetrom
7b7c8a1b02
Update Makefile.am
2019-01-22 16:24:56 +01:00
netromnetrom
a06edb9deb
Update and rename dk_dk_qwerty.keymap to da_dk_qwerty.keymap
2019-01-22 14:36:05 +01:00
Michael Jumper
d73b86b4b7
GUACAMOLE-661: Mark "nest" instruction and socket as deprecated.
2019-01-07 09:37:08 -08:00