Jimmy
a91c4b3869
GUACAMOLE-1350: Add code to join leave_handler when connecting in other protocols.
2021-05-25 02:03:07 +03:00
Michael Jumper
2f6de25418
GUACAMOLE-221: Migrate SSH handling of "argv" to guac_argv_*() convenience API.
2020-07-06 18:19:08 -07:00
Michael Jumper
860a5fca8f
GUACAMOLE-559: Maintain terminal clipboard at client level such that it is guaranteed to exist immediately after user connects.
2018-07-30 23:53:03 -07:00
Michael Jumper
b37e73488f
GUACAMOLE-313: Provide reference to in-progress screen recording.
2018-01-26 16:21:24 -08:00
sanhex
d33bd8deff
GUACAMOLE-384: fixing segfault during ssh disconnect
...
Root Cause:
See the core dump and Valgrind report posted on Jira. guacd was reading a ssh terminal which had been freed. When a ssh connection is terminated, guac_ssh_client_free_handler() will be called from guacd_exec_proc() -> guac_client_free() with pointer client->free_handler. In guac_ssh_client_free_handler(), when ssh_client->term is freed, ssh_client->client_thread may still be using the ssh_client->term. It causes the crash reported in this bug.
The stack trace exposing the problem can be found by running guacd under Valgrind with a ssh test script. The test script repeats doing ssh login and logout for 5000 times.
Solution:
In guac_ssh_client_free_handler(), before calling guac_terminal_free(ssh_client->term), close the stdin pipe of the terminal to stop reading the pipe with guac_terminal_read_stdin() in ssh_input_thread(). So that ssh_input_thread() can be terminated in this case. Call pthread_join() to wait for ssh_client_thread() terminating before freeing the terminal.
Add a new function guac_terminal_stop() to close the pipe and set the fds to invalid (-1). Call it in guac_ssh_client_free_handler() and guac_terminal_free().
Checking the client running state in ssh_input_thread() and ssh_client_thread() to make sure they can be terminated when the client is stopped in guacd_exec_proc() by another thread.
Test:
- Confirmed ssh connection works normally.
- Observed the child process of guacd exits when ssh connection is terminated.
- Reran the ssh test script. Observed no crash.
2017-10-29 18:11:15 -07:00
Michael Jumper
3f7ccb6b9a
GUACAMOLE-169: Move terminal headers to namespaced directory.
2017-02-27 14:34:46 -08:00
Michael Jumper
d371f2d9ee
GUACAMOLE-169: Move common-ssh headers to namespaced directory.
2017-02-27 14:28:23 -08:00
Michael Jumper
4da3bef4ec
GUACAMOLE-1: Relicense C files.
2016-03-28 20:39:19 -07:00
Michael Jumper
075b7ffba9
GUAC-1389: Add screen sharing support to SSH.
2016-03-14 17:33:17 -07:00
Michael Jumper
4661f432f0
GUAC-1452: Parse and handle typescript parameters within SSH and telnet.
2016-01-27 12:43:53 -08:00
Michael Jumper
ad34aa99b4
GUAC-1452: Add typescript parameters for SSH/telnet.
2016-01-25 13:12:24 -08:00
Michael Jumper
e8b98abfc4
GUAC-1038: Add support for running specific commands via SSH (instead of a shell).
2015-10-19 15:58:44 -07:00
Michael Jumper
677c3ce6e8
GUAC-1195: Add "color-scheme" parameter to SSH and telnet.
2015-07-28 16:46:32 -07:00
Michael Jumper
fa443249c9
GUAC-1195: Use color scheme constants and names.
2015-07-28 16:43:23 -07:00
Michael Jumper
b2c2779465
GUAC-1195: Define and use color constants for terminal.
2015-07-28 16:20:14 -07:00
Michael Jumper
029b3bdb80
GUAC-1195: Configure default foreground/background when terminal is created.
2015-07-28 15:59:20 -07:00
Michael Jumper
49beb7d7fd
GUAC-1264: Require explicit free for users and sessions. Ensure SSH client data is zeroed upon allocation.
2015-07-24 13:20:36 -07:00
Michael Jumper
a6b46a0ea0
GUAC-1171: Add and document SFTP functionality within common SSH.
2015-07-10 17:21:27 -07:00
Michael Jumper
0fcea2738b
GUAC-1171: Migrate to common SSH within client.
2015-07-10 12:46:11 -07:00
Michael Jumper
42c36f5b84
GUAC-1172: Properly store/free filesystem object.
2015-07-01 10:48:25 -07:00
Michael Jumper
431fd2de6f
GUAC-911: Add log levels. Refactor guac_client_log_*() into guac_client_log().
2014-11-07 16:32:19 -08:00
Michael Jumper
8d99c35a86
GUAC-769: Ensure socket output is handled in a threadsafe manner.
2014-07-10 16:49:13 -07:00
Michael Jumper
48d1597418
GUAC-730: Fix headers for SSH.
2014-06-11 10:06:18 -07:00
Michael Jumper
c84a88d35a
GUAC-718: Set locale (for sake of wcwidth()). Warn if locale does not use UTF-8.
2014-06-02 16:01:13 -07:00
Michael Jumper
0acd219a88
GUAC-653: Remove unneeded includes.
2014-05-06 16:45:36 -07:00
Michael Jumper
f2781ed0cc
GUAC-653: Move mouse and key handling into terminal. Move clipboard into terminal.
2014-05-05 19:02:41 -07:00
Michael Jumper
455f2e543a
GUAC-653: Update namespace in common terminal code.
2014-05-05 16:36:49 -07:00
Michael Jumper
83093f1bd3
GUAC-614: Migrate SSH to simpler stream API.
2014-04-10 13:47:36 -07:00
Michael Jumper
2c4ae68da0
GUAC-608: Add support for outbound clipboard for SSH. Partial inbound support.
2014-04-09 11:40:09 -07:00
Michael Jumper
6e6af91cfa
GUAC-556: Send proper errors for SSH.
2014-03-21 19:47:42 -07:00
Michael Jumper
442ed427a0
Clean up includes, clean up build.
2014-01-01 14:52:01 -08:00
Michael Jumper
0303c4e24b
Relicense everything (except French keymap) as MIT. Status of French keymap is TBD.
2014-01-01 14:46:18 -08:00
Michael Jumper
78202d25ba
Pay attention to DPI when rendering terminal.
2013-12-27 00:28:23 -08:00
Michael Jumper
84c484aa72
Add missing license comments.
2013-12-02 02:07:17 -08:00
Michael Jumper
3f686db40c
Lookup hosts, etc. for connect.
2013-12-01 16:26:41 -08:00
Michael Jumper
d32018cf87
Partial migration, including SFTP.
2013-12-01 15:39:29 -08:00
Michael Jumper
1af28eb820
Prompt for passphrase if needed.
2013-10-30 23:19:11 -07:00
Michael Jumper
678ec69ebe
Read private key, if any.
2013-10-30 15:46:13 -07:00
Michael Jumper
1ba575d3aa
Implement directory set.
2013-10-28 14:11:04 -07:00
Michael Jumper
b9d9a9d324
Move SFTP to own SSH session - does not work when combined with terminal session.
2013-10-27 23:16:48 -07:00
Michael Jumper
02fece0a29
Add enable-sftp option, init/free SFTP as needed.
2013-10-27 23:16:48 -07:00
Michael Jumper
21b704690b
Handle NULL conditions of display and terminal allocation.
2013-08-23 14:10:51 -07:00
Michael Jumper
4c089caeb9
Massively reorganize source tree.
2013-06-05 11:00:28 -07:00
