From dd2e0203515bdce87a341b5600b27ca9e356fcd2 Mon Sep 17 00:00:00 2001
From: Michael Jumper <mike.jumper@guac-dev.org>
Date: Mon, 17 Aug 2015 01:44:31 -0700
Subject: [PATCH] GUAC-240: Move JPEG optimality test into own function.

---
 src/common/guac_surface.c | 37 +++++++++++++++++++++++++++++--------
 1 file changed, 29 insertions(+), 8 deletions(-)

diff --git a/src/common/guac_surface.c b/src/common/guac_surface.c
index 17bf7df2..3b29d6eb 100644
--- a/src/common/guac_surface.c
+++ b/src/common/guac_surface.c
@@ -284,7 +284,7 @@ static void __guac_common_mark_dirty(guac_common_surface* surface, const guac_co
  *     The average refresh frequency.
  */
 static unsigned int __guac_common_surface_calculate_framerate(
-        guac_common_surface* surface, guac_common_rect* rect) {
+        guac_common_surface* surface, const guac_common_rect* rect) {
 
     int x, y;
 
@@ -335,6 +335,31 @@ static unsigned int __guac_common_surface_calculate_framerate(
 
 }
 
+/**
+ * Returns whether the given rectangle would be optimally encoded as JPEG
+ * rather than PNG.
+ *
+ * @param surface
+ *     The surface to be queried.
+ *
+ * @param rect
+ *     The rectangle to check.
+ *
+ * @return
+ *     Non-zero if the rectangle would be optimally encoded as JPEG, zero
+ *     otherwise.
+ */
+static int __guac_common_surface_should_use_jpeg(guac_common_surface* surface,
+        const guac_common_rect* rect) {
+
+    /* Calculate the average framerate for the given rect */
+    int framerate = __guac_common_surface_calculate_framerate(surface, rect);
+
+    /* JPEG is preferred if rect is hot and smooth */
+    return framerate >= GUAC_COMMON_SURFACE_LOSSY_REFRESH_FREQUENCY;
+
+}
+
 /**
  * Touch the heat map with this update rectangle, so that the update
  * frequency can be calculated later.
@@ -1264,13 +1289,9 @@ void guac_common_surface_flush(guac_common_surface* surface) {
 
                 flushed++;
 
-                /* Calculate the average framerate for the dirty rect */
-                int framerate =
-                    __guac_common_surface_calculate_framerate(surface,
-                            &surface->dirty_rect);
-
-                /* If this rectangle is hot, flush as JPEG */
-                if (framerate >= GUAC_COMMON_SURFACE_LOSSY_REFRESH_FREQUENCY)
+                /* Flush as JPEG if JPEG is preferred */
+                if (__guac_common_surface_should_use_jpeg(surface,
+                            &surface->dirty_rect))
                     __guac_common_surface_flush_to_jpeg(surface);
 
                 /* Otherwise, use PNG */