From da80163e24dbf728f5c2e1245c23ded5f629917e Mon Sep 17 00:00:00 2001
From: Michael Jumper <mjumper@apache.org>
Date: Wed, 18 May 2022 15:35:15 -0700
Subject: [PATCH] GUACAMOLE-377: Enable graphics pipeline extension by default.

---
 src/protocols/rdp/settings.c | 19 ++++++++++---------
 1 file changed, 10 insertions(+), 9 deletions(-)

diff --git a/src/protocols/rdp/settings.c b/src/protocols/rdp/settings.c
index 911bc75d..6a3e6407 100644
--- a/src/protocols/rdp/settings.c
+++ b/src/protocols/rdp/settings.c
@@ -80,6 +80,7 @@ const char* GUAC_RDP_CLIENT_ARGS[] = {
     "disable-bitmap-caching",
     "disable-offscreen-caching",
     "disable-glyph-caching",
+    "disable-gfx",
     "preconnection-id",
     "preconnection-blob",
     "timezone",
@@ -109,7 +110,6 @@ const char* GUAC_RDP_CLIENT_ARGS[] = {
     "create-recording-path",
     "resize-method",
     "enable-audio-input",
-    "enable-gfx",
     "enable-touch",
     "read-only",
 
@@ -372,6 +372,13 @@ enum RDP_ARGS_IDX {
      */
     IDX_DISABLE_GLYPH_CACHING,
 
+    /**
+     * "true" if the RDP Graphics Pipeline Extension should not be used, and
+     * traditional RDP graphics should be used instead, "false" or blank if the
+     * Graphics Pipeline Extension should be used if available.
+     */
+    IDX_DISABLE_GFX,
+
     /**
      * The preconnection ID to send within the preconnection PDU when
      * initiating an RDP connection, if any.
@@ -540,12 +547,6 @@ enum RDP_ARGS_IDX {
      */
     IDX_ENABLE_AUDIO_INPUT,
 
-    /**
-     * "true" if the RDP Graphics Pipeline Extension should be used, "false" or
-     * blank if traditional RDP graphics should be used instead.
-     */
-    IDX_ENABLE_GFX,
-
     /**
      * "true" if multi-touch support should be enabled for the RDP connection,
      * "false" or blank otherwise.
@@ -1138,8 +1139,8 @@ guac_rdp_settings* guac_rdp_parse_args(guac_user* user,
 
     /* RDP Graphics Pipeline enable/disable */
     settings->enable_gfx =
-        guac_user_parse_args_boolean(user, GUAC_RDP_CLIENT_ARGS, argv,
-                IDX_ENABLE_GFX, 0);
+        !guac_user_parse_args_boolean(user, GUAC_RDP_CLIENT_ARGS, argv,
+                IDX_DISABLE_GFX, 0);
 
     /* Multi-touch input enable/disable */
     settings->enable_touch =