maride/guacamole-spice-protocol
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Require a minimum number of buffers before old free'd buffers are reused, implement LRU strategy for reuse of buffers (oldest free'd buffer).

Browse Source
This commit is contained in:
Michael Jumper 2012-01-12 09:57:34 -08:00
parent 180216159f
commit da27927a3f
2 changed files with 26 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
libguac/include/client.h
View File

@ -123,6 +123,14 @@ typedef int guac_client_init_handler(guac_client* client, int argc, char** argv)
*/ */
#define GUAC_CLIENT_MOUSE_SCROLL_DOWN 0x10 #define GUAC_CLIENT_MOUSE_SCROLL_DOWN 0x10
/**
* The minimum number of buffers to create before allowing free'd buffers to
* be reclaimed. In the case a protocol rapidly creates, uses, and destroys
* buffers, this can prevent unnecessary reuse of the same buffer (which
* would make draw operations unnecessarily synchronous).
*/
#define GUAC_BUFFER_POOL_INITIAL_SIZE 1024
/** /**
* Possible current states of the Guacamole client. Currently, the only * Possible current states of the Guacamole client. Currently, the only
* two states are GUAC_CLIENT_RUNNING and GUAC_CLIENT_STOPPING. * two states are GUAC_CLIENT_RUNNING and GUAC_CLIENT_STOPPING.
@ -206,6 +214,11 @@ struct guac_client {
*/ */
guac_layer* __available_buffers; guac_layer* __available_buffers;
/**
* Pointer to the last buffer in the list of all available buffers.
*/
guac_layer* __last_available_buffer;
/** /**
* The head pointer of the list of all allocated layers, regardless of use * The head pointer of the list of all allocated layers, regardless of use
* status. * status.

17
libguac/src/client.c
View File

@ -78,10 +78,17 @@ guac_layer* guac_client_alloc_buffer(guac_client* client) {
guac_layer* allocd_layer; guac_layer* allocd_layer;
/* If available layers, pop off first available buffer */ /* If available layers, pop off first available buffer */
if (client->__available_buffers != NULL) { if (client->__next_buffer_index <= -GUAC_BUFFER_POOL_INITIAL_SIZE &&
client->__available_buffers != NULL) {
allocd_layer = client->__available_buffers; allocd_layer = client->__available_buffers;
client->__available_buffers = client->__available_buffers->__next_available; client->__available_buffers = client->__available_buffers->__next_available;
allocd_layer->__next_available = NULL; allocd_layer->__next_available = NULL;
/* If last buffer, reset last available buffer pointer */
if (allocd_layer == client->__last_available_buffer)
client->__last_available_buffer = NULL;
} }
/* If no available buffer, allocate new buffer, add to __all_layers list */ /* If no available buffer, allocate new buffer, add to __all_layers list */
@ -103,9 +110,11 @@ guac_layer* guac_client_alloc_buffer(guac_client* client) {
void guac_client_free_buffer(guac_client* client, guac_layer* layer) { void guac_client_free_buffer(guac_client* client, guac_layer* layer) {
/* Add layer to pool of available buffers */ /* Add layer to tail of pool of available buffers */
layer->__next_available = client->__available_buffers; if (client->__last_available_buffer != NULL)
client->__available_buffers = layer; client->__last_available_buffer->__next_available = layer;
client->__last_available_buffer = layer;
} }