From d9dacedbe0f50de5a75caa469aa962bbe46f6c4f Mon Sep 17 00:00:00 2001 From: Michael Jumper Date: Wed, 27 Jan 2016 12:40:09 -0800 Subject: [PATCH] GUAC-1452: Log typescript creation/failure. --- src/terminal/terminal.c | 19 +++++++++++++++++-- 1 file changed, 17 insertions(+), 2 deletions(-) diff --git a/src/terminal/terminal.c b/src/terminal/terminal.c index 6bf015cc..d87dfd5a 100644 --- a/src/terminal/terminal.c +++ b/src/terminal/terminal.c @@ -37,6 +37,7 @@ #include "types.h" #include "typescript.h" +#include #include #include #include @@ -1841,8 +1842,22 @@ int guac_terminal_create_typescript(guac_terminal* term, const char* path, /* Create typescript */ term->typescript = guac_terminal_typescript_alloc(path, name, create_path); - /* Typescript creation failed if NULL */ - return term->typescript == NULL; + /* Log failure */ + if (term->typescript == NULL) { + guac_client_log(term->client, GUAC_LOG_ERROR, + "Creation of typescript failed: %s", strerror(errno)); + return 1; + } + + /* If typescript was successfully created, log filenames */ + guac_client_log(term->client, GUAC_LOG_INFO, + "Typescript of terminal session will be saved to \"%s\". " + "Timing file is \"%s\".", + term->typescript->data_filename, + term->typescript->timing_filename); + + /* Typescript creation succeeded */ + return 0; }