maride/guacamole-spice-protocol
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

GUAC-763: Remove stripping of non-printable chars. It will break UTF-8, and the signedness of line_buffer makes the comparisons questionable.

Browse Source
This commit is contained in:
Michael Jumper 2014-07-17 12:33:46 -07:00
parent e01eb6fc10
commit b2c6bc488b
1 changed files with 0 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
src/protocols/telnet/telnet_client.c
View File

@ -122,13 +122,6 @@ static bool __guac_telnet_regex_search(guac_client* client, regex_t* regex, char
length += size; length += size;
line_buffer[length] = '\0'; line_buffer[length] = '\0';
/* Remove non-printable characters as they interfere with regex matching */
for (int i = 0; i < length; i++) {
if (line_buffer[i] <= 31 || (line_buffer[i] >= 128 && line_buffer[i] <= 255)) {
line_buffer[i] = ' ';
}
}
/* Send password upon match */ /* Send password upon match */
if (regexec(regex, line_buffer, 0, NULL, 0) == 0) { if (regexec(regex, line_buffer, 0, NULL, 0) == 0) {