From b00b629b9628d7354d3305bd24523eac07fd80ca Mon Sep 17 00:00:00 2001
From: Nick Couchman <vnick@apache.org>
Date: Sat, 27 Jun 2020 22:57:33 -0400
Subject: [PATCH] GUACAMOLE-221: Clean up VNC mutex; update comments.

---
 src/protocols/rdp/client.c | 1 +
 src/protocols/rdp/rdp.h    | 4 ++++
 src/protocols/vnc/vnc.h    | 3 +++
 3 files changed, 8 insertions(+)

diff --git a/src/protocols/rdp/client.c b/src/protocols/rdp/client.c
index 94998ddb..f521d6e4 100644
--- a/src/protocols/rdp/client.c
+++ b/src/protocols/rdp/client.c
@@ -226,6 +226,7 @@ int guac_rdp_client_free_handler(guac_client* client) {
     
     /* Destroy the pthread conditional handler */
     pthread_cond_destroy(&(rdp_client->rdp_credential_cond));
+    pthread_mutex_destroy(&(rdp_client->rdp_credential_lock));
 
     pthread_rwlock_destroy(&(rdp_client->lock));
 
diff --git a/src/protocols/rdp/rdp.h b/src/protocols/rdp/rdp.h
index 1509913f..26684337 100644
--- a/src/protocols/rdp/rdp.h
+++ b/src/protocols/rdp/rdp.h
@@ -184,6 +184,10 @@ typedef struct guac_rdp_client {
     /**
      * Flags for tracking events related to the rdp_credential_cond
      * pthread condition.
+     * 
+     * @see GUAC_RDP_CRED_FLAG_USERNAME
+     * @see GUAC_RDP_CRED_FLAG_PASSWORD
+     * @see GUAC_RDP_CRED_FLAG_DOMAIN
      */
     unsigned rdp_credential_flags;
 
diff --git a/src/protocols/vnc/vnc.h b/src/protocols/vnc/vnc.h
index ead4e6d1..9a2d48a8 100644
--- a/src/protocols/vnc/vnc.h
+++ b/src/protocols/vnc/vnc.h
@@ -159,6 +159,9 @@ typedef struct guac_vnc_client {
     /**
      * A field to track flags related to retrieving required credentials
      * from the client.
+     *
+     * @see GUAC_VNC_COND_FLAG_USERNAME
+     * @see GUAC_VNC_COND_FLAG_PASSWORD
      */
     unsigned vnc_credential_flags;