From 6ae5b94df3a870b8f73de874c00f00e9a285da80 Mon Sep 17 00:00:00 2001 From: Michael Jumper Date: Tue, 14 Jul 2015 11:15:21 -0700 Subject: [PATCH] GUAC-1171: Always close socket file descriptor when session creation fails. --- src/common-ssh/guac_ssh.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/common-ssh/guac_ssh.c b/src/common-ssh/guac_ssh.c index b9547034..bc6e8a0d 100644 --- a/src/common-ssh/guac_ssh.c +++ b/src/common-ssh/guac_ssh.c @@ -457,6 +457,7 @@ guac_common_ssh_session* guac_common_ssh_create_session(guac_client* client, guac_client_abort(client, GUAC_PROTOCOL_STATUS_UPSTREAM_ERROR, "SSH handshake failed."); free(common_session); + close(fd); return NULL; } @@ -469,6 +470,7 @@ guac_common_ssh_session* guac_common_ssh_create_session(guac_client* client, /* Attempt authentication */ if (guac_common_ssh_authenticate(common_session)) { free(common_session); + close(fd); return NULL; }