From 7de6ba7ea9d4eac25d8db235401e62ece5b0f517 Mon Sep 17 00:00:00 2001 From: Michael Jumper Date: Thu, 25 Jun 2020 14:06:32 -0700 Subject: [PATCH] GUACAMOLE-474: Do not allow RDPDR file downloads via "get" instructions if downloads are disabled. --- src/protocols/rdp/download.c | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/src/protocols/rdp/download.c b/src/protocols/rdp/download.c index fad2932a..d70b8e1c 100644 --- a/src/protocols/rdp/download.c +++ b/src/protocols/rdp/download.c @@ -148,8 +148,8 @@ int guac_rdp_download_get_handler(guac_user* user, guac_object* object, } - /* Otherwise, send file contents */ - else { + /* Otherwise, send file contents if downloads are allowed */ + else if (!fs->disable_download) { /* Create stream data */ guac_rdp_download_status* download_status = malloc(sizeof(guac_rdp_download_status)); @@ -167,6 +167,10 @@ int guac_rdp_download_get_handler(guac_user* user, guac_object* object, } + else + guac_client_log(client, GUAC_LOG_INFO, "Unable to download file " + "\"%s\", file downloads have been disabled.", name); + guac_socket_flush(user->socket); return 0; }