maride/guacamole-spice-protocol
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

GUACAMOLE-303: Ensure there is always space for the null terminator when normalizing.

Browse Source
This commit is contained in:
Michael Jumper 2017-07-04 12:00:43 -07:00
parent 07db9808a0
commit 7857dd0a9a
2 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/common-ssh/sftp.c
View File

@ -77,7 +77,7 @@ static int guac_common_ssh_sftp_normalize_path(char* fullpath,
strncpy(path_component_data, path, sizeof(path_component_data) - 1); strncpy(path_component_data, path, sizeof(path_component_data) - 1);
/* Find path components within path */ /* Find path components within path */
for (i = 0; i < sizeof(path_component_data); i++) { for (i = 0; i < sizeof(path_component_data) - 1; i++) {
/* If current character is a path separator, parse as component */ /* If current character is a path separator, parse as component */
char c = path_component_data[i]; char c = path_component_data[i];

4
src/protocols/rdp/rdp_fs.c
View File

@ -622,10 +622,10 @@ int guac_rdp_fs_normalize_path(const char* path, char* abs_path) {
path++; path++;
/* Copy path into component data for parsing */ /* Copy path into component data for parsing */
strncpy(path_component_data, path, GUAC_RDP_FS_MAX_PATH-1); strncpy(path_component_data, path, sizeof(path_component_data) - 1);
/* Find path components within path */ /* Find path components within path */
for (i=0; i<GUAC_RDP_FS_MAX_PATH; i++) { for (i = 0; i < sizeof(path_component_data) - 1; i++) {
/* If current character is a path separator, parse as component */ /* If current character is a path separator, parse as component */
char c = path_component_data[i]; char c = path_component_data[i];