maride/guacamole-spice-protocol
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

GUACAMOLE-958: Avoid race/deadlock in guacd_timed_client_free()

Browse Source
This commit is contained in:
Jonas Zeiger 2020-02-12 15:06:25 +01:00 committed by Jonas Zeiger
parent 5ecad1c3d9
commit 783aa85c1b
1 changed files with 10 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
src/guacd/proc.c
View File

@ -267,24 +267,24 @@ static int guacd_timed_client_free(guac_client* client, int timeout) {
.tv_nsec = current_time.tv_usec * 1000 .tv_nsec = current_time.tv_usec * 1000
}; };
/* Free the client in a separate thread, so we can time the free operation */
if (pthread_create(&client_free_thread, NULL,
guacd_client_free_thread, &free_operation))
return 1;
/* The mutex associated with the pthread conditional and flag MUST be /* The mutex associated with the pthread conditional and flag MUST be
* acquired before attempting to wait for the condition */ * acquired before attempting to wait for the condition */
if (pthread_mutex_lock(&free_operation.completed_mutex)) if (pthread_mutex_lock(&free_operation.completed_mutex))
return 1; return 1;
/* Free the client in a separate thread, so we can time the free operation */
if (!pthread_create(&client_free_thread, NULL,
guacd_client_free_thread, &free_operation)) {
/* Wait a finite amount of time for the free operation to finish */ /* Wait a finite amount of time for the free operation to finish */
if (pthread_cond_timedwait(&free_operation.completed_cond, (void) pthread_cond_timedwait(&free_operation.completed_cond,
&free_operation.completed_mutex, &deadline)) &free_operation.completed_mutex, &deadline);
return 1; }
(void) pthread_mutex_unlock(&free_operation.completed_mutex);
/* Return status of free operation */ /* Return status of free operation */
return !free_operation.completed; return !free_operation.completed;
} }
/** /**