maride/guacamole-spice-protocol
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

GUACAMOLE-1059: Add missing check for manually copied buffer.

Browse Source
This commit is contained in:
Nick Couchman 2020-05-04 19:49:15 -04:00
parent ac9e5e91f6
commit 71769b9715
1 changed files with 8 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
src/protocols/rdp/channels/rdpsnd/rdpsnd-messages.c
View File

@ -307,6 +307,14 @@ void guac_rdpsnd_wave_handler(guac_rdp_common_svc* svc,
guac_rdp_client* rdp_client = (guac_rdp_client*) client->data; guac_rdp_client* rdp_client = (guac_rdp_client*) client->data;
guac_audio_stream* audio = rdp_client->audio; guac_audio_stream* audio = rdp_client->audio;
/* Verify we have at least 4 bytes, which is manually copied below. */
if (Stream_Length(input_stream) < 4) {
guac_client_log(svc->client, GUAC_LOG_WARNING, "Sound stream does not "
"contain the expected number of bytes. Sound may not work as "
"expected.");
return;
}
/* Wave Confirmation PDU */ /* Wave Confirmation PDU */
wStream* output_stream = Stream_New(NULL, 8); wStream* output_stream = Stream_New(NULL, 8);