maride/guacamole-spice-protocol
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

GUAC-1171: Always close socket file descriptor when session creation fails.

Browse Source
This commit is contained in:
Michael Jumper 2015-07-14 11:15:21 -07:00
parent da1f2f2ad3
commit 6ae5b94df3
1 changed files with 2 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/common-ssh/guac_ssh.c
View File

@ -457,6 +457,7 @@ guac_common_ssh_session* guac_common_ssh_create_session(guac_client* client,
guac_client_abort(client, GUAC_PROTOCOL_STATUS_UPSTREAM_ERROR, guac_client_abort(client, GUAC_PROTOCOL_STATUS_UPSTREAM_ERROR,
"SSH handshake failed."); "SSH handshake failed.");
free(common_session); free(common_session);
close(fd);
return NULL; return NULL;
} }
@ -469,6 +470,7 @@ guac_common_ssh_session* guac_common_ssh_create_session(guac_client* client,
/* Attempt authentication */ /* Attempt authentication */
if (guac_common_ssh_authenticate(common_session)) { if (guac_common_ssh_authenticate(common_session)) {
free(common_session); free(common_session);
close(fd);
return NULL; return NULL;
} }