maride/guacamole-spice-protocol
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

GUACAMOLE-1242: Move "connection closed" log message to debug level.

Browse Source 
It is expected under normal circumstances that the connection may be
abruptly closed, including during the handshake. For example, this will
commonly occur when a TCP load balancer is performing a simple service
health check.

An message noting that the connection has been closed during the
Guacamole protocol handshake is really only of benefit when debugging,
where that information may provide useful context. If not debugging, the
message amounts to log noise.
This commit is contained in:
Michael Jumper 2020-12-22 13:00:46 -08:00
parent 47c7450f0f
commit 3196f9f0d0
2 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/guacd/log.c
View File

@ -133,7 +133,7 @@ void guacd_log_guac_error(guac_client_log_level level, const char* message) {
void guacd_log_handshake_failure() { void guacd_log_handshake_failure() {
if (guac_error == GUAC_STATUS_CLOSED) if (guac_error == GUAC_STATUS_CLOSED)
guacd_log(GUAC_LOG_INFO, guacd_log(GUAC_LOG_DEBUG,
"Guacamole connection closed during handshake"); "Guacamole connection closed during handshake");
else if (guac_error == GUAC_STATUS_PROTOCOL_ERROR) else if (guac_error == GUAC_STATUS_PROTOCOL_ERROR)
guacd_log(GUAC_LOG_ERROR, guacd_log(GUAC_LOG_ERROR,

2
src/libguac/user-handshake.c
View File

@ -100,7 +100,7 @@ static void guac_user_log_guac_error(guac_user* user,
static void guac_user_log_handshake_failure(guac_user* user) { static void guac_user_log_handshake_failure(guac_user* user) {
if (guac_error == GUAC_STATUS_CLOSED) if (guac_error == GUAC_STATUS_CLOSED)
guac_user_log(user, GUAC_LOG_INFO, guac_user_log(user, GUAC_LOG_DEBUG,
"Guacamole connection closed during handshake"); "Guacamole connection closed during handshake");
else if (guac_error == GUAC_STATUS_PROTOCOL_ERROR) else if (guac_error == GUAC_STATUS_PROTOCOL_ERROR)
guac_user_log(user, GUAC_LOG_ERROR, guac_user_log(user, GUAC_LOG_ERROR,