maride/guacamole-spice-protocol
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

GUAC-556: Abort at higher level in RDP message wait function.

Browse Source
This commit is contained in:
Michael Jumper 2014-03-22 14:56:09 -07:00
parent 81d7731e8a
commit 26b5a0c21e
1 changed files with 5 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
src/protocols/rdp/guac_handlers.c
View File

@ -121,16 +121,14 @@ static int rdp_guac_client_wait_for_messages(guac_client* client, int timeout_us
/* Get RDP fds */ /* Get RDP fds */
if (!freerdp_get_fds(rdp_inst, read_fds, &read_count, write_fds, &write_count)) { if (!freerdp_get_fds(rdp_inst, read_fds, &read_count, write_fds, &write_count)) {
guac_error = GUAC_STATUS_BAD_STATE; guac_client_abort(client, GUAC_PROTOCOL_STATUS_SERVER_ERROR, "Unable to read RDP file descriptors.");
guac_error_message = "Unable to read RDP file descriptors";
return -1; return -1;
} }
/* Get channel fds */ /* Get channel fds */
if (!freerdp_channels_get_fds(channels, rdp_inst, read_fds, &read_count, write_fds, if (!freerdp_channels_get_fds(channels, rdp_inst, read_fds, &read_count, write_fds,
&write_count)) { &write_count)) {
guac_error = GUAC_STATUS_BAD_STATE; guac_client_abort(client, GUAC_PROTOCOL_STATUS_SERVER_ERROR, "Unable to read RDP channel file descriptors.");
guac_error_message = "Unable to read RDP channel file descriptors";
return -1; return -1;
} }
@ -155,8 +153,7 @@ static int rdp_guac_client_wait_for_messages(guac_client* client, int timeout_us
/* If no file descriptors, error */ /* If no file descriptors, error */
if (max_fd == 0) { if (max_fd == 0) {
guac_error = GUAC_STATUS_BAD_STATE; guac_client_abort(client, GUAC_PROTOCOL_STATUS_SERVER_ERROR, "No file descriptors associated with RDP connection.");
guac_error_message = "No file descriptors";
return -1; return -1;
} }
@ -172,8 +169,7 @@ static int rdp_guac_client_wait_for_messages(guac_client* client, int timeout_us
return 0; return 0;
/* Otherwise, return as error */ /* Otherwise, return as error */
guac_error = GUAC_STATUS_SEE_ERRNO; guac_client_abort(client, GUAC_PROTOCOL_STATUS_SERVER_ERROR, "Error waiting for file descriptor.");
guac_error_message = "Error waiting for file descriptor";
return -1; return -1;
} }
@ -261,10 +257,8 @@ int rdp_guac_client_handle_messages(guac_client* client) {
} }
/* If an error occurred, fail */ /* If an error occurred, fail */
if (wait_result < 0) { if (wait_result < 0)
guac_client_abort(client, GUAC_PROTOCOL_STATUS_UPSTREAM_ERROR, "Connection closed.");
return 1; return 1;
}
/* Success */ /* Success */
return 0; return 0;