maride/guacamole-spice-protocol
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

GUACAMOLE-1191: Merge always disable the glyph cache due to stability issues.

Browse Source
This commit is contained in:
Virtually Nick 2021-01-09 22:46:12 -05:00 committed by GitHub
commit 1c3e86dc2c
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 18 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

21
src/protocols/rdp/settings.c
View File

@ -850,9 +850,24 @@ guac_rdp_settings* guac_rdp_parse_args(guac_user* user,
guac_user_parse_args_boolean(user, GUAC_RDP_CLIENT_ARGS, argv,
IDX_DISABLE_OFFSCREEN_CACHING, 0);
settings->disable_glyph_caching =
guac_user_parse_args_boolean(user, GUAC_RDP_CLIENT_ARGS, argv,
IDX_DISABLE_GLYPH_CACHING, 0);
/* FreeRDP does not consider the glyph cache implementation to be stable as
* of 2.0.0, and it MUST NOT be used. Usage of the glyph cache results in
* unexpected disconnects when using older versions of Windows and recent
* versions of FreeRDP. See: https://issues.apache.org/jira/browse/GUACAMOLE-1191 */
settings->disable_glyph_caching = 1;
/* In case the user expects glyph caching to be enabled, either explicitly
* or by default, warn that this will not be the case as the glyph cache
* is not considered stable. */
if (!guac_user_parse_args_boolean(user, GUAC_RDP_CLIENT_ARGS, argv,
IDX_DISABLE_GLYPH_CACHING, 0)) {
guac_user_log(user, GUAC_LOG_DEBUG, "Glyph caching is currently "
"universally disabled, regardless of the value of the \"%s\" "
"parameter, as glyph caching support is not considered stable "
"by FreeRDP as of the FreeRDP 2.0.0 release. See: "
"https://issues.apache.org/jira/browse/GUACAMOLE-1191",
GUAC_RDP_CLIENT_ARGS[IDX_DISABLE_GLYPH_CACHING]);
}
/* Session color depth */
settings->color_depth =