maride/guacamole-spice-protocol
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Merge pull request #70 from glyptodon/sftp-default-directory

Browse Source 
GUAC-1292: Use "sftp-directory" for default upload directory, if specified, for both VNC and RDP.
This commit is contained in:
James Muehlner 2015-08-13 16:27:29 -07:00
commit 0bfacb3d55
2 changed files with 27 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

20
src/protocols/rdp/client.c
View File

@ -137,6 +137,7 @@ const char* GUAC_CLIENT_ARGS[] = {
"sftp-password", "sftp-password",
"sftp-private-key", "sftp-private-key",
"sftp-passphrase", "sftp-passphrase",
"sftp-directory",
#endif #endif
NULL NULL
@ -184,6 +185,7 @@ enum RDP_ARGS_IDX {
IDX_SFTP_PASSWORD, IDX_SFTP_PASSWORD,
IDX_SFTP_PRIVATE_KEY, IDX_SFTP_PRIVATE_KEY,
IDX_SFTP_PASSPHRASE, IDX_SFTP_PASSPHRASE,
IDX_SFTP_DIRECTORY,
#endif #endif
RDP_ARGS_COUNT RDP_ARGS_COUNT
@ -302,9 +304,15 @@ BOOL rdp_freerdp_pre_connect(freerdp* instance) {
/* Load filesystem if drive enabled */ /* Load filesystem if drive enabled */
if (guac_client_data->settings.drive_enabled) { if (guac_client_data->settings.drive_enabled) {
/* Allocate filesystem */
guac_client_data->filesystem = guac_client_data->filesystem =
guac_rdp_fs_alloc(client, guac_client_data->settings.drive_path); guac_rdp_fs_alloc(client, guac_client_data->settings.drive_path);
/* Use for basic uploads if no other handler set */
if (client->file_handler == NULL)
client->file_handler = guac_rdp_upload_file_handler; client->file_handler = guac_rdp_upload_file_handler;
} }
/* If RDPDR required, load it */ /* If RDPDR required, load it */
@ -900,8 +908,16 @@ int guac_client_init(guac_client* client, int argc, char** argv) {
return 1; return 1;
} }
/* Use SFTP for basic uploads, if drive not enabled */ /* Configure destination for basic uploads, if specified */
if (!settings->drive_enabled) if (argv[IDX_SFTP_DIRECTORY][0] != '\0') {
client->file_handler = guac_rdp_sftp_file_handler;
guac_common_ssh_sftp_set_upload_path(
guac_client_data->sftp_filesystem,
argv[IDX_SFTP_DIRECTORY]);
}
/* Otherwise, use SFTP for basic uploads only if drive not enabled */
else if (!settings->drive_enabled)
client->file_handler = guac_rdp_sftp_file_handler; client->file_handler = guac_rdp_sftp_file_handler;
guac_client_log(client, GUAC_LOG_DEBUG, guac_client_log(client, GUAC_LOG_DEBUG,

8
src/protocols/vnc/client.c
View File

@ -85,6 +85,7 @@ const char* GUAC_CLIENT_ARGS[] = {
"sftp-password", "sftp-password",
"sftp-private-key", "sftp-private-key",
"sftp-passphrase", "sftp-passphrase",
"sftp-directory",
#endif #endif
NULL NULL
@ -125,6 +126,7 @@ enum VNC_ARGS_IDX {
IDX_SFTP_PASSWORD, IDX_SFTP_PASSWORD,
IDX_SFTP_PRIVATE_KEY, IDX_SFTP_PRIVATE_KEY,
IDX_SFTP_PASSPHRASE, IDX_SFTP_PASSPHRASE,
IDX_SFTP_DIRECTORY,
#endif #endif
VNC_ARGS_COUNT VNC_ARGS_COUNT
@ -433,6 +435,12 @@ int guac_client_init(guac_client* client, int argc, char** argv) {
return 1; return 1;
} }
/* Configure destination for basic uploads, if specified */
if (argv[IDX_SFTP_DIRECTORY][0] != '\0')
guac_common_ssh_sftp_set_upload_path(
guac_client_data->sftp_filesystem,
argv[IDX_SFTP_DIRECTORY]);
/* Set file handler for basic uploads */ /* Set file handler for basic uploads */
client->file_handler = guac_vnc_sftp_file_handler; client->file_handler = guac_vnc_sftp_file_handler;